Commit Graph

5126 Commits

Author SHA1 Message Date
Scott Pfeil
44428da44a Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_button 2023-09-20 21:32:50 -04:00
Scott Pfeil
6e27bd1dd9 Merge branch 'feature/atomic_vds_button' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_button 2023-09-15 12:14:05 -04:00
Scott Pfeil
68ad659559 pill button open 2023-09-15 12:13:44 -04:00
Scott Pfeil
917a0f8480 PillButton inverted-> surface 2023-09-15 12:13:02 -04:00
Pfeil, Scott Robert
75e6339443 Merge branch 'bugfix/SubNavManager-ReplaceVC' into 'develop'
Passing subNavManager's delegate to NavigationHandler in replaceViewController call

### Summary
Issue: When a page has multiple tabs, navigating between each tab is not updating the tab selection status (red selection line), only replaces the view controller.

Root cause: while switching between the tabs, the viewcontroller's are being replaced without the delegate object in replaceViewController call, because of this the navigation delegate is not updating the subNavigation manager class to update the tab selection.

### JIRA Ticket

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/994
2023-09-15 14:48:39 +00:00
Sumanth Nadigadda
9a191d9516 defect: Passing subNavManager's delegate to NavigationHandler, so that the delegate can update the viewcontroller for the tab updates 2023-09-15 11:22:48 +05:30
Matt Bruce
fe580d12e4 updated onClick
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-14 16:02:26 -05:00
Matt Bruce
34d3386d36 updated onClick
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-14 16:02:15 -05:00
Scott Pfeil
c2cc637c38 remove old junk 2023-09-14 16:35:44 -04:00
Scott Pfeil
a925560ecb RawRepresentableCodable 2023-09-14 16:18:10 -04:00
Scott Pfeil
c82a0cd4d6 Make PillButton VDSMoleculeViewProtocol 2023-09-14 14:49:07 -04:00
Scott Pfeil
741bf0501b Updates to Button 2023-09-14 14:14:30 -04:00
Scott Pfeil
8e35e8036a Tiny button to small 2023-09-14 13:55:17 -04:00
Scott Pfeil
4c2214d7d4 VDS Button to atomic beginning/ 2023-09-14 10:37:42 -04:00
Pfeil, Scott Robert
022319c186 Merge branch 'feature/molecule_id_replacement' into 'develop'
Add an optional ID field to every molecule.

### Summary
Add an ID to molecule models.

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/992
2023-09-07 17:25:21 +00:00
Hedden, Kyle Matthew
b19d009cff unnecessary coding key 2023-09-07 13:07:49 -04:00
Hedden, Kyle Matthew
0e300ca5a7 DecodableDefault.UUID -> UUIDString 2023-09-07 12:46:05 -04:00
Hedden, Kyle Matthew
b6c3159b52 Change ID default initializer, DecodableDefault for implicit decoding models. Add missing id encodes and decodes. 2023-09-07 09:20:44 -04:00
Hedden, Kyle Matthew
94defaa6bc Remove test code. 2023-09-07 08:34:28 -04:00
Hedden, Kyle Matthew
7da47bb77a Add an optional ID field to every molecule. 2023-09-05 21:02:24 -04:00
Hedden, Kyle Matthew
b1966a87ea Merge branch 'bugfix/tilelet' into 'develop'
fixed refactor bug

### Summary
I had refactored the textWidth into use an enum to handle whether the value is a for a fixed value or a percentage.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/991
2023-08-30 21:10:03 +00:00
Matt Bruce
0e68df5624 fixed refactor bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-08-30 15:58:21 -05:00
Pfeil, Scott Robert
f8558602be Merge branch 'feature/navigation_handler_modernize' into 'develop'
Feature/navigation handler modernize

### Summary
Modernize navigation handler.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5208

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/989
2023-08-28 21:56:56 +00:00
Scott Pfeil
e8fcf1ac5d ONEAPP-5208: Review feedback 2023-08-28 11:13:40 -04:00
Scott Pfeil
caab123781 update check for notification handler 2023-08-21 18:03:05 -04:00
Scott Pfeil
07fcca17fc Remove debug comments 2023-08-21 17:20:27 -04:00
Scott Pfeil
ba8aa92994 ONEAPP-5208: Swiftify the navigation handler 2023-08-21 17:03:49 -04:00
Scott Pfeil
8ab996d8f8 Merge branch 'develop' into feature/navigation_handler_modernize 2023-08-15 16:30:21 -04:00
Scott Pfeil
d3fe47522c Swiftification of Navigation Handler 2023-08-15 16:23:13 -04:00
Pfeil, Scott Robert
4e8ba20edc Merge branch 'release/10_9_0' into 'develop'
Release/10 9 0

Co-authored-by: Kyle Hedden <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/988
2023-08-14 20:25:21 +00:00
Pfeil, Scott Robert
616539ea28 Merge branch 'bugfix/notification_timer_crash' into 'release/10_9_0'
serialize timer updates to prevent cold dispatch collisions

### Summary
Serialize the timer updates to prevent multi-access issues triggering thread crashes.

### Crash Details
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/f0de1b60b067cedb33da2c04100c0c14?time=last-thirty-days&versions=10.8.0%20(20422)&sessionEventKey=fd3321a34ed74beca372b60e89d57c70_1843869769594539690

```
Crashed: com.apple.root.user-initiated-qos.cooperative
0  libdispatch.dylib              0x3ae7c _dispatch_queue_xref_dispose.cold.2 + 36
1  libdispatch.dylib              0xa4f8 _dispatch_lane_suspend + 62
2  libdispatch.dylib              0x3714 -[OS_dispatch_source _xref_dispose] + 28
3  MVMCoreUI                      0x263e44 NotificationOperation.updateStopTimer() + 218 (NotificationHandler.swift:218)
4  MVMCoreUI                      0x266890 NotificationOperation.update(with:delegateObject:) + 565 (NotificationHandler.swift:565)
5  MVMCoreUI                      0x26665c NotificationHandler.checkAndUpdateExisting(with:delegateObject:) + 419 (NotificationHandler.swift:419)
6  MobileFirstFramework           0x56afa0 MFNotificationHandler.checkAndUpdateExisting(with:delegateObject:) + 436 (TopAlertLegacyBridging.swift:436)
7  MVMCoreUI                      0x267564 (1) suspend resume partial function for NotificationHandler.showNotification(for:delegateObject:) + 495 (NotificationHandler.swift:495)
8  libswift_Concurrency.dylib     0x41948 swift::runJobInEstablishedExecutorContext(swift::Job*) + 416
9  libswift_Concurrency.dylib     0x42868 swift_job_runImpl(swift::Job*, swift::ExecutorRef) + 72
10 libdispatch.dylib              0x15944 _dispatch_root_queue_drain + 396
11 libdispatch.dylib              0x16158 _dispatch_worker_thread2 + 164
12 libsystem_pthread.dylib        0xda0 _pthread_wqthread + 228
13 libsystem_pthread.dylib        0xb7c start_wqthread + 8
```

Co-authored-by: Kyle Hedden <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/987
2023-08-10 14:26:53 +00:00
Kyle Hedden
e7f21b980f serialize timer updates to prevent cold dispatch collisions 2023-08-09 16:37:03 -04:00
Hedden, Kyle Matthew
3ad04abfed Merge branch 'feature/accessibility_traits_codable' into 'develop'
Feature/accessibility traits codable

### Summary
Making accessibility traits codable.

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/966
2023-07-31 19:43:23 +00:00
Scott Pfeil
d02b346d39 update dependency 2023-07-31 15:00:41 -04:00
Scott Pfeil
ad0087b88a Header traits 2023-07-31 14:33:20 -04:00
Scott Pfeil
438e0da13a Merge branch 'develop' into feature/accessibility_traits_codable 2023-07-31 13:55:51 -04:00
Bruce, Matt R
7e98a54d70 Merge branch 'feature/BaseDropDown-OpenAccess' into 'develop'
changing access from public to open for few methods in base drop down field

### Summary
(a brief description of the change)

### JIRA Ticket
(ticket URL here or remove the section)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/983
2023-07-28 12:59:01 +00:00
Sumanth Nadigadda
dce8143ed2 changing access from public to open for few methods in base drop down field 2023-07-28 17:35:59 +05:30
Pfeil, Scott Robert
e876ebca2a Merge branch 'bugfix/PRODDEF-1280' into 'develop'
Accessibility focus getting struck in View not going to tabbar

### Summary
Accessibility focus getting struck in View not going to tabbar.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1280

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>
Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/981
2023-07-24 14:50:12 +00:00
Krishna Kishore Bandaru
a8115e068e added accessibilityElements for stack 2023-07-24 20:15:01 +05:30
Keerthy
e70d1dc151 Focus getting stuck in backward direction for stack 2023-07-21 15:58:34 +05:30
Keerthy
fb22b5c614 Removed accessibilityElements to resolve focus stuck 2023-07-21 15:44:35 +05:30
Bruce, Matt R
a33846d1a3 Merge branch 'feature/native_mockups' into 'develop'
Prospect atomic changes

### Summary
bugfixes to allow prospect to work

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4325

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/971
2023-07-12 14:32:44 +00:00
Pfeil, Scott Robert
ffa9890221 Merge branch 'release/10_8_0' into 'develop'
release/10_8_0 hotfix merge

Co-authored-by: Ramya Subramaniam <ramya.subramaniam@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/969
2023-07-12 14:26:34 +00:00
Pfeil, Scott Robert
5a99da0189 Merge branch 'bugfix/CXTDT-434858' into 'release/10_8_0'
Defect: CXTDT-434858 Support panel is not opening for L2 authentication

### Summary
User is not able to navigate to Support page during step up authentication.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-434858

Co-authored-by: Ramya Subramaniam <ramya.subramaniam@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/977
2023-07-11 13:39:30 +00:00
Ramya Subramaniam
e8c6a10935 updating the condition 2023-07-11 19:01:34 +05:30
Ramya Subramaniam
23ec67e668 Defect: CXTDT-434858 Support panel is not opening for L2 authentication 2023-07-11 18:51:40 +05:30
Pfeil, Scott Robert
b49c03fa7f Merge branch 'develop' into 'release/10_8_0'
updated logic for change in VDS TitleLockup/Tilelet

### Summary
merge develop

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/976
2023-06-30 18:01:46 +00:00
Pfeil, Scott Robert
82126f630d Merge branch 'bugfix/CXTDT-431466' into 'develop'
CXTDT-431466: Fix for notification handler update.

### Summary
Bugfix for missing update notification logic.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-431466

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/975
2023-06-30 17:51:00 +00:00
Scott Pfeil
dd549593af CXTDT-431466: Fix for notification handler update. 2023-06-30 13:07:21 -04:00