mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'bugfix/SubNavManager-ReplaceVC' into 'develop'

Browse Source 
Passing subNavManager's delegate to NavigationHandler in replaceViewController call

### Summary
Issue: When a page has multiple tabs, navigating between each tab is not updating the tab selection status (red selection line), only replaces the view controller.

Root cause: while switching between the tabs, the viewcontroller's are being replaced without the delegate object in replaceViewController call, because of this the navigation delegate is not updating the subNavigation manager class to update the tab selection.

### JIRA Ticket

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/994
This commit is contained in:
Pfeil, Scott Robert 2023-09-15 14:48:39 +00:00
commit 75e6339443
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MVMCoreUI/Managers/SubNav/SubNavManagerController.swift
View File

@ -273,7 +273,7 @@ open class SubNavManagerController: ViewController, MVMCoreViewManagerProtocol,
// Load controller from the cache
needToTrackTabSelect = true
Task(priority: .userInitiated) {
await NavigationHandler.shared().replace(viewController: controller, navigationController: subNavigationController, tryToReplace: false, animated: true)
await NavigationHandler.shared().replace(viewController: controller, navigationController:subNavigationController, delegateObject:delegateObject(), tryToReplace: false, animated: true)
}
} else if let tabsModel = tabs.tabsModel,
let action = tabsModel.tabs[indexPath.row].action {