Commit Graph

5140 Commits

Author SHA1 Message Date
Scott Pfeil
1da8a6db77 Default to secondary 2023-09-28 20:12:36 -04:00
Scott Pfeil
4d4f7c334d Code review: Fix data list items and navigation bar. 2023-09-28 19:41:06 -04:00
Scott Pfeil
3f6e1b1baa Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_line 2023-09-28 18:08:43 -04:00
Hedden, Kyle Matthew
bab59e4e5d Merge branch 'bugfix/account_native_testing' into 'develop'
Link Fix

### Summary
Fix to Link

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/999
2023-09-28 13:40:00 +00:00
Scott Pfeil
ab9d61fd15 Link Fix 2023-09-28 09:25:50 -04:00
Matt Bruce
75400c31cb Merge branch 'feature/atomic_vds_line' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_line 2023-09-27 16:29:14 -05:00
Matt Bruce
8d15044516 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_line 2023-09-27 15:57:59 -05:00
Pfeil, Scott Robert
451b073718 Merge branch 'feature/isDark' into 'develop'
added color extension for isDark

### Summary
(a brief description of the change)

### JIRA Ticket
(ticket URL here or remove the section)

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/998
2023-09-27 20:57:28 +00:00
Matt Bruce
a19bd60f06 indented
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:56:53 -05:00
Matt Bruce
f98c6059b8 rearranged
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:53:53 -05:00
Matt Bruce
ab50921e88 added color extension for isDark
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:34:49 -05:00
Matt Bruce
1a0e36ddd6 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_line 2023-09-27 09:57:48 -05:00
Hedden, Kyle Matthew
b7a1cf6af6 Merge branch 'bugfix/proddef-1299' into 'develop'
Headline body component's accessibility label issue

### Summary
Fixed headline body component's accessibility label issue

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1299

Co-authored-by: Sourabh Bhardwaj <sourabh.bhardwaj@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/997
2023-09-25 14:36:30 +00:00
Sourabh Bhardwaj
1e12517c55 Fixed headline body component's accessbility label issue 2023-09-25 19:38:01 +05:30
Matt Bruce
2a34fa433d updated for line
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 14:51:21 -05:00
Matt Bruce
6da75b26bd don't call super to draw if model is set to none
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 14:51:12 -05:00
Matt Bruce
b2b33db8a9 Revert "Revert "subclass line directly""
This reverts commit 10370f3ac6.
2023-09-20 14:40:56 -05:00
Matt Bruce
10370f3ac6 Revert "subclass line directly"
This reverts commit 5d9944b5ea.
2023-09-20 14:35:46 -05:00
Matt Bruce
62afe434f9 updated to use line properties
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 14:07:49 -05:00
Matt Bruce
5d9944b5ea subclass line directly
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 14:07:36 -05:00
Matt Bruce
aed46d592c updated tabs and tabs model
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 13:28:38 -05:00
Matt Bruce
81a5d5099f updated ListRightVariableTotalData
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 13:28:16 -05:00
Matt Bruce
2e03cec5be updated ListProgressBarThin
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 13:27:51 -05:00
Matt Bruce
099fce290e updated LineModel and Line
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 13:26:31 -05:00
Matt Bruce
470bb160d6 update for VDS Protocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 13:25:33 -05:00
Matt Bruce
05069e044c added helper protocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-20 09:55:56 -05:00
Pfeil, Scott Robert
75e6339443 Merge branch 'bugfix/SubNavManager-ReplaceVC' into 'develop'
Passing subNavManager's delegate to NavigationHandler in replaceViewController call

### Summary
Issue: When a page has multiple tabs, navigating between each tab is not updating the tab selection status (red selection line), only replaces the view controller.

Root cause: while switching between the tabs, the viewcontroller's are being replaced without the delegate object in replaceViewController call, because of this the navigation delegate is not updating the subNavigation manager class to update the tab selection.

### JIRA Ticket

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/994
2023-09-15 14:48:39 +00:00
Sumanth Nadigadda
9a191d9516 defect: Passing subNavManager's delegate to NavigationHandler, so that the delegate can update the viewcontroller for the tab updates 2023-09-15 11:22:48 +05:30
Pfeil, Scott Robert
022319c186 Merge branch 'feature/molecule_id_replacement' into 'develop'
Add an optional ID field to every molecule.

### Summary
Add an ID to molecule models.

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/992
2023-09-07 17:25:21 +00:00
Hedden, Kyle Matthew
b19d009cff unnecessary coding key 2023-09-07 13:07:49 -04:00
Hedden, Kyle Matthew
0e300ca5a7 DecodableDefault.UUID -> UUIDString 2023-09-07 12:46:05 -04:00
Hedden, Kyle Matthew
b6c3159b52 Change ID default initializer, DecodableDefault for implicit decoding models. Add missing id encodes and decodes. 2023-09-07 09:20:44 -04:00
Hedden, Kyle Matthew
94defaa6bc Remove test code. 2023-09-07 08:34:28 -04:00
Hedden, Kyle Matthew
7da47bb77a Add an optional ID field to every molecule. 2023-09-05 21:02:24 -04:00
Hedden, Kyle Matthew
b1966a87ea Merge branch 'bugfix/tilelet' into 'develop'
fixed refactor bug

### Summary
I had refactored the textWidth into use an enum to handle whether the value is a for a fixed value or a percentage.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/991
2023-08-30 21:10:03 +00:00
Matt Bruce
0e68df5624 fixed refactor bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-08-30 15:58:21 -05:00
Pfeil, Scott Robert
f8558602be Merge branch 'feature/navigation_handler_modernize' into 'develop'
Feature/navigation handler modernize

### Summary
Modernize navigation handler.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5208

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/989
2023-08-28 21:56:56 +00:00
Scott Pfeil
e8fcf1ac5d ONEAPP-5208: Review feedback 2023-08-28 11:13:40 -04:00
Scott Pfeil
caab123781 update check for notification handler 2023-08-21 18:03:05 -04:00
Scott Pfeil
07fcca17fc Remove debug comments 2023-08-21 17:20:27 -04:00
Scott Pfeil
ba8aa92994 ONEAPP-5208: Swiftify the navigation handler 2023-08-21 17:03:49 -04:00
Scott Pfeil
8ab996d8f8 Merge branch 'develop' into feature/navigation_handler_modernize 2023-08-15 16:30:21 -04:00
Scott Pfeil
d3fe47522c Swiftification of Navigation Handler 2023-08-15 16:23:13 -04:00
Pfeil, Scott Robert
4e8ba20edc Merge branch 'release/10_9_0' into 'develop'
Release/10 9 0

Co-authored-by: Kyle Hedden <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/988
2023-08-14 20:25:21 +00:00
Pfeil, Scott Robert
616539ea28 Merge branch 'bugfix/notification_timer_crash' into 'release/10_9_0'
serialize timer updates to prevent cold dispatch collisions

### Summary
Serialize the timer updates to prevent multi-access issues triggering thread crashes.

### Crash Details
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/f0de1b60b067cedb33da2c04100c0c14?time=last-thirty-days&versions=10.8.0%20(20422)&sessionEventKey=fd3321a34ed74beca372b60e89d57c70_1843869769594539690

```
Crashed: com.apple.root.user-initiated-qos.cooperative
0  libdispatch.dylib              0x3ae7c _dispatch_queue_xref_dispose.cold.2 + 36
1  libdispatch.dylib              0xa4f8 _dispatch_lane_suspend + 62
2  libdispatch.dylib              0x3714 -[OS_dispatch_source _xref_dispose] + 28
3  MVMCoreUI                      0x263e44 NotificationOperation.updateStopTimer() + 218 (NotificationHandler.swift:218)
4  MVMCoreUI                      0x266890 NotificationOperation.update(with:delegateObject:) + 565 (NotificationHandler.swift:565)
5  MVMCoreUI                      0x26665c NotificationHandler.checkAndUpdateExisting(with:delegateObject:) + 419 (NotificationHandler.swift:419)
6  MobileFirstFramework           0x56afa0 MFNotificationHandler.checkAndUpdateExisting(with:delegateObject:) + 436 (TopAlertLegacyBridging.swift:436)
7  MVMCoreUI                      0x267564 (1) suspend resume partial function for NotificationHandler.showNotification(for:delegateObject:) + 495 (NotificationHandler.swift:495)
8  libswift_Concurrency.dylib     0x41948 swift::runJobInEstablishedExecutorContext(swift::Job*) + 416
9  libswift_Concurrency.dylib     0x42868 swift_job_runImpl(swift::Job*, swift::ExecutorRef) + 72
10 libdispatch.dylib              0x15944 _dispatch_root_queue_drain + 396
11 libdispatch.dylib              0x16158 _dispatch_worker_thread2 + 164
12 libsystem_pthread.dylib        0xda0 _pthread_wqthread + 228
13 libsystem_pthread.dylib        0xb7c start_wqthread + 8
```

Co-authored-by: Kyle Hedden <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/987
2023-08-10 14:26:53 +00:00
Kyle Hedden
e7f21b980f serialize timer updates to prevent cold dispatch collisions 2023-08-09 16:37:03 -04:00
Hedden, Kyle Matthew
3ad04abfed Merge branch 'feature/accessibility_traits_codable' into 'develop'
Feature/accessibility traits codable

### Summary
Making accessibility traits codable.

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/966
2023-07-31 19:43:23 +00:00
Scott Pfeil
d02b346d39 update dependency 2023-07-31 15:00:41 -04:00
Scott Pfeil
ad0087b88a Header traits 2023-07-31 14:33:20 -04:00
Scott Pfeil
438e0da13a Merge branch 'develop' into feature/accessibility_traits_codable 2023-07-31 13:55:51 -04:00