mbrucedogs/vds_ios
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'mbruce/bugfixes' into 'develop'

Browse Source 
ONEAPP-4683 - updated to accesibilityValue for the tabs position.

See merge request BPHV_MIPS/vds_ios!144
This commit is contained in:
Bruce, Matt R 2024-02-06 20:59:15 +00:00
commit 74d1601373
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
VDS.xcodeproj/project.pbxproj
View File

@ -1233,7 +1233,7 @@
BUILD_LIBRARY_FOR_DISTRIBUTION = YES; BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CODE_SIGN_IDENTITY = ""; CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Automatic; CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 52; CURRENT_PROJECT_VERSION = 53;
DEFINES_MODULE = YES; DEFINES_MODULE = YES;
DEVELOPMENT_TEAM = ""; DEVELOPMENT_TEAM = "";
DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_COMPATIBILITY_VERSION = 1;
@ -1270,7 +1270,7 @@
BUILD_LIBRARY_FOR_DISTRIBUTION = YES; BUILD_LIBRARY_FOR_DISTRIBUTION = YES;
CODE_SIGN_IDENTITY = ""; CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Automatic; CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 52; CURRENT_PROJECT_VERSION = 53;
DEFINES_MODULE = YES; DEFINES_MODULE = YES;
DEVELOPMENT_TEAM = ""; DEVELOPMENT_TEAM = "";
DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_COMPATIBILITY_VERSION = 1;

5
VDS/Components/Tabs/Tabs.swift
View File

@ -171,6 +171,8 @@ open class Tabs: View {
/// Called once when a view is initialized and is used to Setup additional UI or other constants and configurations. /// Called once when a view is initialized and is used to Setup additional UI or other constants and configurations.
open override func setup() { open override func setup() {
super.setup() super.setup()
isAccessibilityElement = false
scrollView = UIScrollView() scrollView = UIScrollView()
scrollView.translatesAutoresizingMaskIntoConstraints = false scrollView.translatesAutoresizingMaskIntoConstraints = false
scrollView.showsHorizontalScrollIndicator = false scrollView.showsHorizontalScrollIndicator = false
@ -262,6 +264,7 @@ open class Tabs: View {
model.onClick?(tab.index) model.onClick?(tab.index)
self.selectedIndex = tab.index self.selectedIndex = tab.index
self.onTabDidSelect?(tab.index) self.onTabDidSelect?(tab.index)
let t = tabViews[tab.index]
} }
} }
} }
@ -301,7 +304,7 @@ open class Tabs: View {
tabItem.orientation = orientation tabItem.orientation = orientation
tabItem.surface = surface tabItem.surface = surface
tabItem.indicatorPosition = indicatorPosition tabItem.indicatorPosition = indicatorPosition
tabItem.accessibilityHint = "\(index+1) of \(tabViews.count) Tabs" tabItem.accessibilityValue = "\(index+1) of \(tabViews.count) Tabs"
} }
} }

4
VDS/SupportingFiles/ReleaseNotes.txt
View File

@ -1,3 +1,7 @@
1.0.53
----------------
- ONEAPP-4683 - Updated to accesibilityValue for the tabs position.
1.0.52 1.0.52
---------------- ----------------
- ONEAPP-6244 - TitleLockup TitleLabel marked as .heading for Accessibility. - ONEAPP-6244 - TitleLockup TitleLabel marked as .heading for Accessibility.