From 3720541b42c8078aec0c734aa1d22db341b9dddd Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Tue, 6 Feb 2024 14:38:22 -0600 Subject: [PATCH 1/2] ONEAPP-4683 - updated to accesibilityValue for the tabs position. Signed-off-by: Matt Bruce --- VDS/Components/Tabs/Tabs.swift | 5 ++++- VDS/SupportingFiles/ReleaseNotes.txt | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/VDS/Components/Tabs/Tabs.swift b/VDS/Components/Tabs/Tabs.swift index d6273771..0aa81bdf 100644 --- a/VDS/Components/Tabs/Tabs.swift +++ b/VDS/Components/Tabs/Tabs.swift @@ -171,6 +171,8 @@ open class Tabs: View { /// Called once when a view is initialized and is used to Setup additional UI or other constants and configurations. open override func setup() { super.setup() + isAccessibilityElement = false + scrollView = UIScrollView() scrollView.translatesAutoresizingMaskIntoConstraints = false scrollView.showsHorizontalScrollIndicator = false @@ -262,6 +264,7 @@ open class Tabs: View { model.onClick?(tab.index) self.selectedIndex = tab.index self.onTabDidSelect?(tab.index) + let t = tabViews[tab.index] } } } @@ -301,7 +304,7 @@ open class Tabs: View { tabItem.orientation = orientation tabItem.surface = surface tabItem.indicatorPosition = indicatorPosition - tabItem.accessibilityHint = "\(index+1) of \(tabViews.count) Tabs" + tabItem.accessibilityValue = "\(index+1) of \(tabViews.count) Tabs" } } diff --git a/VDS/SupportingFiles/ReleaseNotes.txt b/VDS/SupportingFiles/ReleaseNotes.txt index b4ae5bbb..04a04a10 100644 --- a/VDS/SupportingFiles/ReleaseNotes.txt +++ b/VDS/SupportingFiles/ReleaseNotes.txt @@ -1,3 +1,7 @@ +1.0.53 +---------------- +- ONEAPP-4683 - Updated to accesibilityValue for the tabs position. + 1.0.52 ---------------- - ONEAPP-6244 - TitleLockup TitleLabel marked as .heading for Accessibility. From f66d15fdfca05dcbaec20ef932a028bf43b523ce Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Tue, 6 Feb 2024 14:48:23 -0600 Subject: [PATCH 2/2] updated version Signed-off-by: Matt Bruce --- VDS.xcodeproj/project.pbxproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/VDS.xcodeproj/project.pbxproj b/VDS.xcodeproj/project.pbxproj index c28da8f9..74159fed 100644 --- a/VDS.xcodeproj/project.pbxproj +++ b/VDS.xcodeproj/project.pbxproj @@ -1233,7 +1233,7 @@ BUILD_LIBRARY_FOR_DISTRIBUTION = YES; CODE_SIGN_IDENTITY = ""; CODE_SIGN_STYLE = Automatic; - CURRENT_PROJECT_VERSION = 52; + CURRENT_PROJECT_VERSION = 53; DEFINES_MODULE = YES; DEVELOPMENT_TEAM = ""; DYLIB_COMPATIBILITY_VERSION = 1; @@ -1270,7 +1270,7 @@ BUILD_LIBRARY_FOR_DISTRIBUTION = YES; CODE_SIGN_IDENTITY = ""; CODE_SIGN_STYLE = Automatic; - CURRENT_PROJECT_VERSION = 52; + CURRENT_PROJECT_VERSION = 53; DEFINES_MODULE = YES; DEVELOPMENT_TEAM = ""; DYLIB_COMPATIBILITY_VERSION = 1;