Commit Graph

1013 Commits

Author SHA1 Message Date
Robinson, Blake
e11f64f0a4 Changed to optionalStringForKey 2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375 Used guard instead of if let because some code after the if let was removed 2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9 Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton. 2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab Removes self where unnecessary 2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57 Changed to MVMCoreUIUtility.getWidth() as per pr comments 2019-12-19 12:23:01 -05:00
Robinson, Blake
f731b56f2e Revert "Make Link subclass from View instead of MFCustomButton"
This reverts commit 439261e4c4.
2019-12-17 10:23:56 -05:00
Robinson, Blake
439261e4c4 Make Link subclass from View instead of MFCustomButton
The bounds of the Link often extend far beyond the width of the button text, which, if MFCustomButton is used, extend the tappable area far beyond the link.
2019-12-12 15:23:30 -05:00
Robinson, Blake
d3dbfdd997 changes size object to private since it shouldn't be accessed from outside the class 2019-12-12 15:01:54 -05:00
Robinson, Blake
3fc3b6cb0a Removes convenience init since updateView is called by the framework and so does not need to be part of initialization 2019-12-12 10:39:21 -05:00
Robinson, Blake
3001f1df78 Remove self where it is not necessary for clarity 2019-12-12 10:00:59 -05:00
Robinson, Blake
b8e0fbff75 Removed line spaces 2019-12-12 09:33:03 -05:00
Robinson, Blake
5135835471 Removed UIColor prefix as per code review comments 2019-12-12 09:32:09 -05:00
Robinson, Blake
fb2cade157 Fixed spacing before colon as per code review comment 2019-12-12 09:30:00 -05:00
Robinson, Blake
16cc667b02 Expands tappable area of Link 2019-12-09 14:15:55 -05:00
Robinson, Blake
1d647ec662 Code standard change. Removed legacy-like methods. 2019-12-03 15:21:45 -05:00
Robinson, Blake
988e30daa9 Creates Link atom to replace MFTextButton 2019-12-02 11:15:50 -05:00
Pfeil, Scott Robert
88e079e6be Merge branch 'bugfix/header_line' into 'develop'
line fix in header

See merge request BPHV_MIPS/mvm_core_ui!185
2019-11-25 12:07:06 -05:00
Pfeil, Scott Robert
664d3195bb line fix in header 2019-11-25 09:20:05 -05:00
Suresh, Kamlesh Jain
8be65d4f57 Merge branch 'bugfix/bad_project_import' into 'develop'
Remote Scott's missing test controller.

See merge request BPHV_MIPS/mvm_core_ui!184
2019-11-20 17:30:52 -05:00
Hedden, Kyle Matthew
3944e02863 Remote Scott's missing test controller. 2019-11-20 17:30:52 -05:00
Pfeil, Scott Robert
7429fede9a Merge branch 'feature/modernize' into 'develop'
Feature/modernize

See merge request BPHV_MIPS/mvm_core_ui!182
2019-11-20 14:10:35 -05:00
Pfeil, Scott Robert
095b1d7a86 Merge branch 'feature/modernize' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize 2019-11-20 13:29:41 -05:00
Pfeil, Scott Robert
e32b9cfdda PR comments 2019-11-20 13:29:16 -05:00
Pfeil, Scott Robert
947af9b3c7 why? 2019-11-20 11:08:30 -05:00
Pfeil, Scott Robert
654be26b2c remove test file 2019-11-20 11:06:47 -05:00
Pfeil, Scott Robert
279dbd9b08 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize 2019-11-20 10:59:35 -05:00
Pfeil, Scott Robert
c96f5050a8 Line to swift 2019-11-20 10:20:24 -05:00
Hedden, Kyle Matthew
a714100b73 Merge branch 'release/7_1_0' into 'develop'
Release/7 1 0

See merge request BPHV_MIPS/mvm_core_ui!179
2019-11-19 17:02:45 -05:00
Pfeil, Scott Robert
f9619b8cb4 Merge branch 'bugfix/checkbox' into 'develop'
make checkbox expandable

See merge request BPHV_MIPS/mvm_core_ui!178
2019-11-19 12:59:52 -05:00
panxi
a409b331c5 revert 2019-11-19 12:56:07 -05:00
panxi
3851ad036a change to equal 2019-11-19 12:53:48 -05:00
panxi
3cb075499e make checkbox expandable 2019-11-19 10:39:30 -05:00
Pfeil, Scott Robert
82f94cde25 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize 2019-11-19 09:18:45 -05:00
Pfeil, Scott Robert
d29e8ea3bd small changes 2019-11-19 09:18:15 -05:00
Pan, Xinlei (Ryan)
6e17e36d64 Merge branch 'feature/topacc' into 'release/7_1_0'
add top accessory view

See merge request BPHV_MIPS/mvm_core_ui!176
2019-11-15 17:15:56 -05:00
Pan, Xinlei (Ryan)
9f8681f12f Merge branch 'revert-0ed49c65' into 'develop'
Revert "Merge branch 'feature/top_accessory' into 'develop'"

See merge request BPHV_MIPS/mvm_core_ui!177
2019-11-15 16:54:13 -05:00
Suresh, Kamlesh Jain
8376e5c79e Revert "Merge branch 'feature/top_accessory' into 'develop'"
This reverts merge request !175
2019-11-15 16:53:18 -05:00
Suresh, Kamlesh
a865664cff add top accessory view 2019-11-15 16:52:13 -05:00
Suresh, Kamlesh Jain
0ed49c65e1 Merge branch 'feature/top_accessory' into 'develop'
top accessory view

See merge request BPHV_MIPS/mvm_core_ui!175
2019-11-15 14:36:08 -05:00
Suresh, Kamlesh
89cbfe00ba clean up 2019-11-15 12:09:20 -05:00
Suresh, Kamlesh
cd5f66875d Merge branch 'feature/top_accessory' of gitlab.verizon.com:BPHV_MIPS/mvm_core_ui into feature/top_accessory 2019-11-15 11:42:34 -05:00
Suresh, Kamlesh
84f50f3b80 optimize 2019-11-15 11:42:29 -05:00
Murugan, Vimal
76cd37d121 code cleanup 2019-11-15 21:10:37 +05:30
Suresh, Kamlesh
627114ded8 top accessory in tableview controller 2019-11-14 19:27:56 -05:00
Suresh, Kamlesh
f1b8a61e04 top accessory view 2019-11-14 18:15:22 -05:00
Pfeil, Scott Robert
716dcff566 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize 2019-11-12 14:45:48 -05:00
Pfeil, Scott Robert
835eb3a43b Merge branch 'feature/twobuttonview_secondary_button_fix' into 'develop'
Adding support for displaying only secondaryButton on server dynamic response

See merge request BPHV_MIPS/mvm_core_ui!172
2019-11-11 15:51:33 -05:00
Pfeil, Scott Robert
f9cecb9a5d small code updates 2019-11-11 15:24:10 -05:00
Khan, Arshad
11e549bc50 Feedback implementation impact changes. 2019-11-11 22:47:49 +05:30
Khan, Arshad
f6c2935115 Implemented Scott feedback. 2019-11-11 22:41:24 +05:30