mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,317 Commits 64 Branches 0 Tags 46 MiB
a81ff55e6e
Commit Graph

4536 Commits

Author SHA1 Message Date
Matt Bruce
a81ff55e6e updated to not return hardcoded value 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 15:25:34 -06:00
Matt Bruce
85b1bbc501 Merge branch 'feature/atomic_vds_loader' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_loader 2024-01-18 14:48:06 -06:00
Matt Bruce
d5a9710b6c added other initiliazers 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-18 14:47:13 -06:00
Matt Bruce
eb8ea989ec refactored back in the obj-c interface to interact with swift extension 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-03 15:13:39 -06:00
Matt Bruce
c03e04069a refactored loader 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-03 14:04:30 -06:00
Matt Bruce
6a8e45fc9e initial cut for VDS Loader 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-06 14:39:46 -06:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'" 
This reverts merge request !1010
 2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
4687d7d344 self cleanups 2023-11-15 17:30:18 -05:00
Hedden, Kyle Matthew
61916e7c38 Move hightlightTab to @MainActor to prevent block crash. 2023-11-15 17:14:51 -05:00
Pfeil, Scott Robert
85e967c492 Merge branch 'bugfix/PRODDEF-1289_accessibilityChanges' into 'develop' 
Added static test for carousel.

### Summary
Added static test for carousel.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1289

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/972
 2023-11-02 20:36:41 +00:00
Pfeil, Scott Robert
c1cb411491 Merge branch 'feature/searchResultAnnouncement' into 'develop' 
Updated accessibilityText in ListItemModel for searchResults announcement

### Summary
Updated accessibilityText in ListItemModel for searchResults announcement.

Dependent PR's : 
https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2172

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1022
 2023-11-02 20:35:41 +00:00
Keerthy
8e4ad2c41e Updated accessibilityText in ListItemModel for searchResults announcement 2023-11-03 00:11:16 +05:30
Krishna Kishore Bandaru
a3c4c2248c removed unused code & added hidden check 2023-11-02 23:06:05 +05:30
Krishna Kishore Bandaru
9c43649cce added review comments 2023-11-02 21:40:01 +05:30
Keerthy
df2fa3405b Updated delegateObject and delegate properties 
removed weak ref for delegateObject. updated delegate as delegate.loadDelegate
 2023-11-02 18:46:27 +05:30
Keerthy
d5f5072560 Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:50 +05:30
Keerthy
9d80f2027e Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:03 +05:30
Bruce, Matt R
c202a93acf Merge branch 'bugfix/CXTDT-446531' into 'develop' 
Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, checkBoxLabel

### Summary
1. Textfield : VO should reads as label, textField.
2. Picker : VO should read as label, current selection , has popup/ picker item.
3. CheckBox Label : Both checkbox and label should have single focus, VO should read as checkbox role, status and label.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-446531

This PR is having dependency with https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2263. Unable to add dependency in this PR.

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1020
 2023-11-01 21:11:27 +00:00
Bruce, Matt R
747db3290e Merge branch 'bugfix/accessibilityFocusFixForListLVImgAllCell' into 'develop' 
Updated linkShowing logic for accessibility

### Summary
In VDS Link component, we have default text assigned to Link(ButtonBase) as "No Text". Because of that default text, `eyebrowHeadlineBodyLink.link.titleLabel?.text?.count ?? 0 > 0` condition is getting true even though we don't have link in the model/UI.

Updated condition based on model text.

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1018
 2023-11-01 20:57:50 +00:00
Pfeil, Scott Robert
7267516b72 Merge branch 'bugfix/focusStuckIssue' into 'develop' 
Commented logic for focus skip issue

### Summary
We are seeing issue where the focus is getting skipped with voiceOver when going in backward direction. Due to limited JSON's in postpay, we have validated with prepay JSON's and identified below list of JSON's where we are seeing the issue. 

Below are the list of JSON's we have verified.

https://oneconfluence.verizon.com/display/MFP/PREGRO-5742+-++What%27s+changing+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-5735+-+Select+a+plan+screen+-+Overview
https://oneconfluence.verizon.com/display/MFP/PREGRO-5741+-+Review+new+plan+screen
https://oneconfluence.verizon.com/pages/viewpage.action?pageId=950516937
https://oneconfluence.verizon.com/display/MFP/PREGRO-5754+-+Review+details+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-6033+-+Update+-+Monthly+Costs+screen

When commented the logic related to accessibilityElements we are not facing any issue either in forward or backward direction.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-436601 (issue 3)

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/985
 2023-11-01 20:49:58 +00:00
Keerthy
5920bf3e50 Order change 2023-11-02 00:52:13 +05:30
Keerthy
84314aa5ed Merge branch 'develop' into bugfix/CXTDT-446531 2023-11-02 00:01:58 +05:30
Keerthy
9fe6a4dfc1 Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, CheckboxLabel 2023-11-01 23:59:34 +05:30
Keerthy
5d7dab8879 Removed checkbox from rotor 2023-11-01 22:51:04 +05:30
Hedden, Kyle Matthew
d61103ee6e Merge branch 'feature/LoadingOverlay-Text' into 'develop' 
Option to show text in the loading overlay screen

### Summary
Adding option to show text on loading overlay screen.

### JIRA Ticket
[ONEAPP-5807](https://onejira.verizon.com/browse/ONEAPP-5807)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1009
 2023-11-01 17:01:56 +00:00
Scott Pfeil
848defaf39 32 -> 16 horizontal margin 2023-11-01 12:33:03 -04:00
Krishna Kishore Bandaru
975882d47c addressed code review comments 2023-11-01 18:11:22 +05:30
Krishna Kishore Bandaru
34dcc80f67 Updated linkShowing logic for accessibility 2023-11-01 14:09:55 +05:30
Keerthy
96fa0bf314 Removed accessibilityElements to resolve focus stuck issue 2023-11-01 13:47:23 +05:30
Keerthy
fe40639a19 Merge branch 'develop' into bugfix/focusStuckIssue 2023-11-01 13:46:09 +05:30
Keerthy
733a0a1b94 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-11-01 11:33:29 +05:30
Keerthy
7b4dd51a74 Merge branch 'develop' into feature/accessibilityHandler 2023-11-01 11:32:50 +05:30
Keerthy
92b7c3ef36 foucs spelling mistake 2023-11-01 11:19:30 +05:30
Keerthy
24c684d64f Updated accessibilityBehavior 2023-11-01 00:06:41 +05:30
Sumanth Nadigadda
9be7fef53c Showing/Hiding the text while starting/pausing the loading overlay 2023-10-31 22:51:39 +05:30
Rajendran, Nandhini
4b9c386071 story: ONEAPP-5868 page control update 2023-10-31 15:30:39 +00:00
Sumanth Nadigadda
d057559353 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/LoadingOverlay-Text 2023-10-31 19:47:30 +05:30
Krishna Kishore Bandaru
3900294189 Merge branch 'develop' into feature/accessibilityHandler 2023-10-31 11:47:49 +05:30
Scott Pfeil
17a16bf73c change encode 2023-10-30 12:47:53 -04:00
Scott Pfeil
49d6d2bf76 bugfix for old color properties 2023-10-30 12:45:12 -04:00
Keerthy
6ad71383f4 Merge branch 'feature/accessibilityHandler' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/accessibilityHandler 2023-10-30 13:55:24 +05:30
Keerthy
e48db9495d Minor refactoring 2023-10-30 13:54:48 +05:30
Krishna Kishore Bandaru
92b7055096 Merge branch 'develop' into feature/accessibilityHandler 2023-10-27 18:51:30 +05:30
Hedden, Kyle Matthew
1eb0103744 fix stack overflow error on RawRepresentable encoding 2023-10-26 16:39:30 -04:00
Keerthy
8f002f9422 Merge branch 'develop' into feature/accessibilityHandler 2023-10-26 23:48:37 +05:30
Keerthy
0f2f00f6d4 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-10-26 23:34:26 +05:30
Bruce, Matt R
58afcc596d Merge branch 'feature/ListStoreLocatorMoleculeEnhancement' into 'develop' 
ListStoreLocator component enhancement

### Summary
We have got confirmation from businesses to use the existing listStoreLocator molecule instead of having a new one created.
Updated heart with badge as per the new design.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-5098

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1012
 2023-10-26 16:42:53 +00:00
Pfeil, Scott Robert
025667f856 Merge branch 'feature/atomic_vds_badge' into 'develop' 
Introduced the VDS Badge into Atomic

Co-authored-by: Bruce, Matt R <matt.bruce@one.verizon.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>
Co-authored-by: Rebecca Antonelli <rebecca.antonelli@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1013
 2023-10-26 16:39:52 +00:00
Keerthy
8ca636aa23 Merge branch 'develop' into feature/accessibilityHandler 2023-10-26 22:07:58 +05:30
Bruce, Matt R
0c4136a6b1 removed comment 2023-10-26 15:08:24 +00:00