mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,347 Commits 64 Branches 0 Tags 46 MiB
75729fd414
Commit Graph

5347 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sumanth Nadigadda
75729fd414 defect: CXTDT-458975 Removing button text in the accessibility label. 2024-01-24 23:33:57 +05:30
Pfeil, Scott Robert
2a847602a2 Merge branch 'bugfix/PRODDEF-19592' into 'develop' 
Updated textView to have label text for accessibility behavior

### Summary
Updated textView to have label text for accessibility behavior

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-19592

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1029
 2024-01-24 16:46:04 +00:00
Pfeil, Scott Robert
54519d9820 Merge branch 'feature/dynamicAccessibilityTraits' into 'develop' 
Added accessibilityTraits dynamically for buttons, List components

### Summary
Driven all the buttons and list components traits dynamically. As per the WCAG Accessibility guidelines,

Button role - is used to trigger an action e,g confirm information, submit data, continue multi step task.  (Button page #45) 

Link role - Links should be used only for actions that take the user to other locations and, should not be used for button-like functionality.(Text Link page# 46).

Google drive link : ([https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!\[Links__2\_\](/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2\_.png](https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!%5BLinks__2_%5D(/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2_.png))

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-421918

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>
Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/996
 2024-01-24 16:33:47 +00:00
Keerthy
648bfdc76b Missed file 2024-01-24 21:41:46 +05:30
Keerthy
d1ee6e7f3a Addressed code review comments 2024-01-24 16:18:35 +05:30
Keerthy
459d3e4a33 Merge branch 'develop' into bugfix/PRODDEF-19592 2024-01-24 16:00:45 +05:30
Keerthy
eb5d359322 Addressed review comments 
Added accessibilityHint to AccessibilityModelProtocol
 2024-01-22 23:29:47 +05:30
Hedden, Kyle Matthew
950f63e87b Merge branch 'feature/ONEAPP-6340' into 'develop' 
ONEAPP-6435

### Summary
Open the progress bar molecule model for extension.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6435

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1040
 2024-01-12 15:20:05 +00:00
Hedden, Kyle Matthew
8a62065ade open encoder 2024-01-11 18:17:06 -05:00
Keerthy
3d7e1ac646 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2024-01-09 12:39:45 +05:30
Hedden, Kyle Matthew
5bbb4122ec Merge branch 'bugfix/carousel_indexing' into 'develop' 
indexing safety

### Summary
Prevent crash when no molecules are present for the carousel.

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1041
 2024-01-03 22:07:51 +00:00
Hedden, Kyle Matthew
c2c4e0f1f4 indexing safety 2024-01-02 17:25:43 -05:00
Hedden, Kyle Matthew
8306f901bd Open up progress bar atom for subclassing. 2023-12-21 22:19:45 -05:00
Pfeil, Scott Robert
beec8fd8d3 Merge branch 'bugfix/logging_handler_fixes' into 'develop' 
Remove unused stub.

### Summary
Remove unused logging handler stub which creates the wrong subclassing impression.

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1039
 2023-12-21 19:33:45 +00:00
Hedden, Kyle Matthew
72358966bc Remove unused stub. 2023-12-21 12:32:08 -05:00
Hedden, Kyle Matthew
dc622b2f80 Merge branch 'feature/oneApp_4156-LoggingHandlerSwiftMigration' into 'develop' 
story: ONEAPP-4156 LoggingHandler Swift migration

### Summary
Swiftify logging handler

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4156

Co-authored-by: Nandhini Rajendran <nandhini.rajendran@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1015
 2023-12-21 16:28:22 +00:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Pfeil, Scott Robert
0066827c5d Merge branch 'feature/ONEAPP-6089' into 'develop' 
Text field Spanish localization for optional

### Summary
Update privacy strings for App Clip Spanish support.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6089

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1037
 2023-12-14 23:10:32 +00:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop' 
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
 2023-12-05 14:42:29 +00:00
Hedden, Kyle Matthew
aba99b887b Merge branch 'revert-9c75add4' into 'develop' 
Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'"

### Summary
Reverting changes done for scrubber update as the requirement is no longer valid.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5868

Co-authored-by: Rajendran, Nandhini <nandhini.rajendran@one.verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1034
 2023-12-04 15:29:33 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'" 
This reverts merge request !1010
 2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
e48867446c Merge branch 'bugfix/tabbar_index_crash_fix' into 'release/11_1_4' 
Bugfix/tabbar index crash fix

### Summary
Top crash prevention when the web bridge gives an invalid tab index.

### Crash Signature
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/d55575695f799d0b41da74b063331db6?time=last-seven-days&types=crash&sessionEventKey=85086f6b016242f0b3ef04b40d6e46a6_1886152816176443688

```
Crashed: com.apple.main-thread
0  MVMCoreUI                      0x38ed04 TabBar.highlightTab(at:) + 90 (TabBar.swift:90)
1  MVMCoreUI                      0x38ed34 @objc TabBar.highlightTab(at:) + 7800 (<compiler-generated>:7800)
2  MobileFirstFramework           0x48fb94 MVMCoreViewControllerProtocol<>.update(_:) + 57 (WebviewBridgeWebPageLoaded.swift:57)
3  MobileFirstFramework           0x954288 (1) suspend resume partial function for closure #1 in WebViewBridgeUpdateTabBar.performBridgeAction(with:viewController:completionHandler:) + 20 (WebViewBridgeUpdateTabBar.swift:20)
```

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1033
 2023-12-01 19:35:36 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Pfeil, Scott Robert
547c3ad2a4 Merge branch 'bugfix/CXTDT-459511' into 'release/11_1_4' 
Setting accessibility label if available before text for eyebrow, headline,...

### Summary
Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label

### JIRA Ticket
[CXTDT-459511](https://onejira.verizon.com/browse/CXTDT-459511)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>
Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1031
 2023-12-01 16:13:26 +00:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30
Hedden, Kyle Matthew
3e5d4fe71f Merge branch 'release/11_1_2' into 'develop' 
release/11_1_2 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1028
 2023-11-27 15:10:51 +00:00
Keerthy
d65df06934 Updated textView to have label text for accessibility behavior 2023-11-22 18:07:13 +05:30
Pfeil, Scott Robert
440380f4d3 Merge branch 'hotfix/tabbar_block_crash' into 'release/11_1_1' 
Move hightlightTab to @MainActor to prevent block crash.

### Summary
Prevent block crash on highlight tab.

### Crash Details
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/18516b87c36a9806e850dcac71748655?time=last-seven-days&types=crash&versions=11.1.0%20(20909.0)&sessionEventKey=bdace1e1ffa74d9b84e2afb63a98eaaf_1880252739825018670
```
0  MVMCoreUI                      0x38ad1c closure #1 in TabBar.highlightTab(at:) + 7776
1  MVMCoreUI                      0x312e8 thunk for @escaping @callee_guaranteed () -> () + 4140 (<compiler-generated>:4140)
2  MVMCore                        0xdc54 +[MVMCoreDispatchUtility performBlockOnMainThread:] + 15 (MVMCoreDispatchUtility.m:15)
3  MVMCoreUI                      0x38afe4 @objc TabBar.highlightTab(at:) + 8488
4  MobileFirstFramework           0x48f99c MVMCoreViewControllerProtocol.update(_:) + 56 (WebviewBridgeWebPageLoaded.swift:56)
```

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1026
 2023-11-15 22:33:13 +00:00
Hedden, Kyle Matthew
4687d7d344 self cleanups 2023-11-15 17:30:18 -05:00
Hedden, Kyle Matthew
61916e7c38 Move hightlightTab to @MainActor to prevent block crash. 2023-11-15 17:14:51 -05:00
Pfeil, Scott Robert
85e967c492 Merge branch 'bugfix/PRODDEF-1289_accessibilityChanges' into 'develop' 
Added static test for carousel.

### Summary
Added static test for carousel.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1289

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/972
 2023-11-02 20:36:41 +00:00
Pfeil, Scott Robert
c1cb411491 Merge branch 'feature/searchResultAnnouncement' into 'develop' 
Updated accessibilityText in ListItemModel for searchResults announcement

### Summary
Updated accessibilityText in ListItemModel for searchResults announcement.

Dependent PR's : 
https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2172

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1022
 2023-11-02 20:35:41 +00:00
Pfeil, Scott Robert
13fb8241df Merge branch 'feature/accessibilityHandler' into 'develop' 
Draft : Accessibility Handler class

### Summary
Implemented accessibility handler class, changes for toggle to retain the focus on to the same toggle even after api call.

OneConfl link for toggle(accessibility focus should retain back to the same toggle) : https://oneconfluence.verizon.com/display/MFD/Accessibility+-+Focus+Retain+on+Molecular+Pages

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>
Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
 2023-11-02 20:34:47 +00:00
Keerthy
8e4ad2c41e Updated accessibilityText in ListItemModel for searchResults announcement 2023-11-03 00:11:16 +05:30
Krishna Kishore Bandaru
a3c4c2248c removed unused code & added hidden check 2023-11-02 23:06:05 +05:30
Krishna Kishore Bandaru
9c43649cce added review comments 2023-11-02 21:40:01 +05:30
Keerthy
df2fa3405b Updated delegateObject and delegate properties 
removed weak ref for delegateObject. updated delegate as delegate.loadDelegate
 2023-11-02 18:46:27 +05:30
Keerthy
d5f5072560 Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:50 +05:30
Keerthy
9d80f2027e Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:03 +05:30
Bruce, Matt R
c202a93acf Merge branch 'bugfix/CXTDT-446531' into 'develop' 
Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, checkBoxLabel

### Summary
1. Textfield : VO should reads as label, textField.
2. Picker : VO should read as label, current selection , has popup/ picker item.
3. CheckBox Label : Both checkbox and label should have single focus, VO should read as checkbox role, status and label.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-446531

This PR is having dependency with https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2263. Unable to add dependency in this PR.

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1020
 2023-11-01 21:11:27 +00:00
Bruce, Matt R
747db3290e Merge branch 'bugfix/accessibilityFocusFixForListLVImgAllCell' into 'develop' 
Updated linkShowing logic for accessibility

### Summary
In VDS Link component, we have default text assigned to Link(ButtonBase) as "No Text". Because of that default text, `eyebrowHeadlineBodyLink.link.titleLabel?.text?.count ?? 0 > 0` condition is getting true even though we don't have link in the model/UI.

Updated condition based on model text.

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1018
 2023-11-01 20:57:50 +00:00
Pfeil, Scott Robert
7267516b72 Merge branch 'bugfix/focusStuckIssue' into 'develop' 
Commented logic for focus skip issue

### Summary
We are seeing issue where the focus is getting skipped with voiceOver when going in backward direction. Due to limited JSON's in postpay, we have validated with prepay JSON's and identified below list of JSON's where we are seeing the issue. 

Below are the list of JSON's we have verified.

https://oneconfluence.verizon.com/display/MFP/PREGRO-5742+-++What%27s+changing+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-5735+-+Select+a+plan+screen+-+Overview
https://oneconfluence.verizon.com/display/MFP/PREGRO-5741+-+Review+new+plan+screen
https://oneconfluence.verizon.com/pages/viewpage.action?pageId=950516937
https://oneconfluence.verizon.com/display/MFP/PREGRO-5754+-+Review+details+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-6033+-+Update+-+Monthly+Costs+screen

When commented the logic related to accessibilityElements we are not facing any issue either in forward or backward direction.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-436601 (issue 3)

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/985
 2023-11-01 20:49:58 +00:00
Keerthy
5920bf3e50 Order change 2023-11-02 00:52:13 +05:30
Keerthy
84314aa5ed Merge branch 'develop' into bugfix/CXTDT-446531 2023-11-02 00:01:58 +05:30
Keerthy
9fe6a4dfc1 Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, CheckboxLabel 2023-11-01 23:59:34 +05:30
Keerthy
5d7dab8879 Removed checkbox from rotor 2023-11-01 22:51:04 +05:30
Hedden, Kyle Matthew
d61103ee6e Merge branch 'feature/LoadingOverlay-Text' into 'develop' 
Option to show text in the loading overlay screen

### Summary
Adding option to show text on loading overlay screen.

### JIRA Ticket
[ONEAPP-5807](https://onejira.verizon.com/browse/ONEAPP-5807)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1009
 2023-11-01 17:01:56 +00:00