Commit Graph

5987 Commits

Author SHA1 Message Date
Bruce, Matt R
6c841c078a Merge branch 'release/20_1_1' into 'develop'
Digital PCT265 defect: VDS TabsTableViewCell delegate reset issue. Impacts UAD...

Co-authored-by: Subramaniam, Ramya <ramya.subramaniam@one.verizon.com>
Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1177
2024-08-21 13:17:32 +00:00
Pfeil, Scott Robert
ffd5242cde Merge branch 'bugfix/atomic-buttonGroup' into 'develop'
Fix for the reset() issue with default properties being reset for buttonGroup

### Summary
There were buttongroup properties added in the setup() method, however they were getting removed in reset(). 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-602228

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1175
2024-08-15 17:32:31 +00:00
Matt Bruce
e89272a3cd comments on the order of operations in reset()
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-15 12:31:50 -05:00
Matt Bruce
33dc411743 Fix for the reset() issue with default properties being reset for buttonGroup
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-15 11:08:25 -05:00
Pfeil, Scott Robert
558a3d7c55 Merge branch 'feature/negate_gone' into 'develop'
Digital PCT265 story VZWYZDG-1866 - Added action for negating the gone property on molecules.

### Summary
Action for negating the gone property on goneable molecules.
https://oneconfluence.verizon.com/x/AZT2UQ

### JIRA Ticket
https://onejira.verizon.com/browse/VZWYZDG-1866

![SuccessfulTest](/uploads/ac54fd745447ef52497843af641f24e4/SuccessfulTest.mp4)

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1166
2024-08-14 18:56:12 +00:00
Scott Pfeil
17a94e2f04 Digital PCT265 story VZWYZDG-1866 - Ensure the footer stays at the bottom. 2024-08-14 12:32:50 -04:00
Scott Pfeil
4921d7d8db Digital PCT265 story VZWYZDG-1866 - Updating format per code review. 2024-08-14 11:33:40 -04:00
Subramaniam, Ramya
8c5a8776ab Merge branch 'bugfix/tabstableviewcell' into 'release/20_1_1'
Digital PCT265 defect: VDS TabsTableViewCell delegate reset issue. Impacts UAD.

### Summary
This issue is due to a change in the VDS tabs reset handling. The onTabSelect and onTabShouldSelect gets reset to nil. In the case of table cell reuse this reset gets called and our setup connection in the initializer is lost. Adding the delegate back in the model setter seems to resolve this immediate issue but we should expand out and see if there are other cases.

### JIRA Ticket
[CXTDT-601399](https://onejira.verizon.com/browse/CXTDT-601399)

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1174
2024-08-14 05:34:05 +00:00
Hedden, Kyle Matthew
3867384307 Digital PCT265 defect: VDS TabsTableViewCell delegate reset issue. Impacts UAD account tab switcher. 2024-08-13 23:25:18 -04:00
Pfeil, Scott Robert
efccb312e8 Merge branch 'release/20_1_0' into 'develop'
ensure viewModel?. is used outside of the viewModelDidUpdate method

### Summary
Hotfix

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1173
2024-08-13 20:43:30 +00:00
Hedden, Kyle Matthew
f437fbaea9 Merge branch 'hotfix/20_1-vds-update' into 'release/20_1_0'
ensure viewModel?. is used outside of the viewModelDidUpdate method

### Summary
Crash from not using optional ? for the viewModels.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1172
2024-08-12 14:47:10 +00:00
Matt Bruce
441525a610 ensure formModel exists
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-12 09:28:40 -05:00
Matt Bruce
07351c1a22 ensure viewModel?. is used outside of the viewModelDidUpdate method
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-12 09:28:31 -05:00
Hedden, Kyle Matthew
236a1969e9 Merge branch 'bugfix/vds-update' into 'develop'
Merge of release/20_1 and bugfix

### Summary
VDS Bugfix for new Generics plus all of the release/20_1 code that hasn't been merged down into develop.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>
Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1170
2024-08-12 13:21:53 +00:00
Matt Bruce
f96b750302 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into test 2024-08-10 11:31:02 -05:00
Matt Bruce
715a911ee4 fixed issue with vds refactor 2024-08-10 11:30:47 -05:00
Hedden, Kyle Matthew
696b6b99d0 Merge branch 'hotfix/checkbox-showError' into 'release/20_1_0'
CXTDT-599891 - taking out showError for now

### Summary
Checkboxes have never had an error state, so until we figure out the default state, we need to turn it off. 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-599891

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1169
2024-08-09 22:52:31 +00:00
Matt Bruce
b41d2189bf taking out showError for now
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-09 17:48:05 -05:00
Matt Bruce
8c1577bb7f Merge branch 'release/20_1_0' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into release/20_1_0 2024-08-09 09:17:13 -05:00
Pfeil, Scott Robert
21d1e957d0 Merge branch 'bugfix/proddef_26055_2' into 'release/20_1_0'
bugfix PRODDEF-26055 Issue #2

### Summary
added missing view to getAcessibilityElements func

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-26055

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>
Co-authored-by: Arun Kumar Chintakrinda <arun.kumar.chintakrinda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1168
2024-08-08 20:56:49 +00:00
Hedden, Kyle Matthew
c34a5c7661 Merge branch 'hotfix/radioButton' into 'release/20_1_0'
CXTDT-598142 - RadioButton fix

### Summary
Updated VDS RadioButton had more atomic setting than required. 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-598142

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1167
2024-08-08 20:45:16 +00:00
Matt Bruce
d308bfc957 CXTDT-598142 - RadioButton fix
QA3||MVA||Prepay||IOS - 22053||Devices||From Add device screen

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-08 15:38:53 -05:00
Matt Bruce
92b28d767b Merge branch 'release/20_1_0' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into release/20_1_0 2024-08-08 14:32:35 -05:00
Scott Pfeil
a691f8d713 Digital PCT265 story VZWYZDG-1866 - Update name to proper jargon. 2024-08-08 14:14:03 -04:00
Scott Pfeil
f412fd70e1 Digital PCT265 story VZWYZDG-1866 - Added action for negating the gone property on molecules. 2024-08-08 14:02:21 -04:00
Pfeil, Scott Robert
50b0280ba4 Merge branch 'feature/MVAPCT-213' into 'develop'
Digital PCT265 story MVAPCT-213 - Allow for panels to override the supported...

### Summary
Allow for panels to override the supported orientation. Force chatbot panel to be full screen width on non tablet devices.

### JIRA Ticket
https://onejira.verizon.com/browse/MVAPCT-213

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1165
2024-08-06 15:06:09 +00:00
Scott Pfeil
dfbb53f545 Digital PCT265 story MVAPCT-213 - Function name update 2024-08-06 10:31:18 -04:00
Scott Pfeil
1d2defeabb Digital PCT265 story MVAPCT-213 - Add Helper to update the orientation. 2024-08-06 09:53:59 -04:00
Hedden, Kyle Matthew
3d6d7c0cad Merge branch 'bugfix/proddef_26055_2' into 'develop'
bugfix PRODDEF-26055 Issue #2

### Summary
added missing view to getAcessibilityElements func

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-26055

Co-authored-by: Arun Kumar Chintakrinda <arun.kumar.chintakrinda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1164
2024-08-06 13:38:57 +00:00
Arun Kumar Chintakrinda
2ce1b671bd added comment 2024-08-06 17:18:56 +05:30
Scott Pfeil
e13e8ca5ab Digital PCT265 story MVAPCT-213 - Allow for panels to override the supported orientation. Force chatbot panel to be full screen width on non tablet devices. 2024-08-05 13:59:59 -04:00
Arun Kumar Chintakrinda
100ede48fa added condition to check if view is available 2024-08-05 20:32:09 +05:30
Arun Kumar Chintakrinda
0d6fc3d15d bugfix PRODDEF-26055 Issue #2, added missing view to getAcessibilityElements func 2024-08-05 20:25:24 +05:30
Hedden, Kyle Matthew
5eca67fe0f Merge branch 'hotfix/checkbox-isSelected' into 'release/20_1_0'
HotFix Checkbox/CheckboxLabel

### Summary
reverted to old code so that if isSelected is set manually, the form will validate.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1163
2024-08-02 19:49:04 +00:00
Matt Bruce
1a48113b0d Merge branch 'hotfix/checkbox-isSelected' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into release/20_1_0 2024-08-02 13:14:35 -05:00
Matt Bruce
37c6dfd6b3 optional viewModel
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-02 13:13:57 -05:00
Matt Bruce
0938328ea2 Merge branch 'hotfix/checkbox-isSelected' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into release/20_1_0 2024-08-02 12:42:10 -05:00
Matt Bruce
5a3f04aa5f use super instead of var
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-02 08:53:15 -05:00
Matt Bruce
5e116e3c91 reverted code in case the isSelected is set directly
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-01 17:14:04 -05:00
Hedden, Kyle Matthew
941312dd08 Merge branch 'bugfix/dropDownSelect' into 'release/20_1_0'
DropDownSelect update

### Summary
fixed issue with EstimatedHeight and delegate callback.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-7135

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1162
2024-08-01 20:35:04 +00:00
Matt Bruce
c2cb8781d6 ensured all vds components have the estimated height implementation
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-01 15:18:33 -05:00
Matt Bruce
ab5a5a1e55 added placeholder in delegates so you can understand what is passed back
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-01 10:55:48 -05:00
Matt Bruce
3732f98d7c added override property to deal with oldvalue/newValue for the selected Item.
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-08-01 10:53:14 -05:00
Pfeil, Scott Robert
d69722c431 Merge branch 'bugfix/atomic-vds-selectorUpdate' into 'develop'
Updated Merged Selectors

### Summary
updated selectors for similar logic in valuechanged event 

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-7001

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1159
2024-07-31 00:52:13 +00:00
Matt Bruce
9606b914cc removed code
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-07-30 17:02:17 -05:00
Matt Bruce
57bec1ecec moved formvalidation to publisher
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-07-30 17:02:09 -05:00
Matt Bruce
998ad97372 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic-vds-checkbox 2024-07-30 16:39:59 -05:00
Matt Bruce
d199389ff3 ensured isEnabled
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-07-30 16:38:30 -05:00
Pfeil, Scott Robert
b24094ea5b Merge branch 'feature/atomic-vds-checkbox' into 'develop'
VDS Brand 3.0 Checkbox

### Summary
VDS Brand 3.0 Checkbox, CheckboxItem for IOS
- CheckboxGroup will be a later integration since this is not in the app at this time.
 
### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-7001

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1152
2024-07-30 21:36:51 +00:00
Matt Bruce
ac23b0dc41 refactored checkbox action to didSet
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-07-30 16:35:46 -05:00