Commit Graph

1093 Commits

Author SHA1 Message Date
Kevin G Christiano
5ce8446be2 Updating Link class. adding identifier to molecule mapping. 2020-01-13 13:31:25 -05:00
Kevin G Christiano
9882528b9e Merge branch 'develop' into feature/link
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
2020-01-13 12:50:08 -05:00
Pan, Xinlei (Ryan)
cdeddb3de4 Merge branch 'feature/further_accesibilty' into 'develop'
Accessibility fixes.

See merge request BPHV_MIPS/mvm_core_ui!218
2020-01-13 10:24:42 -05:00
Kevin G Christiano
85f210abe8 Accessibility fixes. 2020-01-13 08:49:51 -05:00
Pan, Xinlei (Ryan)
a2ef7e026f Merge branch 'feature/headline_body_caret_link_image_molecule' into 'develop'
Feature/headline body caret link image molecule

See merge request BPHV_MIPS/mvm_core_ui!212
2020-01-10 11:38:32 -05:00
panxi
c4112665d9 add bottom padding 2020-01-10 11:35:29 -05:00
Khan, Arshad
7a48633cce Implemented Ryan's feedback, as Prateek is out of office for next week. 2020-01-10 10:59:13 -05:00
Arora, Prateek
61d36b25a7 Code changes 2020-01-10 11:04:07 +05:30
Arora, Prateek
b037d23adb Code changes 2020-01-09 22:25:53 +05:30
Arora, Prateek
20f62ce4c5 Code clean 2020-01-09 20:10:39 +05:30
Arora, Prateek
b8a162da54 Code cleaning removing duplicate constraint 2020-01-09 20:10:17 +05:30
Arora, Prateek
7b49224abd Caret link bottom spacing 2020-01-09 18:19:52 +05:30
Arora, Prateek
03aeb1fc63 headline body width 85% having max as 350px 2020-01-09 16:35:56 +05:30
Arora, Prateek
67304b7657 Changes as suggested by Ryan 2020-01-09 13:26:09 +05:30
Suresh, Kamlesh Jain
f0c7fbcb9e Merge branch 'feature/textfield_list_update_drop_down' into 'develop'
Feature/textfield list update drop down

See merge request BPHV_MIPS/mvm_core_ui!211
2020-01-08 11:58:08 -05:00
Arora, Prateek
203484b288 Code clean 2020-01-08 18:49:36 +05:30
Arora, Prateek
0226eb2cac Review comments : added default padding 2020-01-08 18:46:02 +05:30
Arora, Prateek
4c60ea2f1f Review comment changes 2020-01-08 14:53:59 +05:30
Arora, Prateek
c908606b79 Review Comment Changes 2020-01-08 13:08:09 +05:30
Arora, Prateek
f32cc7d05c Code cleaning 2020-01-08 12:21:28 +05:30
Pfeil, Scott Robert
90f388ffa7 Merge branch 'feature/appleguidelinesprotocol' into 'develop'
Created Protocol to centralize tap detection logic.

See merge request BPHV_MIPS/mvm_core_ui!207
2020-01-07 15:56:12 -05:00
Arora, Prateek
d891d7ba1a Code cleaning 2020-01-07 19:29:26 +05:30
Arora, Prateek
129a0e9241 New molecule -> headLineBodyCaretLinkImage 2020-01-07 12:34:29 +05:30
Pan, Xinlei (Ryan)
96fd9174c3 Merge branch 'feature/short_tall_dividers' into 'develop'
MOBFIRST-19249 : List Item Style Updates

See merge request BPHV_MIPS/mvm_core_ui!209
2020-01-06 09:18:43 -05:00
Khan, Arshad
bf0b2ecb79 changed separator style to thin 2020-01-06 16:49:03 +05:30
Murugan, Vimal
f1f34b2893 textfield list view and textfield list form controller been moved to mobilefirstframework 2020-01-04 14:26:09 +05:30
Murugan, Vimal
709277362f updated constraints 2020-01-03 20:20:23 +05:30
Murugan, Vimal
dd49c43946 code cleanup 2020-01-03 20:18:30 +05:30
Khan, Arshad
c4fbf57890 MOBFIRST-19249 : List Item Style Updates
Adding shortDivider and tallDivider style.
Removing header style.
2020-01-03 19:52:10 +05:30
Murugan, Vimal
e5ca7b5c9e bullet list molecule added 2020-01-02 21:33:31 +05:30
Murugan, Vimal
ccc535360c protocol implementation 2019-12-27 13:02:13 +05:30
Murugan, Vimal
1d843ae29a main thread update
access modifier update
2019-12-26 19:33:37 +05:30
Kevin G Christiano
fbc6e83038 Created Protocol to centralize tap detection logic. 2019-12-20 13:27:22 -05:00
Pan, Xinlei (Ryan)
767ee787cb Merge branch 'feature/checkboxView_constraints' into 'develop'
Checkbox view constraints

See merge request BPHV_MIPS/mvm_core_ui!194
2019-12-19 15:26:03 -05:00
Robinson, Blake
e11f64f0a4 Changed to optionalStringForKey 2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375 Used guard instead of if let because some code after the if let was removed 2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9 Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton. 2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab Removes self where unnecessary 2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57 Changed to MVMCoreUIUtility.getWidth() as per pr comments 2019-12-19 12:23:01 -05:00
Kevin G Christiano
f56b08fa0c Merge branch 'develop' into feature/checkboxView_constraints
# Conflicts:
#	MVMCoreUI/Atoms/Views/CheckboxWithLabelView.swift
2019-12-19 11:21:44 -05:00
Kevin G Christiano
6c9fede0b9 improved reset. 2019-12-19 11:12:59 -05:00
Kevin G Christiano
9e5ccb01a7 removed unused func. 2019-12-19 11:09:18 -05:00
Pan, Xinlei (Ryan)
21da4f960d Merge branch 'feature/container' into 'develop'
Feature/container

See merge request BPHV_MIPS/mvm_core_ui!202
2019-12-19 11:05:58 -05:00
Pfeil, Scott Robert
dcd0268c5b fix 2019-12-19 10:14:57 -05:00
Pan, Xinlei (Ryan)
2a5219f5b6 Merge branch 'bugfix/progress_bar_double_issue' into 'develop'
progress bar percentage type fix from Float to Double

See merge request BPHV_MIPS/mvm_core_ui!203
2019-12-19 10:14:30 -05:00
Pan, Xinlei (Ryan)
1d3d97757c Merge branch 'feature/add_sectionFooter_style_in_listItem' into 'develop'
Adding new style sectionFooter for listItem molecule.

See merge request BPHV_MIPS/mvm_core_ui!204
2019-12-19 10:14:17 -05:00
Khan, Arshad
eec15fc65e added comment as per Scott feedback 2019-12-19 19:21:49 +05:30
Khan, Arshad
aff4b75368 Changing to CGFloat, instead of Double as per feedback provided by Ryan.
Root Cause: Swift was treating it as Double, instead of Float.
2019-12-18 22:28:22 +05:30
Khan, Arshad
09a9a6577d Adding new style sectionFooter for listItem molecule.
There are two places in MVA 3.0, where we need 24 pixel spacing on top, zero spacing on bottom and no separator.
2019-12-18 21:36:50 +05:30
Khan, Arshad
95c528b658 progress bar percentage is been treated as Double for two decimal places(Like 54.17) in iOS JSON object, due to that progress percentage is not shown, where as working on Android.
So, changing Float to Double.
2019-12-18 21:20:58 +05:30