mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,370 Commits 64 Branches 0 Tags 46 MiB
315a96470b
Commit Graph

5370 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matt Bruce
315a96470b added ParentMoleculeModelProtocol 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 13:16:07 -06:00
Matt Bruce
38907c7ac1 updating the model to set the TwoButtonModel to fillContainer if needed 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 12:59:25 -06:00
Matt Bruce
d81daf1df3 not resetting if the current count is correct 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 12:58:55 -06:00
Matt Bruce
1932fd7231 fixed bug for removing old references in array 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 12:58:23 -06:00
Matt Bruce
f99d4e3c4d added fillContainer: Bool to deal with updating if the buttonGroup fills or not 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 12:58:07 -06:00
Matt Bruce
cdc8b7310d added ParewntMoleculeModelProtocol 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-29 12:57:32 -06:00
Matt Bruce
fb459cfdd5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-26 09:17:19 -06:00
Pfeil, Scott Robert
c0d4db39ca Merge branch 'bugfix/GYNVB-1160' into 'develop' 
Bugfix/gynvb 1160

### Summary
Prod_iOS_Eagle_AR Tool overview screen - missing menu icon.

### JIRA Ticket
https://onejira.verizon.com/browse/GYNVB-1160

Co-authored-by: Rajesh Pullagalla <rajesh.pullagalla1@verizonwireless.com>
Co-authored-by: Sureshkumar Ramachandran <sureshkumar.ramachandran@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1036
 2024-01-25 20:59:05 +00:00
Rajesh Pullagalla
0506347bdb Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-25 10:53:52 -05:00
Pfeil, Scott Robert
62ea38c6d4 Merge branch 'bugfix/CXTDT-458975' into 'develop' 
defect: CXTDT-458975 Removing button text in the accessibility label.

### Summary
Remving 'button' text in the accessibility label key. Since the VO is announcing the text 'button' twice when focused, one from the label and another one from the trait.

Ex: 'Internet access, toggle button on, button, double tap to toggle.'. 

### JIRA Ticket
[CXTDT-458975](https://onejira.verizon.com/browse/CXTDT-458975)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1050
 2024-01-24 18:13:26 +00:00
Sumanth Nadigadda
75729fd414 defect: CXTDT-458975 Removing button text in the accessibility label. 2024-01-24 23:33:57 +05:30
Pfeil, Scott Robert
2a847602a2 Merge branch 'bugfix/PRODDEF-19592' into 'develop' 
Updated textView to have label text for accessibility behavior

### Summary
Updated textView to have label text for accessibility behavior

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-19592

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1029
 2024-01-24 16:46:04 +00:00
Pfeil, Scott Robert
54519d9820 Merge branch 'feature/dynamicAccessibilityTraits' into 'develop' 
Added accessibilityTraits dynamically for buttons, List components

### Summary
Driven all the buttons and list components traits dynamically. As per the WCAG Accessibility guidelines,

Button role - is used to trigger an action e,g confirm information, submit data, continue multi step task.  (Button page #45) 

Link role - Links should be used only for actions that take the user to other locations and, should not be used for button-like functionality.(Text Link page# 46).

Google drive link : ([https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!\[Links__2\_\](/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2\_.png](https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!%5BLinks__2_%5D(/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2_.png))

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-421918

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>
Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/996
 2024-01-24 16:33:47 +00:00
Keerthy
648bfdc76b Missed file 2024-01-24 21:41:46 +05:30
Keerthy
d1ee6e7f3a Addressed code review comments 2024-01-24 16:18:35 +05:30
Keerthy
459d3e4a33 Merge branch 'develop' into bugfix/PRODDEF-19592 2024-01-24 16:00:45 +05:30
Keerthy
eb5d359322 Addressed review comments 
Added accessibilityHint to AccessibilityModelProtocol
 2024-01-22 23:29:47 +05:30
Rajesh Pullagalla
db3e7c22eb Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-17 09:07:45 -05:00
Hedden, Kyle Matthew
950f63e87b Merge branch 'feature/ONEAPP-6340' into 'develop' 
ONEAPP-6435

### Summary
Open the progress bar molecule model for extension.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6435

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1040
 2024-01-12 15:20:05 +00:00
Hedden, Kyle Matthew
8a62065ade open encoder 2024-01-11 18:17:06 -05:00
Matt Bruce
1f74c88ce6 added enabled 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 12:07:42 -06:00
Matt Bruce
ea3ee2adda added comments 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:42:53 -06:00
Matt Bruce
8ba25bb661 registered ButtonGroup Atom 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:31:58 -06:00
Matt Bruce
71a10f1055 added buttonGroup 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:19:18 -06:00
Keerthy
3d7e1ac646 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2024-01-09 12:39:45 +05:30
Matt Bruce
62e9197b8f Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-05 15:23:17 -06:00
Hedden, Kyle Matthew
5bbb4122ec Merge branch 'bugfix/carousel_indexing' into 'develop' 
indexing safety

### Summary
Prevent crash when no molecules are present for the carousel.

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1041
 2024-01-03 22:07:51 +00:00
Hedden, Kyle Matthew
c2c4e0f1f4 indexing safety 2024-01-02 17:25:43 -05:00
Rajesh Pullagalla
d8dce51106 Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-02 10:23:26 -05:00
Hedden, Kyle Matthew
8306f901bd Open up progress bar atom for subclassing. 2023-12-21 22:19:45 -05:00
Pfeil, Scott Robert
beec8fd8d3 Merge branch 'bugfix/logging_handler_fixes' into 'develop' 
Remove unused stub.

### Summary
Remove unused logging handler stub which creates the wrong subclassing impression.

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1039
 2023-12-21 19:33:45 +00:00
Hedden, Kyle Matthew
72358966bc Remove unused stub. 2023-12-21 12:32:08 -05:00
Hedden, Kyle Matthew
dc622b2f80 Merge branch 'feature/oneApp_4156-LoggingHandlerSwiftMigration' into 'develop' 
story: ONEAPP-4156 LoggingHandler Swift migration

### Summary
Swiftify logging handler

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4156

Co-authored-by: Nandhini Rajendran <nandhini.rajendran@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1015
 2023-12-21 16:28:22 +00:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Matt Bruce
83b2cb80ad refactored two link view 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-15 16:17:36 -06:00
Matt Bruce
e1b6d82007 Merge branch 'develop' into feature/twobuttonview_vds_buttongroup 2023-12-15 15:06:26 -06:00
Rajesh Pullagalla
4dab03c8ec Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2023-12-15 10:48:02 -05:00
Pfeil, Scott Robert
0066827c5d Merge branch 'feature/ONEAPP-6089' into 'develop' 
Text field Spanish localization for optional

### Summary
Update privacy strings for App Clip Spanish support.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6089

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1037
 2023-12-14 23:10:32 +00:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
Sureshkumar Ramachandran
fed4413606 To avoid display on the hamberg menu at discover screen(Homescreen) 2023-12-08 17:33:44 +05:30
Sureshkumar Ramachandran
9f2a1cb6d1 Hamberg menu fix 2023-12-08 14:42:50 +05:30
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop' 
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
 2023-12-05 14:42:29 +00:00
Hedden, Kyle Matthew
aba99b887b Merge branch 'revert-9c75add4' into 'develop' 
Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'"

### Summary
Reverting changes done for scrubber update as the requirement is no longer valid.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5868

Co-authored-by: Rajendran, Nandhini <nandhini.rajendran@one.verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1034
 2023-12-04 15:29:33 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'" 
This reverts merge request !1010
 2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
e48867446c Merge branch 'bugfix/tabbar_index_crash_fix' into 'release/11_1_4' 
Bugfix/tabbar index crash fix

### Summary
Top crash prevention when the web bridge gives an invalid tab index.

### Crash Signature
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/d55575695f799d0b41da74b063331db6?time=last-seven-days&types=crash&sessionEventKey=85086f6b016242f0b3ef04b40d6e46a6_1886152816176443688

```
Crashed: com.apple.main-thread
0  MVMCoreUI                      0x38ed04 TabBar.highlightTab(at:) + 90 (TabBar.swift:90)
1  MVMCoreUI                      0x38ed34 @objc TabBar.highlightTab(at:) + 7800 (<compiler-generated>:7800)
2  MobileFirstFramework           0x48fb94 MVMCoreViewControllerProtocol<>.update(_:) + 57 (WebviewBridgeWebPageLoaded.swift:57)
3  MobileFirstFramework           0x954288 (1) suspend resume partial function for closure #1 in WebViewBridgeUpdateTabBar.performBridgeAction(with:viewController:completionHandler:) + 20 (WebViewBridgeUpdateTabBar.swift:20)
```

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1033
 2023-12-01 19:35:36 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Pfeil, Scott Robert
547c3ad2a4 Merge branch 'bugfix/CXTDT-459511' into 'release/11_1_4' 
Setting accessibility label if available before text for eyebrow, headline,...

### Summary
Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label

### JIRA Ticket
[CXTDT-459511](https://onejira.verizon.com/browse/CXTDT-459511)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>
Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1031
 2023-12-01 16:13:26 +00:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30