Commit Graph

4900 Commits

Author SHA1 Message Date
Matt Bruce
29f43b7861 added helper for TextStyle extension
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-12 17:31:13 -06:00
Matt Bruce
e3b335e6a6 updated Styler
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-12 17:30:59 -06:00
Matt Bruce
2e937fd0de updated model
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-12 17:30:40 -06:00
Hedden, Kyle Matthew
3057226a75 Code Review. Embracing the implicit nature of Swift (?) and preventing a change highlight. 2024-02-12 11:08:22 -05:00
Matt Bruce
b267e196fd added override to set model selectedIndex
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-09 10:00:00 -06:00
Hedden, Kyle Matthew
9c848e610c Hold onto selected tab index in the view model. 2024-02-09 09:59:44 -06:00
Hedden, Kyle Matthew
1d4294803a Remove the duplicate load gif. Rely on the defaultCompletionBlock. 2024-02-08 21:03:19 -05:00
Hedden, Kyle Matthew
f4cb350a95 Hold onto selected tab index in the view model. 2024-02-08 19:58:55 -05:00
Hedden, Kyle Matthew
fd4c634c74 Merge remote-tracking branch 'refs/remotes/origin/develop'
Conflicts:
	MVMCoreUI.xcodeproj/project.pbxproj
2024-02-08 16:38:33 -05:00
Hedden, Kyle Matthew
7a1ef28b1c PageBehaviorContainerModelProtocol spelling fix. 2024-02-08 14:14:40 -05:00
Hedden, Kyle Matthew
6e96976a55 Merge branch 'bugfix/CXTDT-459435' into 'release/11_2_0'
bugfix - Removing titleLabel from accessible elements

### Summary
Removing titleLabel from accessible elements in TextEntryField molecule, as the title's text is set as the textfields accessibilityLabel, thus reading the same title twice.


### JIRA Ticket
CXTDT-459435

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1052
2024-02-02 19:59:39 +00:00
Sumanth Nadigadda
4634cff455 bugfix: CXTDT-459435 - Removing titleLabel from accessible elements, as the title's text is set as the textfields accessibilityLabel. 2024-02-02 17:26:23 +05:30
Matt Bruce
9a03c84131 Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-02-01 16:49:18 -06:00
Matt Bruce
0a291491eb fixed constraint
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 16:49:02 -06:00
Matt Bruce
21afbb55cd Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-02-01 16:30:42 -06:00
Matt Bruce
cc85cfac79 updated for the notes scott left
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 16:30:22 -06:00
Matt Bruce
548bb364f3 updated type
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:50:38 -06:00
Matt Bruce
cf0d42b908 added negative for trailing
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:49:48 -06:00
Matt Bruce
eb2d660760 added a wrapper view for tabs along with constraints so that we can expand and collapse margins based on the tabs configuration
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:28:01 -06:00
Matt Bruce
89daf16d29 Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-01-30 11:35:06 -06:00
Matt Bruce
d56f34258d added var to determine fillContainer
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-30 11:31:18 -06:00
Matt Bruce
7469a5249f added fillContainer to model/view
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-30 11:31:06 -06:00
Matt Bruce
e7b9702fd2 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_tabs 2024-01-30 11:30:40 -06:00
Matt Bruce
b8c929e3df Merge branch 'feature/atomic_vds_loader' into feature/vds_batch_two 2024-01-29 15:31:37 -06:00
Matt Bruce
87a8051bbe Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-29 15:31:29 -06:00
Matt Bruce
e9b2a62bc9 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_loader 2024-01-29 15:29:01 -06:00
Matt Bruce
ce66b2466e check to ensure this hasn't been created.
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:28:02 -06:00
Matt Bruce
8201b8fad4 fixed bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:27:52 -06:00
Matt Bruce
a81ff55e6e updated to not return hardcoded value
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:25:34 -06:00
Matt Bruce
9dc77bd1ed updated reset
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:21:47 -06:00
Matt Bruce
3f7fd100f9 percentage doesn't matter for Links, only matters for pillbuttons
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:20:18 -06:00
Matt Bruce
9db98a2078 added else
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:15:19 -06:00
Matt Bruce
59175c45fc added previousModel
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 14:16:27 -06:00
Matt Bruce
fbcf881535 added nameForReuse check
refactored buttons to either create or set

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 13:16:37 -06:00
Matt Bruce
315a96470b added ParentMoleculeModelProtocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 13:16:07 -06:00
Matt Bruce
38907c7ac1 updating the model to set the TwoButtonModel to fillContainer if needed
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:59:25 -06:00
Matt Bruce
d81daf1df3 not resetting if the current count is correct
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:55 -06:00
Matt Bruce
1932fd7231 fixed bug for removing old references in array
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:23 -06:00
Matt Bruce
f99d4e3c4d added fillContainer: Bool to deal with updating if the buttonGroup fills or not
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:07 -06:00
Matt Bruce
cdc8b7310d added ParewntMoleculeModelProtocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:57:32 -06:00
Matt Bruce
a3f940f1cc Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-26 09:17:50 -06:00
Matt Bruce
fb459cfdd5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-26 09:17:19 -06:00
Hedden, Kyle Matthew
baca0d8031 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-25 17:05:03 -05:00
Matt Bruce
5164a91ad6 Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-25 13:36:38 -06:00
Matt Bruce
fef1e0f9ff CXTDT-511155 - VDS_Cancel and Delete CTAs are missing in Edit All Calls and Edit Missed Calls screen
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-25 13:35:59 -06:00
Matt Bruce
3db8701fea Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-25 10:32:35 -06:00
Rajesh Pullagalla
0506347bdb Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-25 10:53:52 -05:00
Hedden, Kyle Matthew
14ccfe61be Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-24 15:53:38 -05:00
Sumanth Nadigadda
75729fd414 defect: CXTDT-458975 Removing button text in the accessibility label. 2024-01-24 23:33:57 +05:30
Pfeil, Scott Robert
2a847602a2 Merge branch 'bugfix/PRODDEF-19592' into 'develop'
Updated textView to have label text for accessibility behavior

### Summary
Updated textView to have label text for accessibility behavior

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-19592

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1029
2024-01-24 16:46:04 +00:00
Pfeil, Scott Robert
54519d9820 Merge branch 'feature/dynamicAccessibilityTraits' into 'develop'
Added accessibilityTraits dynamically for buttons, List components

### Summary
Driven all the buttons and list components traits dynamically. As per the WCAG Accessibility guidelines,

Button role - is used to trigger an action e,g confirm information, submit data, continue multi step task.  (Button page #45) 

Link role - Links should be used only for actions that take the user to other locations and, should not be used for button-like functionality.(Text Link page# 46).

Google drive link : ([https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!\[Links__2\_\](/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2\_.png](https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!%5BLinks__2_%5D(/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2_.png))

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-421918

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>
Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/996
2024-01-24 16:33:47 +00:00
Keerthy
648bfdc76b Missed file 2024-01-24 21:41:46 +05:30
Keerthy
d1ee6e7f3a Addressed code review comments 2024-01-24 16:18:35 +05:30
Keerthy
459d3e4a33 Merge branch 'develop' into bugfix/PRODDEF-19592 2024-01-24 16:00:45 +05:30
Keerthy
eb5d359322 Addressed review comments
Added accessibilityHint to AccessibilityModelProtocol
2024-01-22 23:29:47 +05:30
Matt Bruce
f2d55d714b Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-01-19 16:44:55 -06:00
Matt Bruce
0351a0620d put backgroundcolor in init for tabs
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-19 16:44:36 -06:00
Matt Bruce
e0adf8b55d Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-01-19 16:02:39 -06:00
Matt Bruce
91eb0a5636 added fillContainer and backgroundColor
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-19 16:02:21 -06:00
Matt Bruce
1965920710 fixed delegate bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-19 14:50:30 -06:00
Matt Bruce
42dfca5fc6 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 16:05:27 -06:00
Matt Bruce
84ba882b37 Merge branch 'feature/atomic_vds_tooltip' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 15:33:09 -06:00
Matt Bruce
2f80ee891d added text to use string file
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-18 15:25:50 -06:00
Matt Bruce
b0c1e2521c Merge branch 'feature/atomic_vds_loader' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 15:11:15 -06:00
Matt Bruce
85b1bbc501 Merge branch 'feature/atomic_vds_loader' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_loader 2024-01-18 14:48:06 -06:00
Matt Bruce
d5a9710b6c added other initiliazers
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-18 14:47:13 -06:00
Hedden, Kyle Matthew
03d1848c50 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-17 11:27:46 -05:00
Matt Bruce
4eb2e77862 Merge branch 'feature/atomic_vds_tooltip' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift
#	MVMCoreUI/OtherHandlers/CoreUIModelMapping.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-17 08:49:11 -06:00
Rajesh Pullagalla
db3e7c22eb Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-17 09:07:45 -05:00
Matt Bruce
d2af968892 Merge branch 'feature/atomic_vds_textLinkCaret' into feature/vds_batch_two
# Conflicts:
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-16 13:32:23 -06:00
Matt Bruce
e3f8fe05bd Merge branch 'feature/atomic_vds_loader' into feature/vds_batch_two 2024-01-16 13:30:43 -06:00
Matt Bruce
ac4faf572c Merge branch 'feature/atomic_vds_icon' into feature/vds_batch_two
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-16 13:30:15 -06:00
Matt Bruce
a274028fbc Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two
# Conflicts:
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-16 13:12:22 -06:00
Hedden, Kyle Matthew
950f63e87b Merge branch 'feature/ONEAPP-6340' into 'develop'
ONEAPP-6435

### Summary
Open the progress bar molecule model for extension.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6435

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1040
2024-01-12 15:20:05 +00:00
Hedden, Kyle Matthew
8a62065ade open encoder 2024-01-11 18:17:06 -05:00
Matt Bruce
3fc3abd82e Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_tabs 2024-01-11 12:10:13 -06:00
Matt Bruce
1f74c88ce6 added enabled
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-11 12:07:42 -06:00
Matt Bruce
ea3ee2adda added comments
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-11 11:42:53 -06:00
Matt Bruce
8ba25bb661 registered ButtonGroup Atom
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-11 11:31:58 -06:00
Matt Bruce
71a10f1055 added buttonGroup
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-11 11:19:18 -06:00
Keerthy
3d7e1ac646 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2024-01-09 12:39:45 +05:30
vimal
1541c9bb4a Merge branch 'feature/molecule_replacement_behavior' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_header_fix 2024-01-08 09:32:17 +05:30
vimal
46a3af5e6b review comment updated 2024-01-08 09:30:09 +05:30
Hedden, Kyle Matthew
3bd53784f0 PollingBehavior initial implementation. 2024-01-05 22:27:47 -05:00
Matt Bruce
62e9197b8f Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-05 15:23:17 -06:00
Matt Bruce
9e500fe1c8 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_icon 2024-01-05 09:55:21 -06:00
Hedden, Kyle Matthew
929cb33b5f set the intiial tint state for ImageButton 2024-01-04 14:19:28 -05:00
Matt Bruce
71bc90c4ef Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_textLinkCaret 2024-01-04 11:27:24 -06:00
vimal
03ea6c528c minor cleanup 2024-01-04 11:07:34 +05:30
Matt Bruce
eb8ea989ec refactored back in the obj-c interface to interact with swift extension
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-03 15:13:39 -06:00
Matt Bruce
c03e04069a refactored loader
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-03 14:04:30 -06:00
vimal
db7e59191a fix for button model
review comment updated
2024-01-03 23:25:48 +05:30
vimal
b6623b34c6 Merge branch 'feature/molecule_replacement_behavior' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_header_fix 2024-01-03 15:26:37 +05:30
vimal
047d9b7014 enhancement on the header update based on the molecules 2024-01-03 15:23:29 +05:30
Hedden, Kyle Matthew
c2c4e0f1f4 indexing safety 2024-01-02 17:25:43 -05:00
Hedden, Kyle Matthew
ca10c0b849 indexing safety 2024-01-02 17:24:42 -05:00
Rajesh Pullagalla
d8dce51106 Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-02 10:23:26 -05:00
vimal
c91d389ea5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
2023-12-22 18:32:55 +05:30
Hedden, Kyle Matthew
8306f901bd Open up progress bar atom for subclassing. 2023-12-21 22:19:45 -05:00
Hedden, Kyle Matthew
72358966bc Remove unused stub. 2023-12-21 12:32:08 -05:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Hedden, Kyle Matthew
4f586ced89 Animate GIFs. 2023-12-20 19:16:22 -05:00
Hedden, Kyle Matthew
b681f331ba Fix data desync on update. 2023-12-19 12:42:11 -05:00
Hedden, Kyle Matthew
2857b1cd55 Stop closure efficiency. 2023-12-18 17:22:40 -05:00
Hedden, Kyle Matthew
df32a51395 Fix first time carousel replacement. 2023-12-18 17:19:52 -05:00
Matt Bruce
83b2cb80ad refactored two link view
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-15 16:17:36 -06:00
Matt Bruce
e1b6d82007 Merge branch 'develop' into feature/twobuttonview_vds_buttongroup 2023-12-15 15:06:26 -06:00
Rajesh Pullagalla
4dab03c8ec Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2023-12-15 10:48:02 -05:00
Matt Bruce
51f9f2eba2 registered view
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 16:04:31 -06:00
Matt Bruce
61cb8b300b added tooltip view and model
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 16:04:24 -06:00
Matt Bruce
c191066523 added enum codables for tooltip
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 16:04:08 -06:00
Matt Bruce
c25c3ec9ab added initial cut for icon, iconModel and registered it within the system.
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 15:13:08 -06:00
Matt Bruce
d92973dc55 updated decoder to look for VDS Color name as well as hex
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 15:12:38 -06:00
Matt Bruce
6c3092a1f6 added more codables and default codable property wrappers
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-14 15:12:16 -06:00
Matt Bruce
86b835fc60 fixed bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-13 15:43:40 -06:00
Matt Bruce
55b6b491af initial cut for TitleLockup and model
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-13 15:28:58 -06:00
Matt Bruce
6e74c5e9b3 added enum codable
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-13 15:07:52 -06:00
Matt Bruce
71e291ccb5 updated api
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-13 14:39:01 -06:00
Matt Bruce
7baa6d31a0 pointed to new property
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-11 14:20:06 -06:00
Matt Bruce
49a385c12a removed legacy properties
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-11 14:19:49 -06:00
Matt Bruce
18372f9ed6 fixed bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-11 14:19:29 -06:00
Matt Bruce
7c0e8bb106 updated tabsModel and Tabs
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-11 14:19:00 -06:00
Matt Bruce
8a90a8ce4a added new codable from vds
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-11 14:18:44 -06:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
vimal
0ecfef39cd review comment updated. setting the height from model if not exist then hard coded value 2023-12-11 13:46:41 +05:30
Sureshkumar Ramachandran
fed4413606 To avoid display on the hamberg menu at discover screen(Homescreen) 2023-12-08 17:33:44 +05:30
Sureshkumar Ramachandran
9f2a1cb6d1 Hamberg menu fix 2023-12-08 14:42:50 +05:30
Matt Bruce
6a8e45fc9e initial cut for VDS Loader
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-06 14:39:46 -06:00
Matt Bruce
cf0e3086cf added accessibilityText
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-05 15:46:34 -06:00
Matt Bruce
938a5d1192 first cut for the conversion
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-12-05 15:46:22 -06:00
Hedden, Kyle Matthew
ac88b5d2b1 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-12-05 14:39:29 -05:00
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop'
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
2023-12-05 14:42:29 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'"
This reverts merge request !1010
2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30
Keerthy
d65df06934 Updated textView to have label text for accessibility behavior 2023-11-22 18:07:13 +05:30
Hedden, Kyle Matthew
4687d7d344 self cleanups 2023-11-15 17:30:18 -05:00
Hedden, Kyle Matthew
61916e7c38 Move hightlightTab to @MainActor to prevent block crash. 2023-11-15 17:14:51 -05:00
Pfeil, Scott Robert
85e967c492 Merge branch 'bugfix/PRODDEF-1289_accessibilityChanges' into 'develop'
Added static test for carousel.

### Summary
Added static test for carousel.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1289

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/972
2023-11-02 20:36:41 +00:00
Pfeil, Scott Robert
c1cb411491 Merge branch 'feature/searchResultAnnouncement' into 'develop'
Updated accessibilityText in ListItemModel for searchResults announcement

### Summary
Updated accessibilityText in ListItemModel for searchResults announcement.

Dependent PR's : 
https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2172

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1022
2023-11-02 20:35:41 +00:00
Keerthy
8e4ad2c41e Updated accessibilityText in ListItemModel for searchResults announcement 2023-11-03 00:11:16 +05:30
Krishna Kishore Bandaru
a3c4c2248c removed unused code & added hidden check 2023-11-02 23:06:05 +05:30
Krishna Kishore Bandaru
9c43649cce added review comments 2023-11-02 21:40:01 +05:30
vimal
50caab7936 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-11-02 20:42:40 +05:30
Keerthy
df2fa3405b Updated delegateObject and delegate properties
removed weak ref for delegateObject. updated delegate as delegate.loadDelegate
2023-11-02 18:46:27 +05:30
Keerthy
d5f5072560 Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:50 +05:30
Keerthy
9d80f2027e Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:03 +05:30
Bruce, Matt R
c202a93acf Merge branch 'bugfix/CXTDT-446531' into 'develop'
Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, checkBoxLabel

### Summary
1. Textfield : VO should reads as label, textField.
2. Picker : VO should read as label, current selection , has popup/ picker item.
3. CheckBox Label : Both checkbox and label should have single focus, VO should read as checkbox role, status and label.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-446531

This PR is having dependency with https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2263. Unable to add dependency in this PR.

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1020
2023-11-01 21:11:27 +00:00
Bruce, Matt R
747db3290e Merge branch 'bugfix/accessibilityFocusFixForListLVImgAllCell' into 'develop'
Updated linkShowing logic for accessibility

### Summary
In VDS Link component, we have default text assigned to Link(ButtonBase) as "No Text". Because of that default text, `eyebrowHeadlineBodyLink.link.titleLabel?.text?.count ?? 0 > 0` condition is getting true even though we don't have link in the model/UI.

Updated condition based on model text.

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1018
2023-11-01 20:57:50 +00:00
Pfeil, Scott Robert
7267516b72 Merge branch 'bugfix/focusStuckIssue' into 'develop'
Commented logic for focus skip issue

### Summary
We are seeing issue where the focus is getting skipped with voiceOver when going in backward direction. Due to limited JSON's in postpay, we have validated with prepay JSON's and identified below list of JSON's where we are seeing the issue. 

Below are the list of JSON's we have verified.

https://oneconfluence.verizon.com/display/MFP/PREGRO-5742+-++What%27s+changing+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-5735+-+Select+a+plan+screen+-+Overview
https://oneconfluence.verizon.com/display/MFP/PREGRO-5741+-+Review+new+plan+screen
https://oneconfluence.verizon.com/pages/viewpage.action?pageId=950516937
https://oneconfluence.verizon.com/display/MFP/PREGRO-5754+-+Review+details+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-6033+-+Update+-+Monthly+Costs+screen

When commented the logic related to accessibilityElements we are not facing any issue either in forward or backward direction.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-436601 (issue 3)

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/985
2023-11-01 20:49:58 +00:00
Keerthy
5920bf3e50 Order change 2023-11-02 00:52:13 +05:30
Keerthy
84314aa5ed Merge branch 'develop' into bugfix/CXTDT-446531 2023-11-02 00:01:58 +05:30
Keerthy
9fe6a4dfc1 Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, CheckboxLabel 2023-11-01 23:59:34 +05:30
Keerthy
5d7dab8879 Removed checkbox from rotor 2023-11-01 22:51:04 +05:30
Hedden, Kyle Matthew
d61103ee6e Merge branch 'feature/LoadingOverlay-Text' into 'develop'
Option to show text in the loading overlay screen

### Summary
Adding option to show text on loading overlay screen.

### JIRA Ticket
[ONEAPP-5807](https://onejira.verizon.com/browse/ONEAPP-5807)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1009
2023-11-01 17:01:56 +00:00
Scott Pfeil
848defaf39 32 -> 16 horizontal margin 2023-11-01 12:33:03 -04:00
Krishna Kishore Bandaru
975882d47c addressed code review comments 2023-11-01 18:11:22 +05:30
Krishna Kishore Bandaru
34dcc80f67 Updated linkShowing logic for accessibility 2023-11-01 14:09:55 +05:30
Keerthy
96fa0bf314 Removed accessibilityElements to resolve focus stuck issue 2023-11-01 13:47:23 +05:30
Keerthy
fe40639a19 Merge branch 'develop' into bugfix/focusStuckIssue 2023-11-01 13:46:09 +05:30
Keerthy
733a0a1b94 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-11-01 11:33:29 +05:30
Keerthy
7b4dd51a74 Merge branch 'develop' into feature/accessibilityHandler 2023-11-01 11:32:50 +05:30
Keerthy
92b7c3ef36 foucs spelling mistake 2023-11-01 11:19:30 +05:30
vimal
7643b4173b Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-11-01 07:31:41 +05:30
Keerthy
24c684d64f Updated accessibilityBehavior 2023-11-01 00:06:41 +05:30
Sumanth Nadigadda
9be7fef53c Showing/Hiding the text while starting/pausing the loading overlay 2023-10-31 22:51:39 +05:30
Rajendran, Nandhini
4b9c386071 story: ONEAPP-5868 page control update 2023-10-31 15:30:39 +00:00
Sumanth Nadigadda
d057559353 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/LoadingOverlay-Text 2023-10-31 19:47:30 +05:30
vimal
339232f9fa give better estimate height 2023-10-31 16:06:20 +05:30
Krishna Kishore Bandaru
3900294189 Merge branch 'develop' into feature/accessibilityHandler 2023-10-31 11:47:49 +05:30
Scott Pfeil
17a16bf73c change encode 2023-10-30 12:47:53 -04:00
Scott Pfeil
49d6d2bf76 bugfix for old color properties 2023-10-30 12:45:12 -04:00
Keerthy
6ad71383f4 Merge branch 'feature/accessibilityHandler' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/accessibilityHandler 2023-10-30 13:55:24 +05:30
Keerthy
e48db9495d Minor refactoring 2023-10-30 13:54:48 +05:30
Krishna Kishore Bandaru
92b7055096 Merge branch 'develop' into feature/accessibilityHandler 2023-10-27 18:51:30 +05:30
Hedden, Kyle Matthew
e8b47988f4 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-10-26 17:09:21 -04:00
Hedden, Kyle Matthew
1eb0103744 fix stack overflow error on RawRepresentable encoding 2023-10-26 16:39:30 -04:00
Keerthy
8f002f9422 Merge branch 'develop' into feature/accessibilityHandler 2023-10-26 23:48:37 +05:30
Keerthy
0f2f00f6d4 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-10-26 23:34:26 +05:30
Hedden, Kyle Matthew
6431982d69 Merge branch 'feature/molecule_replacement_behavior' of gitlab.verizon.com:BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-10-26 12:54:09 -04:00
Hedden, Kyle Matthew
50646851ba move model replacement to the viewcontroller for model state synchronization & stability. shift replacement molecule handling to the behavior for targeted updates. 2023-10-26 12:52:08 -04:00
Bruce, Matt R
58afcc596d Merge branch 'feature/ListStoreLocatorMoleculeEnhancement' into 'develop'
ListStoreLocator component enhancement

### Summary
We have got confirmation from businesses to use the existing listStoreLocator molecule instead of having a new one created.
Updated heart with badge as per the new design.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-5098

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1012
2023-10-26 16:42:53 +00:00
Pfeil, Scott Robert
025667f856 Merge branch 'feature/atomic_vds_badge' into 'develop'
Introduced the VDS Badge into Atomic

Co-authored-by: Bruce, Matt R <matt.bruce@one.verizon.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>
Co-authored-by: Rebecca Antonelli <rebecca.antonelli@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1013
2023-10-26 16:39:52 +00:00
Keerthy
8ca636aa23 Merge branch 'develop' into feature/accessibilityHandler 2023-10-26 22:07:58 +05:30
Keerthy
1e5578a66c discarded unwanted changes 2023-10-26 22:06:55 +05:30
Bruce, Matt R
0c4136a6b1 removed comment 2023-10-26 15:08:24 +00:00
Keerthy
43f1c64151 updated logic 2023-10-26 18:44:51 +05:30
vimal
b62641c601 Merge branches 'feature/molecule_replacement_behavior' and 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-10-26 10:14:55 +05:30
Bruce, Matt R
5d347ffaaf Merge branch 'develop' into 'feature/atomic_vds_textLink'
# Conflicts:
#   MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift
2023-10-25 20:40:04 +00:00
Bruce, Matt R
95db3b5b86 Merge branch 'develop' into 'feature/atomic_vds_line'
# Conflicts:
#   MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift
2023-10-25 20:11:07 +00:00
Bruce, Matt R
7c040ce919 Merge branch 'develop' into 'feature/atomic_vds_textLink'
# Conflicts:
#   MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift
2023-10-25 19:58:53 +00:00
Scott Pfeil
e373aa3b08 Full width foot pill button 2023-10-23 17:42:32 -04:00
Scott Pfeil
b1da7aaeed Footer button filled for iphones 2023-10-23 16:41:08 -04:00
Scott Pfeil
840b473587 Merge branch 'develop' into feature/atomic_vds_button 2023-10-23 15:40:26 -04:00
Keerthy
eea1fa45e1 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2023-10-23 12:29:48 +05:30
Keerthy
fb760bf91e Added dynamic trait for ListStoreLocator 2023-10-20 00:18:29 +05:30
Keerthy
82ba81960c ListStoreLocator component enhancement
Updated heart with badge as per new design
2023-10-20 00:12:05 +05:30
Krishna Kishore Bandaru
b66b49d173 Added comments for methods 2023-10-19 18:00:20 +05:30
Sumanth Nadigadda
fdaa932c3b Enabling the loading overlay info text to take attributed string. 2023-10-19 16:58:07 +05:30
Krishna Kishore Bandaru
436d4c746b review comments and enhancements in rotorhandler 2023-10-19 10:35:27 +05:30
Krishna Kishore Bandaru
ac287ef379 Merge branch 'develop' into feature/accessibilityHandler 2023-10-18 14:23:08 +05:30
vimal
87e2b66dce Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-10-18 11:51:10 +05:30
Sumanth Nadigadda
0a42ebb032 Setting empty string to the text in the loading overlay 2023-10-17 20:14:19 +05:30
Sumanth Nadigadda
24d456d4b5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/LoadingOverlay-Text 2023-10-17 14:59:51 +05:30
Sumanth Nadigadda
20a4a2c87b Moving progress indicator below the text in the loading overlay screen 2023-10-17 14:57:25 +05:30
Hedden, Kyle Matthew
b640863167 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-10-16 15:39:55 -04:00
Krishna Kishore Bandaru
f73dbee190 Added rotor for checkbox 2023-10-16 18:48:49 +05:30
Keerthy
cb50234090 Spelling refactoring 2023-10-16 13:00:12 +05:30
Keerthy
67dfe37e97 Addressed review comments and removed model based traits for button 2023-10-16 12:49:35 +05:30
Scott Pfeil
c8aac2e5d7 Updated to get the upcoming view controller navigationBar model 2023-10-13 14:21:22 -04:00
Keerthy
c972597a11 Addressed review comments 2023-10-13 23:31:18 +05:30
Krishna Kishore Bandaru
521eaa7c15 Added RotorHandler & addressed review comments 2023-10-13 22:28:00 +05:30
Keerthy
a3d3b1e635 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2023-10-13 15:01:38 +05:30
Sumanth Nadigadda
7fc1b6430d Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/LoadingOverlay-Text 2023-10-13 14:03:47 +05:30
Scott Pfeil
281f1e8f52 Fix extra space on the left of title issue for ExternalLink 2023-10-12 12:52:23 -04:00
Scott Pfeil
58362cdf15 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_line 2023-10-11 10:28:32 -04:00
Scott Pfeil
ee217a4f12 merge develop 2023-10-11 10:20:41 -04:00
Scott Pfeil
4c9cc5edbb Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_button 2023-10-11 09:49:33 -04:00
Krishna Kishore Bandaru
8dc475ffdd addressed review comments & added model property to MoleculeViewProtocol 2023-10-11 00:47:31 +05:30
Hedden, Kyle Matthew
261189b8c1 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-10-10 10:04:45 -04:00
Pfeil, Scott Robert
f00df65110 Merge branch 'release/11_0_0' into 'develop'
release/11_0_0 hotfix merge

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1002
2023-10-10 13:29:48 +00:00
Keerthy
bada7deb53 Merge branch 'develop' into bugfix/focusStuckIssue 2023-10-06 16:00:52 +05:30
Hedden, Kyle Matthew
20d49ed498 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-10-05 17:22:49 -04:00
Hedden, Kyle Matthew
0afa13392f take into account contentInset when calculating itemWidth 2023-10-05 13:53:19 -04:00
Hedden, Kyle Matthew
6957f18753 decoding error clarity 2023-10-05 13:47:55 -04:00
Scott Pfeil
e940c9bf08 add to default config 2023-10-04 17:20:54 -04:00
Krishna Kishore Bandaru
88505e704c addressed review comments 2023-10-04 20:08:46 +05:30
Scott Pfeil
308700c667 MVMCoreObject to swift 2023-10-04 10:17:49 -04:00
Krishna Kishore Bandaru
c6004bd6d0 Merge branch 'develop' into feature/accessibilityHandler 2023-10-03 10:11:10 +05:30
Scott Pfeil
c3503edecb Changes to ensure line does not stretch 2023-09-28 20:39:50 -04:00
Scott Pfeil
e5e17a286d fix to vertical lines 2023-09-28 20:31:25 -04:00
Scott Pfeil
1da8a6db77 Default to secondary 2023-09-28 20:12:36 -04:00
Scott Pfeil
4d4f7c334d Code review: Fix data list items and navigation bar. 2023-09-28 19:41:06 -04:00
Scott Pfeil
3f6e1b1baa Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_line 2023-09-28 18:08:43 -04:00
Scott Pfeil
2d83b8a6ef Guard in link code. 2023-09-28 10:22:38 -04:00
Hedden, Kyle Matthew
bab59e4e5d Merge branch 'bugfix/account_native_testing' into 'develop'
Link Fix

### Summary
Fix to Link

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/999
2023-09-28 13:40:00 +00:00
Scott Pfeil
ab9d61fd15 Link Fix 2023-09-28 09:25:50 -04:00
Scott Pfeil
9c6ded77e2 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_textLink 2023-09-27 18:47:33 -04:00
Matt Bruce
8d15044516 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_line 2023-09-27 15:57:59 -05:00
Matt Bruce
a19bd60f06 indented
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:56:53 -05:00
Matt Bruce
f98c6059b8 rearranged
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:53:53 -05:00
Matt Bruce
ab50921e88 added color extension for isDark
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 15:34:49 -05:00
Scott Pfeil
194363a555 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_textLink 2023-09-27 16:02:21 -04:00
Krishna Kishore Bandaru
46fb714d34 added heading level rotor 2023-09-27 20:53:50 +05:30
Matt Bruce
1439197870 marked up
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2023-09-27 09:40:54 -05:00
Matt Bruce
48edde5296 Merge branch 'develop' into feature/atomic_vds_badge 2023-09-27 09:39:41 -05:00
Scott Pfeil
7c36db36f4 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/atomic_vds_button 2023-09-27 09:44:34 -04:00
Krishna Kishore Bandaru
c33fbfba90 Merge branch 'develop' into feature/accessibilityHandler 2023-09-27 12:25:42 +05:30