mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,440 Commits 64 Branches 0 Tags 46 MiB
1b10c21100
Commit Graph

4648 Commits

Author SHA1 Message Date
Matt Bruce
1965920710 fixed delegate bug 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-19 14:50:30 -06:00
Matt Bruce
42dfca5fc6 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 16:05:27 -06:00
Matt Bruce
84ba882b37 Merge branch 'feature/atomic_vds_tooltip' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 15:33:09 -06:00
Matt Bruce
2f80ee891d added text to use string file 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-18 15:25:50 -06:00
Matt Bruce
b0c1e2521c Merge branch 'feature/atomic_vds_loader' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 2024-01-18 15:11:15 -06:00
Matt Bruce
85b1bbc501 Merge branch 'feature/atomic_vds_loader' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_loader 2024-01-18 14:48:06 -06:00
Matt Bruce
d5a9710b6c added other initiliazers 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-18 14:47:13 -06:00
Matt Bruce
4eb2e77862 Merge branch 'feature/atomic_vds_tooltip' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_two 
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift
#	MVMCoreUI/OtherHandlers/CoreUIModelMapping.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-17 08:49:11 -06:00
Rajesh Pullagalla
db3e7c22eb Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-17 09:07:45 -05:00
Matt Bruce
d2af968892 Merge branch 'feature/atomic_vds_textLinkCaret' into feature/vds_batch_two 
# Conflicts:
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-16 13:32:23 -06:00
Matt Bruce
e3f8fe05bd Merge branch 'feature/atomic_vds_loader' into feature/vds_batch_two 2024-01-16 13:30:43 -06:00
Matt Bruce
ac4faf572c Merge branch 'feature/atomic_vds_icon' into feature/vds_batch_two 
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-16 13:30:15 -06:00
Matt Bruce
a274028fbc Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 
# Conflicts:
#	MVMCoreUI/Atomic/Extensions/VDS-Enums+Codable.swift

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-16 13:12:22 -06:00
Hedden, Kyle Matthew
950f63e87b Merge branch 'feature/ONEAPP-6340' into 'develop' 
ONEAPP-6435

### Summary
Open the progress bar molecule model for extension.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6435

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1040
 2024-01-12 15:20:05 +00:00
Hedden, Kyle Matthew
8a62065ade open encoder 2024-01-11 18:17:06 -05:00
Matt Bruce
3fc3abd82e Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_tabs 2024-01-11 12:10:13 -06:00
Matt Bruce
1f74c88ce6 added enabled 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 12:07:42 -06:00
Matt Bruce
ea3ee2adda added comments 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:42:53 -06:00
Matt Bruce
8ba25bb661 registered ButtonGroup Atom 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:31:58 -06:00
Matt Bruce
71a10f1055 added buttonGroup 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-11 11:19:18 -06:00
Keerthy
3d7e1ac646 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2024-01-09 12:39:45 +05:30
Matt Bruce
62e9197b8f Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-05 15:23:17 -06:00
Matt Bruce
9e500fe1c8 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_icon 2024-01-05 09:55:21 -06:00
Matt Bruce
71bc90c4ef Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_textLinkCaret 2024-01-04 11:27:24 -06:00
Matt Bruce
eb8ea989ec refactored back in the obj-c interface to interact with swift extension 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-03 15:13:39 -06:00
Matt Bruce
c03e04069a refactored loader 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-01-03 14:04:30 -06:00
Hedden, Kyle Matthew
c2c4e0f1f4 indexing safety 2024-01-02 17:25:43 -05:00
Rajesh Pullagalla
d8dce51106 Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2024-01-02 10:23:26 -05:00
Hedden, Kyle Matthew
8306f901bd Open up progress bar atom for subclassing. 2023-12-21 22:19:45 -05:00
Hedden, Kyle Matthew
72358966bc Remove unused stub. 2023-12-21 12:32:08 -05:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Matt Bruce
83b2cb80ad refactored two link view 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-15 16:17:36 -06:00
Matt Bruce
e1b6d82007 Merge branch 'develop' into feature/twobuttonview_vds_buttongroup 2023-12-15 15:06:26 -06:00
Rajesh Pullagalla
4dab03c8ec Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2023-12-15 10:48:02 -05:00
Matt Bruce
51f9f2eba2 registered view 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:31 -06:00
Matt Bruce
61cb8b300b added tooltip view and model 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:24 -06:00
Matt Bruce
c191066523 added enum codables for tooltip 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:08 -06:00
Matt Bruce
c25c3ec9ab added initial cut for icon, iconModel and registered it within the system. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:13:08 -06:00
Matt Bruce
d92973dc55 updated decoder to look for VDS Color name as well as hex 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:12:38 -06:00
Matt Bruce
6c3092a1f6 added more codables and default codable property wrappers 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:12:16 -06:00
Matt Bruce
71e291ccb5 updated api 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-13 14:39:01 -06:00
Matt Bruce
7baa6d31a0 pointed to new property 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:20:06 -06:00
Matt Bruce
49a385c12a removed legacy properties 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:49 -06:00
Matt Bruce
18372f9ed6 fixed bug 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:29 -06:00
Matt Bruce
7c0e8bb106 updated tabsModel and Tabs 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:00 -06:00
Matt Bruce
8a90a8ce4a added new codable from vds 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:18:44 -06:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
Sureshkumar Ramachandran
fed4413606 To avoid display on the hamberg menu at discover screen(Homescreen) 2023-12-08 17:33:44 +05:30
Sureshkumar Ramachandran
9f2a1cb6d1 Hamberg menu fix 2023-12-08 14:42:50 +05:30
Matt Bruce
6a8e45fc9e initial cut for VDS Loader 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-06 14:39:46 -06:00
Matt Bruce
cf0e3086cf added accessibilityText 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-05 15:46:34 -06:00
Matt Bruce
938a5d1192 first cut for the conversion 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-05 15:46:22 -06:00
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop' 
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
 2023-12-05 14:42:29 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'" 
This reverts merge request !1010
 2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30
Keerthy
d65df06934 Updated textView to have label text for accessibility behavior 2023-11-22 18:07:13 +05:30
Hedden, Kyle Matthew
4687d7d344 self cleanups 2023-11-15 17:30:18 -05:00
Hedden, Kyle Matthew
61916e7c38 Move hightlightTab to @MainActor to prevent block crash. 2023-11-15 17:14:51 -05:00
Pfeil, Scott Robert
85e967c492 Merge branch 'bugfix/PRODDEF-1289_accessibilityChanges' into 'develop' 
Added static test for carousel.

### Summary
Added static test for carousel.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-1289

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/972
 2023-11-02 20:36:41 +00:00
Pfeil, Scott Robert
c1cb411491 Merge branch 'feature/searchResultAnnouncement' into 'develop' 
Updated accessibilityText in ListItemModel for searchResults announcement

### Summary
Updated accessibilityText in ListItemModel for searchResults announcement.

Dependent PR's : 
https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2172

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1022
 2023-11-02 20:35:41 +00:00
Keerthy
8e4ad2c41e Updated accessibilityText in ListItemModel for searchResults announcement 2023-11-03 00:11:16 +05:30
Krishna Kishore Bandaru
a3c4c2248c removed unused code & added hidden check 2023-11-02 23:06:05 +05:30
Krishna Kishore Bandaru
9c43649cce added review comments 2023-11-02 21:40:01 +05:30
Keerthy
df2fa3405b Updated delegateObject and delegate properties 
removed weak ref for delegateObject. updated delegate as delegate.loadDelegate
 2023-11-02 18:46:27 +05:30
Keerthy
d5f5072560 Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:50 +05:30
Keerthy
9d80f2027e Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:03 +05:30
Bruce, Matt R
c202a93acf Merge branch 'bugfix/CXTDT-446531' into 'develop' 
Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, checkBoxLabel

### Summary
1. Textfield : VO should reads as label, textField.
2. Picker : VO should read as label, current selection , has popup/ picker item.
3. CheckBox Label : Both checkbox and label should have single focus, VO should read as checkbox role, status and label.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-446531

This PR is having dependency with https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2263. Unable to add dependency in this PR.

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1020
 2023-11-01 21:11:27 +00:00
Bruce, Matt R
747db3290e Merge branch 'bugfix/accessibilityFocusFixForListLVImgAllCell' into 'develop' 
Updated linkShowing logic for accessibility

### Summary
In VDS Link component, we have default text assigned to Link(ButtonBase) as "No Text". Because of that default text, `eyebrowHeadlineBodyLink.link.titleLabel?.text?.count ?? 0 > 0` condition is getting true even though we don't have link in the model/UI.

Updated condition based on model text.

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1018
 2023-11-01 20:57:50 +00:00
Pfeil, Scott Robert
7267516b72 Merge branch 'bugfix/focusStuckIssue' into 'develop' 
Commented logic for focus skip issue

### Summary
We are seeing issue where the focus is getting skipped with voiceOver when going in backward direction. Due to limited JSON's in postpay, we have validated with prepay JSON's and identified below list of JSON's where we are seeing the issue. 

Below are the list of JSON's we have verified.

https://oneconfluence.verizon.com/display/MFP/PREGRO-5742+-++What%27s+changing+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-5735+-+Select+a+plan+screen+-+Overview
https://oneconfluence.verizon.com/display/MFP/PREGRO-5741+-+Review+new+plan+screen
https://oneconfluence.verizon.com/pages/viewpage.action?pageId=950516937
https://oneconfluence.verizon.com/display/MFP/PREGRO-5754+-+Review+details+screen
https://oneconfluence.verizon.com/display/MFP/PREGRO-6033+-+Update+-+Monthly+Costs+screen

When commented the logic related to accessibilityElements we are not facing any issue either in forward or backward direction.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-436601 (issue 3)

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/985
 2023-11-01 20:49:58 +00:00
Keerthy
5920bf3e50 Order change 2023-11-02 00:52:13 +05:30
Keerthy
84314aa5ed Merge branch 'develop' into bugfix/CXTDT-446531 2023-11-02 00:01:58 +05:30
Keerthy
9fe6a4dfc1 Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, CheckboxLabel 2023-11-01 23:59:34 +05:30
Keerthy
5d7dab8879 Removed checkbox from rotor 2023-11-01 22:51:04 +05:30
Hedden, Kyle Matthew
d61103ee6e Merge branch 'feature/LoadingOverlay-Text' into 'develop' 
Option to show text in the loading overlay screen

### Summary
Adding option to show text on loading overlay screen.

### JIRA Ticket
[ONEAPP-5807](https://onejira.verizon.com/browse/ONEAPP-5807)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1009
 2023-11-01 17:01:56 +00:00
Scott Pfeil
848defaf39 32 -> 16 horizontal margin 2023-11-01 12:33:03 -04:00
Krishna Kishore Bandaru
975882d47c addressed code review comments 2023-11-01 18:11:22 +05:30
Krishna Kishore Bandaru
34dcc80f67 Updated linkShowing logic for accessibility 2023-11-01 14:09:55 +05:30
Keerthy
96fa0bf314 Removed accessibilityElements to resolve focus stuck issue 2023-11-01 13:47:23 +05:30
Keerthy
fe40639a19 Merge branch 'develop' into bugfix/focusStuckIssue 2023-11-01 13:46:09 +05:30
Keerthy
733a0a1b94 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-11-01 11:33:29 +05:30
Keerthy
7b4dd51a74 Merge branch 'develop' into feature/accessibilityHandler 2023-11-01 11:32:50 +05:30
Keerthy
92b7c3ef36 foucs spelling mistake 2023-11-01 11:19:30 +05:30
Keerthy
24c684d64f Updated accessibilityBehavior 2023-11-01 00:06:41 +05:30
Sumanth Nadigadda
9be7fef53c Showing/Hiding the text while starting/pausing the loading overlay 2023-10-31 22:51:39 +05:30
Rajendran, Nandhini
4b9c386071 story: ONEAPP-5868 page control update 2023-10-31 15:30:39 +00:00
Sumanth Nadigadda
d057559353 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/LoadingOverlay-Text 2023-10-31 19:47:30 +05:30
Krishna Kishore Bandaru
3900294189 Merge branch 'develop' into feature/accessibilityHandler 2023-10-31 11:47:49 +05:30
Scott Pfeil
17a16bf73c change encode 2023-10-30 12:47:53 -04:00
Scott Pfeil
49d6d2bf76 bugfix for old color properties 2023-10-30 12:45:12 -04:00
Keerthy
6ad71383f4 Merge branch 'feature/accessibilityHandler' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/accessibilityHandler 2023-10-30 13:55:24 +05:30
Keerthy
e48db9495d Minor refactoring 2023-10-30 13:54:48 +05:30
Krishna Kishore Bandaru
92b7055096 Merge branch 'develop' into feature/accessibilityHandler 2023-10-27 18:51:30 +05:30
Hedden, Kyle Matthew
1eb0103744 fix stack overflow error on RawRepresentable encoding 2023-10-26 16:39:30 -04:00
Keerthy
8f002f9422 Merge branch 'develop' into feature/accessibilityHandler 2023-10-26 23:48:37 +05:30
Keerthy
0f2f00f6d4 Merge branch 'develop' into bugfix/PRODDEF-1289_accessibilityChanges 2023-10-26 23:34:26 +05:30
Bruce, Matt R
58afcc596d Merge branch 'feature/ListStoreLocatorMoleculeEnhancement' into 'develop' 
ListStoreLocator component enhancement

### Summary
We have got confirmation from businesses to use the existing listStoreLocator molecule instead of having a new one created.
Updated heart with badge as per the new design.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-5098

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1012
 2023-10-26 16:42:53 +00:00
Pfeil, Scott Robert
025667f856 Merge branch 'feature/atomic_vds_badge' into 'develop' 
Introduced the VDS Badge into Atomic

Co-authored-by: Bruce, Matt R <matt.bruce@one.verizon.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>
Co-authored-by: Rebecca Antonelli <rebecca.antonelli@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1013
 2023-10-26 16:39:52 +00:00