Commit Graph

5495 Commits

Author SHA1 Message Date
vimal
0f56803a5d review comment update, updated the function name 2024-02-21 19:37:44 +05:30
Hedden, Kyle Matthew
f853275005 Add missing Label image attachment color tinting. 2024-02-19 21:22:57 -05:00
Hedden, Kyle Matthew
ef0f47cbc4 Merge remote-tracking branch 'refs/remotes/origin/develop' 2024-02-15 22:33:21 -05:00
Hedden, Kyle Matthew
22ad11840a Open poller to any action. Drop the fallback response as it will be taken care of by openPage handler. 2024-02-15 21:16:12 -05:00
vimal
adc15bd6d8 review comment updated 2024-02-15 19:30:15 +05:30
Hedden, Kyle Matthew
3057226a75 Code Review. Embracing the implicit nature of Swift (?) and preventing a change highlight. 2024-02-12 11:08:22 -05:00
Hedden, Kyle Matthew
3eaf765655 Merge branch 'bugfix/tabs-selectedIndex' into 'develop'
added override to set model in the selectedIndex property

ViewModels selectedIndex wasn't set on a change event or a manual change for the object.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1054
2024-02-09 17:01:57 +00:00
Matt Bruce
b267e196fd added override to set model selectedIndex
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-09 10:00:00 -06:00
Hedden, Kyle Matthew
9c848e610c Hold onto selected tab index in the view model. 2024-02-09 09:59:44 -06:00
Hedden, Kyle Matthew
1d4294803a Remove the duplicate load gif. Rely on the defaultCompletionBlock. 2024-02-08 21:03:19 -05:00
Hedden, Kyle Matthew
f4cb350a95 Hold onto selected tab index in the view model. 2024-02-08 19:58:55 -05:00
Hedden, Kyle Matthew
fd4c634c74 Merge remote-tracking branch 'refs/remotes/origin/develop'
Conflicts:
	MVMCoreUI.xcodeproj/project.pbxproj
2024-02-08 16:38:33 -05:00
Hedden, Kyle Matthew
7a1ef28b1c PageBehaviorContainerModelProtocol spelling fix. 2024-02-08 14:14:40 -05:00
Bruce, Matt R
a8f8ff6424 Merge branch 'release/11_2_0' into 'develop'
release/11_2_0 hotfix merge

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>
Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1051
2024-02-08 16:55:13 +00:00
Hedden, Kyle Matthew
6e96976a55 Merge branch 'bugfix/CXTDT-459435' into 'release/11_2_0'
bugfix - Removing titleLabel from accessible elements

### Summary
Removing titleLabel from accessible elements in TextEntryField molecule, as the title's text is set as the textfields accessibilityLabel, thus reading the same title twice.


### JIRA Ticket
CXTDT-459435

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1052
2024-02-02 19:59:39 +00:00
Pfeil, Scott Robert
eaea903a17 Merge branch 'feature/vds_batch_two' into 'release/11_2_0'
Merge VDS Batch 2

### Summary
Merge VDS Batch 2

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1053
2024-02-02 19:54:11 +00:00
Sumanth Nadigadda
4634cff455 bugfix: CXTDT-459435 - Removing titleLabel from accessible elements, as the title's text is set as the textfields accessibilityLabel. 2024-02-02 17:26:23 +05:30
Matt Bruce
9a03c84131 Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-02-01 16:49:18 -06:00
Matt Bruce
0a291491eb fixed constraint
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 16:49:02 -06:00
Matt Bruce
21afbb55cd Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-02-01 16:30:42 -06:00
Matt Bruce
cc85cfac79 updated for the notes scott left
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 16:30:22 -06:00
Matt Bruce
548bb364f3 updated type
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:50:38 -06:00
Matt Bruce
cf0d42b908 added negative for trailing
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:49:48 -06:00
Matt Bruce
eb2d660760 added a wrapper view for tabs along with constraints so that we can expand and collapse margins based on the tabs configuration
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-02-01 14:28:01 -06:00
Matt Bruce
89daf16d29 Merge branch 'feature/atomic_vds_tabs' into feature/vds_batch_two 2024-01-30 11:35:06 -06:00
Matt Bruce
d56f34258d added var to determine fillContainer
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-30 11:31:18 -06:00
Matt Bruce
7469a5249f added fillContainer to model/view
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-30 11:31:06 -06:00
Matt Bruce
e7b9702fd2 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_tabs 2024-01-30 11:30:40 -06:00
Matt Bruce
b8c929e3df Merge branch 'feature/atomic_vds_loader' into feature/vds_batch_two 2024-01-29 15:31:37 -06:00
Matt Bruce
87a8051bbe Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-29 15:31:29 -06:00
Matt Bruce
e9b2a62bc9 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_loader 2024-01-29 15:29:01 -06:00
Matt Bruce
ce66b2466e check to ensure this hasn't been created.
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:28:02 -06:00
Matt Bruce
8201b8fad4 fixed bug
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:27:52 -06:00
Matt Bruce
a81ff55e6e updated to not return hardcoded value
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:25:34 -06:00
Matt Bruce
9dc77bd1ed updated reset
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:21:47 -06:00
Matt Bruce
3f7fd100f9 percentage doesn't matter for Links, only matters for pillbuttons
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:20:18 -06:00
Matt Bruce
9db98a2078 added else
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 15:15:19 -06:00
Matt Bruce
59175c45fc added previousModel
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 14:16:27 -06:00
Matt Bruce
fbcf881535 added nameForReuse check
refactored buttons to either create or set

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 13:16:37 -06:00
Matt Bruce
315a96470b added ParentMoleculeModelProtocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 13:16:07 -06:00
Matt Bruce
38907c7ac1 updating the model to set the TwoButtonModel to fillContainer if needed
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:59:25 -06:00
Matt Bruce
d81daf1df3 not resetting if the current count is correct
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:55 -06:00
Matt Bruce
1932fd7231 fixed bug for removing old references in array
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:23 -06:00
Matt Bruce
f99d4e3c4d added fillContainer: Bool to deal with updating if the buttonGroup fills or not
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:58:07 -06:00
Matt Bruce
cdc8b7310d added ParewntMoleculeModelProtocol
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
2024-01-29 12:57:32 -06:00
Matt Bruce
a3f940f1cc Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-26 09:17:50 -06:00
Matt Bruce
fb459cfdd5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/atomic_vds_buttonGroup 2024-01-26 09:17:19 -06:00
Hedden, Kyle Matthew
baca0d8031 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-25 17:05:03 -05:00
Pfeil, Scott Robert
c0d4db39ca Merge branch 'bugfix/GYNVB-1160' into 'develop'
Bugfix/gynvb 1160

### Summary
Prod_iOS_Eagle_AR Tool overview screen - missing menu icon.

### JIRA Ticket
https://onejira.verizon.com/browse/GYNVB-1160

Co-authored-by: Rajesh Pullagalla <rajesh.pullagalla1@verizonwireless.com>
Co-authored-by: Sureshkumar Ramachandran <sureshkumar.ramachandran@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1036
2024-01-25 20:59:05 +00:00
Matt Bruce
5164a91ad6 Merge branch 'feature/atomic_vds_buttonGroup' into feature/vds_batch_two 2024-01-25 13:36:38 -06:00