mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,090 Commits 64 Branches 0 Tags 46 MiB
develop
Commit Graph

6090 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pfeil, Scott Robert
beec8fd8d3 Merge branch 'bugfix/logging_handler_fixes' into 'develop' 
Remove unused stub.

### Summary
Remove unused logging handler stub which creates the wrong subclassing impression.

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1039
 2023-12-21 19:33:45 +00:00
Hedden, Kyle Matthew
72358966bc Remove unused stub. 2023-12-21 12:32:08 -05:00
Hedden, Kyle Matthew
dc622b2f80 Merge branch 'feature/oneApp_4156-LoggingHandlerSwiftMigration' into 'develop' 
story: ONEAPP-4156 LoggingHandler Swift migration

### Summary
Swiftify logging handler

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4156

Co-authored-by: Nandhini Rajendran <nandhini.rajendran@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1015
 2023-12-21 16:28:22 +00:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Hedden, Kyle Matthew
4f586ced89 Animate GIFs. 2023-12-20 19:16:22 -05:00
Hedden, Kyle Matthew
b681f331ba Fix data desync on update. 2023-12-19 12:42:11 -05:00
Hedden, Kyle Matthew
2857b1cd55 Stop closure efficiency. 2023-12-18 17:22:40 -05:00
Hedden, Kyle Matthew
df32a51395 Fix first time carousel replacement. 2023-12-18 17:19:52 -05:00
Matt Bruce
83b2cb80ad refactored two link view 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-15 16:17:36 -06:00
Matt Bruce
e1b6d82007 Merge branch 'develop' into feature/twobuttonview_vds_buttongroup 2023-12-15 15:06:26 -06:00
Rajesh Pullagalla
4dab03c8ec Merge remote-tracking branch 'origin/develop' into bugfix/GYNVB-1160 2023-12-15 10:48:02 -05:00
Pfeil, Scott Robert
0066827c5d Merge branch 'feature/ONEAPP-6089' into 'develop' 
Text field Spanish localization for optional

### Summary
Update privacy strings for App Clip Spanish support.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6089

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1037
 2023-12-14 23:10:32 +00:00
Matt Bruce
51f9f2eba2 registered view 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:31 -06:00
Matt Bruce
61cb8b300b added tooltip view and model 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:24 -06:00
Matt Bruce
c191066523 added enum codables for tooltip 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 16:04:08 -06:00
Matt Bruce
c25c3ec9ab added initial cut for icon, iconModel and registered it within the system. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:13:08 -06:00
Matt Bruce
d92973dc55 updated decoder to look for VDS Color name as well as hex 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:12:38 -06:00
Matt Bruce
6c3092a1f6 added more codables and default codable property wrappers 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-14 15:12:16 -06:00
Matt Bruce
86b835fc60 fixed bug 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-13 15:43:40 -06:00
Matt Bruce
55b6b491af initial cut for TitleLockup and model 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-13 15:28:58 -06:00
Matt Bruce
6e74c5e9b3 added enum codable 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-13 15:07:52 -06:00
Matt Bruce
71e291ccb5 updated api 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-13 14:39:01 -06:00
Matt Bruce
7baa6d31a0 pointed to new property 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:20:06 -06:00
Matt Bruce
49a385c12a removed legacy properties 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:49 -06:00
Matt Bruce
18372f9ed6 fixed bug 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:29 -06:00
Matt Bruce
7c0e8bb106 updated tabsModel and Tabs 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:19:00 -06:00
Matt Bruce
8a90a8ce4a added new codable from vds 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-11 14:18:44 -06:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
vimal
0ecfef39cd review comment updated. setting the height from model if not exist then hard coded value 2023-12-11 13:46:41 +05:30
Sureshkumar Ramachandran
fed4413606 To avoid display on the hamberg menu at discover screen(Homescreen) 2023-12-08 17:33:44 +05:30
Sureshkumar Ramachandran
9f2a1cb6d1 Hamberg menu fix 2023-12-08 14:42:50 +05:30
Matt Bruce
6a8e45fc9e initial cut for VDS Loader 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-06 14:39:46 -06:00
Matt Bruce
cf0e3086cf added accessibilityText 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-05 15:46:34 -06:00
Matt Bruce
938a5d1192 first cut for the conversion 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2023-12-05 15:46:22 -06:00
Hedden, Kyle Matthew
b8cefeb7e5 fix post merge file reference 2023-12-05 15:56:03 -05:00
Hedden, Kyle Matthew
ac88b5d2b1 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-12-05 14:39:29 -05:00
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop' 
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
 2023-12-05 14:42:29 +00:00
Hedden, Kyle Matthew
aba99b887b Merge branch 'revert-9c75add4' into 'develop' 
Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'"

### Summary
Reverting changes done for scrubber update as the requirement is no longer valid.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5868

Co-authored-by: Rajendran, Nandhini <nandhini.rajendran@one.verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1034
 2023-12-04 15:29:33 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'" 
This reverts merge request !1010
 2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
e48867446c Merge branch 'bugfix/tabbar_index_crash_fix' into 'release/11_1_4' 
Bugfix/tabbar index crash fix

### Summary
Top crash prevention when the web bridge gives an invalid tab index.

### Crash Signature
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/d55575695f799d0b41da74b063331db6?time=last-seven-days&types=crash&sessionEventKey=85086f6b016242f0b3ef04b40d6e46a6_1886152816176443688

```
Crashed: com.apple.main-thread
0  MVMCoreUI                      0x38ed04 TabBar.highlightTab(at:) + 90 (TabBar.swift:90)
1  MVMCoreUI                      0x38ed34 @objc TabBar.highlightTab(at:) + 7800 (<compiler-generated>:7800)
2  MobileFirstFramework           0x48fb94 MVMCoreViewControllerProtocol<>.update(_:) + 57 (WebviewBridgeWebPageLoaded.swift:57)
3  MobileFirstFramework           0x954288 (1) suspend resume partial function for closure #1 in WebViewBridgeUpdateTabBar.performBridgeAction(with:viewController:completionHandler:) + 20 (WebViewBridgeUpdateTabBar.swift:20)
```

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1033
 2023-12-01 19:35:36 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Pfeil, Scott Robert
547c3ad2a4 Merge branch 'bugfix/CXTDT-459511' into 'release/11_1_4' 
Setting accessibility label if available before text for eyebrow, headline,...

### Summary
Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label

### JIRA Ticket
[CXTDT-459511](https://onejira.verizon.com/browse/CXTDT-459511)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>
Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1031
 2023-12-01 16:13:26 +00:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30
Hedden, Kyle Matthew
3e5d4fe71f Merge branch 'release/11_1_2' into 'develop' 
release/11_1_2 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1028
 2023-11-27 15:10:51 +00:00
Keerthy
d65df06934 Updated textView to have label text for accessibility behavior 2023-11-22 18:07:13 +05:30
Hedden, Kyle Matthew
fca60ace66 switch to manual runner 2023-11-15 18:10:24 -05:00
Hedden, Kyle Matthew
47050e3c03 remove gitlab stages to disable 2023-11-15 18:02:50 -05:00
Pfeil, Scott Robert
440380f4d3 Merge branch 'hotfix/tabbar_block_crash' into 'release/11_1_1' 
Move hightlightTab to @MainActor to prevent block crash.

### Summary
Prevent block crash on highlight tab.

### Crash Details
https://console.firebase.google.com/project/api-project-396418606732/crashlytics/app/ios:com.vzw.hss.myverizon/issues/18516b87c36a9806e850dcac71748655?time=last-seven-days&types=crash&versions=11.1.0%20(20909.0)&sessionEventKey=bdace1e1ffa74d9b84e2afb63a98eaaf_1880252739825018670
```
0  MVMCoreUI                      0x38ad1c closure #1 in TabBar.highlightTab(at:) + 7776
1  MVMCoreUI                      0x312e8 thunk for @escaping @callee_guaranteed () -> () + 4140 (<compiler-generated>:4140)
2  MVMCore                        0xdc54 +[MVMCoreDispatchUtility performBlockOnMainThread:] + 15 (MVMCoreDispatchUtility.m:15)
3  MVMCoreUI                      0x38afe4 @objc TabBar.highlightTab(at:) + 8488
4  MobileFirstFramework           0x48f99c MVMCoreViewControllerProtocol.update(_:) + 56 (WebviewBridgeWebPageLoaded.swift:56)
```

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1026
 2023-11-15 22:33:13 +00:00