mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,573 Commits 64 Branches 0 Tags 46 MiB
bugfix/atomic-label-range
Commit Graph

5573 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matt Bruce
5b4358e9e9 ensuring the range passed in is valid. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-20 15:23:34 -05:00
Pfeil, Scott Robert
b021e14030 Merge branch 'revert-51315abf' into 'release/11_4_0' 
Revert "Merge branch 'bugfix/PRODDEF-24073' into 'release/11_4_0'"

### Summary
Revert another miss merge.

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1076
 2024-03-15 21:09:25 +00:00
Pfeil, Scott Robert
e1f248875e Revert "Merge branch 'bugfix/PRODDEF-24073' into 'release/11_4_0'" 
This reverts merge request !1062
 2024-03-15 21:08:11 +00:00
Pfeil, Scott Robert
51315abf49 Merge branch 'bugfix/PRODDEF-24073' into 'release/11_4_0' 
Added customActions to checkBoxLabel

### Summary
CheckBoxLabel will be receiving the single focus with no clause. Implemented customActions for the label embedded with actions.

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-24073

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1062
 2024-03-15 21:07:37 +00:00
Pfeil, Scott Robert
59ea9ca2bd Merge branch 'bugfix/CXTDT-531370' into 'release/11_4_0' 
doing extra guards for actionMap and actionText range to ensure a valid...

### Summary
nil ActionMap being sent to the Label which caused a range issue. Guards were put in place to ensure this can't happen. 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-531370

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1075
 2024-03-15 20:49:57 +00:00
Matt Bruce
3219d9f351 doing extra guards for actionMap and actionText range to ensure a valid ActionLabelAttribute gets created. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-15 14:35:23 -05:00
Keerthy
6ab685d906 Merge branch 'develop' into bugfix/PRODDEF-24073 2024-03-15 22:43:39 +05:30
Pfeil, Scott Robert
869804cc39 Merge branch 'bugfix/atomic_vds_label-fontSize' into 'develop' 
added the fontSize as a last resort for vars being set in the Label after fontStyle and fontName.

### Summary
Since moving to the new Typography system, we no longer should be accepting fontName/fontSize since you will lose all of the lineHeight/letterSpacing and other special formatting. 

I added a use-case for when there is only a fontSize given.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-533868

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1074
 2024-03-14 19:59:03 +00:00
Matt Bruce
09081b8bc8 added the fontSize as a last resort for vars being set in the Label after fontStyle and fontName. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-14 14:31:57 -05:00
Pfeil, Scott Robert
2505559444 Merge branch 'feature/vds_header_mapping' into 'develop' 
Digital PCT265 story ONEAPP-6389 - Button group size updates, title lockup...

### Summary
Sizing fixes for templates when using button group and font updates.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6389

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1073
 2024-03-14 14:26:30 +00:00
Pfeil, Scott Robert
37fadb9a29 Merge branch 'revert-8f166223' into 'release/11_4_0' 
Revert "Merge branch 'feature/vds_header_mapping' into 'release/11_4_0'"

### Summary
Reverting mistaken merge

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1072
 2024-03-14 14:16:15 +00:00
Pfeil, Scott Robert
054a70d41b Revert "Merge branch 'feature/vds_header_mapping' into 'release/11_4_0'" 
This reverts merge request !1071
 2024-03-14 14:14:49 +00:00
Pfeil, Scott Robert
8f166223d0 Merge branch 'feature/vds_header_mapping' into 'release/11_4_0' 
Sizing fixes and font updates

### Summary
Sizing fixes for templates when using button group and font updates.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6389

Co-authored-by: Scott Pfeil <Scott.Pfeil3@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1071
 2024-03-13 17:47:56 +00:00
Pfeil, Scott Robert
a46f52e87b Merge branch 'release/11_4_0' into 'develop' 
release/11_4_0 hotfix merge

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>
Co-authored-by: Matt Bruce <matt.bruce@verizon.com>
Co-authored-by: Bruce, Matt R <matt.bruce@one.verizon.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1063
 2024-03-13 17:36:09 +00:00
Hedden, Kyle Matthew
91423f87f4 Merge branch 'bugfix/CXTDT-530193' into 'release/11_4_0' 
CXTDT-530193

### Summary
footerless list template property handling.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-530193

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1070
 2024-03-12 21:03:07 +00:00
Scott Pfeil
47178a33d3 Digital PCT265 story ONEAPP-6389 - Update font style for item headers. 2024-03-12 15:48:03 -04:00
Scott Pfeil
25c8c139a0 Digital PCT265 story ONEAPP-6389 - update header H2 2024-03-12 15:41:49 -04:00
Scott Pfeil
5c414a0e40 Digital PCT265 story ONEAPP-6389 - Button group size updates, title lockup like views font updates, label font updates 2024-03-12 13:47:48 -04:00
Scott Pfeil
9b831bfa35 Merge branch 'release/11_4_0' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/vds_header_mapping 2024-03-12 11:03:02 -04:00
Hedden, Kyle Matthew
582cd33a1c footerlessSpacerHeight + footerlessSpacerColor to adjust footerless padding. 2024-03-11 19:35:45 -04:00
Pfeil, Scott Robert
b9675ce5f1 Merge branch 'bugfix/CXTDT-531163' into 'release/11_4_0' 
CXTDT-531163

### Summary
Fix the tab state on table scroll.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-531163

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1069
 2024-03-11 22:01:46 +00:00
Pfeil, Scott Robert
80f3524d43 Merge branch 'bugfix/11_4_0-buttonGroup' into 'release/11_4_0' 
added heightConstraint for the twobutton

### Summary
Issue with the height of the PrimaryButtonView. 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-514441
https://onejira.verizon.com/browse/CXTDT-521074

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1068
 2024-03-11 21:57:57 +00:00
Hedden, Kyle Matthew
8d57b0ae0e Remove 2-way binding on Tabs selected index to avoid applying 0 on view reset. 2024-03-11 17:46:13 -04:00
Matt Bruce
5ba1260383 updated to required 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-11 16:44:53 -05:00
Matt Bruce
bfe209305d added heightConstraint for the twobutton 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-11 15:36:40 -05:00
Pfeil, Scott Robert
1f2753e9d7 Merge branch 'bugfix/CXTDT-530193' into 'release/11_4_0' 
CXTDT-530193

### Summary
Hide and show the carousel pager based upon the content size.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-530193

Co-authored-by: Hedden, Kyle Matthew <kyle.hedden@verizonwireless.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1067
 2024-03-11 18:42:32 +00:00
Hedden, Kyle Matthew
19b4fb308c Code review -- Update of molecule layout change when pager is state changes. 2024-03-11 14:11:17 -04:00
Scott Pfeil
6e2d1d7132 Merge branch 'release/11_4_0' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/vds_header_mapping 2024-03-11 11:53:08 -04:00
Scott Pfeil
483454d094 Digital PCT265 story ONEAPP-4818 - Updating atomic headers to utilize vds title lockup 2024-03-11 11:52:37 -04:00
Hedden, Kyle Matthew
959bdce13f Code review. Include the only 1 element condition to the carousel pager logic. 2024-03-11 10:45:55 -04:00
Hedden, Kyle Matthew
f53847372a Merge branch 'bugfix/atomic_vds_label' into 'release/11_4_0' 
refactored atomic label

### Summary
There were some manual settings happening into the Atomic Label with font and textColor.  These changes were pushed down into VDS.Label to handle generically and there was some code that needed to be deleted due to this change.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4349

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1066
 2024-03-08 22:55:17 +00:00
Hedden, Kyle Matthew
73d13ba37b Pager should still hide on the empty condition. 2024-03-08 16:53:40 -05:00
Hedden, Kyle Matthew
2877534c70 Hide and show the carousel pager based upon the content size. 2024-03-08 16:45:11 -05:00
Matt Bruce
b638637af7 removed code and call the code that does the same thing under the hood. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-08 14:20:44 -06:00
Matt Bruce
dcb5b91e32 deleted method and refactored atomic label even more 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-08 14:03:05 -06:00
Bruce, Matt R
f0d9664d16 Merge branch 'bugfix/CXTDT-530449' into 'release/11_4_0' 
ecoding & decoding fillContainer param in TwoButtonView molecule

### Summary
ecoding & decoding fillContainer param in TwoButtonView molecule, so json can control to fill the buttonView

### JIRA Ticket
[CXTDT-530449](https://onejira.verizon.com/browse/CXTDT-530449)
[CXTDT-530454](https://onejira.verizon.com/browse/CXTDT-530454)
[CXTDT-530459](https://onejira.verizon.com/browse/CXTDT-530459)

Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1065
 2024-03-08 14:31:27 +00:00
Sumanth Nadigadda
deac7b37f0 ecoding & decoding fillContainer param in TwoButtonView molecule 2024-03-08 18:05:23 +05:30
Pfeil, Scott Robert
d31b9f7880 Merge branch 'bugfix/label-textColor-setter' into 'release/11_4_0' 
fixed issue where users set the textColor property directly

I forgot to override the textColor in the Label, therefore, the color wasn't being used. 

No bug as of yet, but there will be before this gets pushed.

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1064
 2024-03-06 22:11:56 +00:00
Matt Bruce
5834b8fcd2 fixed issue where users set the textColor property directly 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-03-06 14:19:46 -06:00
Keerthy
d99a7ee546 Updated logic 
Updated access to children instead of parent
 2024-03-06 23:55:15 +05:30
Keerthy
5f15d630e1 Merge branch 'develop' into bugfix/PRODDEF-24073 2024-03-06 12:05:55 +05:30
Hedden, Kyle Matthew
aa6e55e55d Merge branch 'mvm_core_ui/feature/ONEAPP-6149' into 'develop' 
As Per Scott Comment Updated Key to hide chat icon as per legacy

### Summary
As Per Scott Comment Updated Key to hide chat icon as per legacy

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6149
https://www.figma.com/file/J7OTvY0Fe7gUQMZk13WYtZ/Prepaid-to-Postpaid-MVA-Experience?type=design&node-id=424-131359&mode=design&t=UVfHNEkYgDZoWpgx-0

Co-authored-by: Naresh <naresh.cherukuri@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1058
 2024-03-01 13:36:52 +00:00
Hedden, Kyle Matthew
0977794160 Merge branch 'feature/vds_batch_three' into 'develop' 
VDS Batch Three

### Summary
VDS Label / TitleLockup Integration 

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-4349
https://onejira.verizon.com/browse/ONEAPP-6241

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1059
 2024-02-29 19:59:19 +00:00
Naresh
335ca30c6f AddedeLeftAndRightPanelKeysToPageModel 
AddedeLeftAndRightPanelKeysToPageModel
 2024-02-29 22:36:52 +05:30
Matt Bruce
fb2a866f14 added depreciated coding keys 
also reverted to non-hard typed LabelModel as done previous.

Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-02-28 16:07:57 -06:00
Matt Bruce
995bec6cb2 refactored out mapped and inserted within the only function that calls it. 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
 2024-02-28 15:32:00 -06:00
Naresh
99e3d43376 Merge branch 'develop' into mvm_core_ui/feature/ONEAPP-6149 2024-02-28 12:52:22 +05:30
Naresh
a21bf23d44 AddedLeftPanelAndRightPanelInBaseTemplateModel 
AddedLeftPanelAndRightPanelInBaseTemplateModel
 2024-02-28 11:25:55 +05:30
Naresh
5537961ddf UpdatedKeyToHideRightPanel 
UpdatedKeyToHideRightPanel
 2024-02-28 10:19:51 +05:30
Matt Bruce
54c431534b Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui.git into feature/vds_batch_three 2024-02-26 13:19:20 -06:00