code review
This commit is contained in:
parent
08c83872d5
commit
a50e3346e7
@ -43,7 +43,7 @@ public class RuleAnyRequiredModel: RulesProtocol {
|
|||||||
guard let formField = fieldMolecules[formKey] else { continue }
|
guard let formField = fieldMolecules[formKey] else { continue }
|
||||||
|
|
||||||
var fieldValidity = isValid(formField)
|
var fieldValidity = isValid(formField)
|
||||||
// If past rule is invalid forr a field, the current rule should not flip the validity of a field
|
// If past rule is invalid for a field, the current rule should not flip the validity of a field
|
||||||
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
||||||
fieldValidity = false
|
fieldValidity = false
|
||||||
}
|
}
|
||||||
|
|||||||
@ -45,7 +45,7 @@ public class RuleEqualsIgnoreCaseModel: RulesProtocol {
|
|||||||
valid = true
|
valid = true
|
||||||
|
|
||||||
var fieldValidity = valid
|
var fieldValidity = valid
|
||||||
// If past rule is invalid forr a field, the current rule should not flip the validity of a field
|
// If past rule is invalid for a field, the current rule should not flip the validity of a field
|
||||||
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
||||||
fieldValidity = false
|
fieldValidity = false
|
||||||
}
|
}
|
||||||
|
|||||||
@ -47,7 +47,7 @@ public class RuleEqualsModel: RulesProtocol {
|
|||||||
break
|
break
|
||||||
} else {
|
} else {
|
||||||
var fieldValidity = valid
|
var fieldValidity = valid
|
||||||
// If past rule is invalid forr a field, the current rule should not flip the validity of a field
|
// If past rule is invalid for a field, the current rule should not flip the validity of a field
|
||||||
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
if let validity = previousFieldValidity[formKey], !validity, fieldValidity {
|
||||||
fieldValidity = false
|
fieldValidity = false
|
||||||
}
|
}
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user