From a50e3346e7220099d456dd34da8e62be8ef06038 Mon Sep 17 00:00:00 2001 From: "Suresh, Kamlesh" Date: Thu, 8 Apr 2021 15:34:21 -0400 Subject: [PATCH] code review --- MVMCoreUI/FormUIHelpers/Rules/Rules/RuleAnyRequiredModel.swift | 2 +- .../FormUIHelpers/Rules/Rules/RuleEqualsIgnoreCaseModel.swift | 2 +- MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsModel.swift | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleAnyRequiredModel.swift b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleAnyRequiredModel.swift index 0df84c4a..3a9b3871 100644 --- a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleAnyRequiredModel.swift +++ b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleAnyRequiredModel.swift @@ -43,7 +43,7 @@ public class RuleAnyRequiredModel: RulesProtocol { guard let formField = fieldMolecules[formKey] else { continue } var fieldValidity = isValid(formField) - // If past rule is invalid forr a field, the current rule should not flip the validity of a field + // If past rule is invalid for a field, the current rule should not flip the validity of a field if let validity = previousFieldValidity[formKey], !validity, fieldValidity { fieldValidity = false } diff --git a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsIgnoreCaseModel.swift b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsIgnoreCaseModel.swift index ee165b9a..8326cf4f 100644 --- a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsIgnoreCaseModel.swift +++ b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsIgnoreCaseModel.swift @@ -45,7 +45,7 @@ public class RuleEqualsIgnoreCaseModel: RulesProtocol { valid = true var fieldValidity = valid - // If past rule is invalid forr a field, the current rule should not flip the validity of a field + // If past rule is invalid for a field, the current rule should not flip the validity of a field if let validity = previousFieldValidity[formKey], !validity, fieldValidity { fieldValidity = false } diff --git a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsModel.swift b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsModel.swift index 7a8c25e4..a405e2e7 100644 --- a/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsModel.swift +++ b/MVMCoreUI/FormUIHelpers/Rules/Rules/RuleEqualsModel.swift @@ -47,7 +47,7 @@ public class RuleEqualsModel: RulesProtocol { break } else { var fieldValidity = valid - // If past rule is invalid forr a field, the current rule should not flip the validity of a field + // If past rule is invalid for a field, the current rule should not flip the validity of a field if let validity = previousFieldValidity[formKey], !validity, fieldValidity { fieldValidity = false }