mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PR Review comments fixed

Browse Source
This commit is contained in:
Danish Phiroz 2024-09-12 15:21:08 -05:00
parent f74d42f8bb
commit 91d5f5ae0d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
MVMCoreUI/BaseControllers/ViewController.swift
View File

@ -175,7 +175,7 @@ import Combine
// Log all parsing errors and fail load. // Log all parsing errors and fail load.
if let errorObject = MVMCoreLoadHandler.sharedGlobal()?.error(for: loadObject, causedBy: parsingError) { if let errorObject = MVMCoreLoadHandler.sharedGlobal()?.error(for: loadObject, causedBy: parsingError) {
errorObject.messageToDisplay = MVMCoreGetterUtility.hardcodedString(withKey: HardcodedErrorUnableToProcess) errorObject.messageToDisplay = MVMCoreGetterUtility.hardcodedString(withKey: HardcodedErrorUnableToProcess)
errorObject.messageToLog = describe(parsingError: parsingError, template: loadObject.pageType) errorObject.messageToLog = describe(parsingError: parsingError, template: loadObject.pageJSON?["template"] as? String, pageType: loadObject.pageType)
error.pointee = errorObject error.pointee = errorObject
} }
return false return false
@ -203,11 +203,11 @@ import Combine
return true return true
} }
func describe(parsingError: Error, template: String?) -> String { func describe(parsingError: Error, template: String?, pageType: String?) -> String {
if let error = parsingError as? HumanReadableDecodingErrorProtocol { if let error = parsingError as? HumanReadableDecodingErrorProtocol {
return "Error parsing \(template ?? "") template. \(error.readableDescription)" return "Error parsing: \"\(template ?? "NA")\" template in pageType \"\(pageType ?? "NA")\". \(error.readableDescription)"
} }
return "Error parsing \(template ?? "") template. \((parsingError as NSError).localizedFailureReason ?? parsingError.localizedDescription)" return "Error parsing: \(template ?? "") template. \((parsingError as NSError).localizedFailureReason ?? parsingError.localizedDescription)"
} }
open func parsePageJSON(loadObject: MVMCoreLoadObject) throws -> PageModelProtocol { open func parsePageJSON(loadObject: MVMCoreLoadObject) throws -> PageModelProtocol {