From 91d5f5ae0d6c9344e90286f9df64e6ec79e20809 Mon Sep 17 00:00:00 2001 From: Danish Phiroz Date: Thu, 12 Sep 2024 15:21:08 -0500 Subject: [PATCH] PR Review comments fixed --- MVMCoreUI/BaseControllers/ViewController.swift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MVMCoreUI/BaseControllers/ViewController.swift b/MVMCoreUI/BaseControllers/ViewController.swift index 2d1e380b..af7573aa 100644 --- a/MVMCoreUI/BaseControllers/ViewController.swift +++ b/MVMCoreUI/BaseControllers/ViewController.swift @@ -175,7 +175,7 @@ import Combine // Log all parsing errors and fail load. if let errorObject = MVMCoreLoadHandler.sharedGlobal()?.error(for: loadObject, causedBy: parsingError) { errorObject.messageToDisplay = MVMCoreGetterUtility.hardcodedString(withKey: HardcodedErrorUnableToProcess) - errorObject.messageToLog = describe(parsingError: parsingError, template: loadObject.pageType) + errorObject.messageToLog = describe(parsingError: parsingError, template: loadObject.pageJSON?["template"] as? String, pageType: loadObject.pageType) error.pointee = errorObject } return false @@ -203,11 +203,11 @@ import Combine return true } - func describe(parsingError: Error, template: String?) -> String { + func describe(parsingError: Error, template: String?, pageType: String?) -> String { if let error = parsingError as? HumanReadableDecodingErrorProtocol { - return "Error parsing \(template ?? "") template. \(error.readableDescription)" + return "Error parsing: \"\(template ?? "NA")\" template in pageType \"\(pageType ?? "NA")\". \(error.readableDescription)" } - return "Error parsing \(template ?? "") template. \((parsingError as NSError).localizedFailureReason ?? parsingError.localizedDescription)" + return "Error parsing: \(template ?? "") template. \((parsingError as NSError).localizedFailureReason ?? parsingError.localizedDescription)" } open func parsePageJSON(loadObject: MVMCoreLoadObject) throws -> PageModelProtocol {