mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

addressed review comments

Browse Source
This commit is contained in:
Krishna Kishore Bandaru 2023-04-18 18:01:57 +05:30
parent 8977840581
commit 85080bd15a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
MVMCoreUI/BaseControllers/ViewController.swift
View File

@ -197,8 +197,8 @@ import MVMCore
}
open func parsePageJSON() throws {
if let pageType, let identifier = loadObject?.identifier {
MVMCoreLoggingHandler.shared()?.logPageProcessingComplete(for: pageType, requestUUID: identifier, webUrl: loadObject?.pageJSON?.optionalStringForKey("browserUrl"))
if let backgroundRequest = loadObject?.requestParameters?.backgroundRequest, !backgroundRequest, let pageType, let identifier = loadObject?.identifier {
MVMCoreLoggingHandler.shared()?.logPageProcessingComplete(for: pageType, requestUUID: identifier, webUrl: nil)
}
}
@ -361,7 +361,7 @@ import MVMCore
behavior.onPageShown(self?.delegateObjectIVar)
}
if let pageType, let identifier = loadObject?.identifier {
if let backgroundRequest = loadObject?.requestParameters?.backgroundRequest, !backgroundRequest, let pageType, let identifier = loadObject?.identifier {
MVMCoreLoggingHandler.shared()?.logPageRenderComplete(for: pageType, requestUUID: identifier, templateName: loadObject?.pageJSON?.optionalStringForKey("template"), controllerName: "\(type(of: self))", error: loadObject?.responseInfoMap?.optionalStringForKey("message"))
}
}