From 85080bd15adcd37f60b97e5fa0017baf2af26c8e Mon Sep 17 00:00:00 2001 From: Krishna Kishore Bandaru Date: Tue, 18 Apr 2023 18:01:57 +0530 Subject: [PATCH] addressed review comments --- MVMCoreUI/BaseControllers/ViewController.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MVMCoreUI/BaseControllers/ViewController.swift b/MVMCoreUI/BaseControllers/ViewController.swift index e9987c5f..5501e6de 100644 --- a/MVMCoreUI/BaseControllers/ViewController.swift +++ b/MVMCoreUI/BaseControllers/ViewController.swift @@ -197,8 +197,8 @@ import MVMCore } open func parsePageJSON() throws { - if let pageType, let identifier = loadObject?.identifier { - MVMCoreLoggingHandler.shared()?.logPageProcessingComplete(for: pageType, requestUUID: identifier, webUrl: loadObject?.pageJSON?.optionalStringForKey("browserUrl")) + if let backgroundRequest = loadObject?.requestParameters?.backgroundRequest, !backgroundRequest, let pageType, let identifier = loadObject?.identifier { + MVMCoreLoggingHandler.shared()?.logPageProcessingComplete(for: pageType, requestUUID: identifier, webUrl: nil) } } @@ -361,7 +361,7 @@ import MVMCore behavior.onPageShown(self?.delegateObjectIVar) } - if let pageType, let identifier = loadObject?.identifier { + if let backgroundRequest = loadObject?.requestParameters?.backgroundRequest, !backgroundRequest, let pageType, let identifier = loadObject?.identifier { MVMCoreLoggingHandler.shared()?.logPageRenderComplete(for: pageType, requestUUID: identifier, templateName: loadObject?.pageJSON?.optionalStringForKey("template"), controllerName: "\(type(of: self))", error: loadObject?.responseInfoMap?.optionalStringForKey("message")) } }