mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

code review

Browse Source
This commit is contained in:
Suresh, Kamlesh 2021-01-21 13:27:25 -05:00
parent 4e1e563284
commit b00e9c4895
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
View File

@ -158,4 +158,6 @@ extern NSString * _Nonnull const KeyActionTypeOpen;
// By default, throws an error, calling defaultHandleActionError. // By default, throws an error, calling defaultHandleActionError.
+ (void)defaultHandleUnknownActionType:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegate:(nullable NSObject <MVMCoreActionDelegateProtocol>*)delegate __deprecated; + (void)defaultHandleUnknownActionType:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegate:(nullable NSObject <MVMCoreActionDelegateProtocol>*)delegate __deprecated;
// Iterates through the clientParameters list. Gets values from the individual handlers and attaches the parameters to extraParameters.
- (void)setClientParameter:(nullable NSDictionary *)actionInformation completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler;
@end @end

4
MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
View File

@ -566,7 +566,6 @@ NSString * const KeyActionTypeOpen = @"openPage";
[self setClientParameter:actionInformation completionHandler:performAction]; [self setClientParameter:actionInformation completionHandler:performAction];
} }
/// Iterates through the clientParameters list. Gets values from the individual handlers and attaches the parameters to extraParameters.
- (void)setClientParameter:(nullable NSDictionary *)actionInformation completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler { - (void)setClientParameter:(nullable NSDictionary *)actionInformation completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler {
NSDictionary *clientParametersMap = [actionInformation dict:KeyClientParameters]; NSDictionary *clientParametersMap = [actionInformation dict:KeyClientParameters];
@ -611,8 +610,7 @@ NSString * const KeyActionTypeOpen = @"openPage";
if (error) { if (error) {
stopLoadingOverlay(); stopLoadingOverlay();
completionHandler(actionInformation); completionHandler(actionInformation);
[MVMCoreLoggingHandler logDebugMessageWithDelegate:@"Error clientparameters"]; [MVMCoreLoggingHandler addErrorToLog:error];
[MVMCoreLoggingHandler logDebugMessageWithDelegate:error.debugDescription];
} }
} }