From b00e9c48950ef48b816a5dc99e7d8ae27a5da8ee Mon Sep 17 00:00:00 2001
From: "Suresh, Kamlesh" <kamlesh.suresh@verizonwireless.com>
Date: Thu, 21 Jan 2021 13:27:25 -0500
Subject: [PATCH] code review

---
 MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h | 2 ++
 MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m | 4 +---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
index c677e53..374b968 100644
--- a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
+++ b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
@@ -158,4 +158,6 @@ extern NSString * _Nonnull const KeyActionTypeOpen;
 // By default, throws an error, calling defaultHandleActionError.
 + (void)defaultHandleUnknownActionType:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegate:(nullable NSObject <MVMCoreActionDelegateProtocol>*)delegate __deprecated;
 
+//  Iterates through the clientParameters list. Gets values from the individual handlers and attaches the parameters to extraParameters.
+- (void)setClientParameter:(nullable NSDictionary *)actionInformation completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler;
 @end
diff --git a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
index 3b2d704..a717595 100644
--- a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
+++ b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
@@ -566,7 +566,6 @@ NSString * const KeyActionTypeOpen = @"openPage";
     [self setClientParameter:actionInformation completionHandler:performAction];
 }
 
-///  Iterates through the clientParameters list. Gets values from the individual handlers and attaches the parameters to extraParameters.
 - (void)setClientParameter:(nullable NSDictionary *)actionInformation completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler {
 
     NSDictionary *clientParametersMap = [actionInformation dict:KeyClientParameters];
@@ -611,8 +610,7 @@ NSString * const KeyActionTypeOpen = @"openPage";
     if (error) {
         stopLoadingOverlay();
         completionHandler(actionInformation);
-        [MVMCoreLoggingHandler logDebugMessageWithDelegate:@"Error clientparameters"];
-        [MVMCoreLoggingHandler logDebugMessageWithDelegate:error.debugDescription];
+        [MVMCoreLoggingHandler addErrorToLog:error];
     }
 }