TopDogLabs/SelfieCam
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused 'Front Flash' setting from UI

Browse Source 
- Setting was defined but never used in camera logic
- Flash Mode and Flash Sync settings handle all flash functionality
- Keep property in SyncedSettings for backwards compatibility with saved data
- Remove from SettingsView, SettingsViewModel, and RingLightConfigurable protocol
This commit is contained in:
Matt Bruce 2026-01-04 15:16:08 -06:00
parent b96fc63b7b
commit 77d9cf9584
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
SelfieCam/Features/Settings/SettingsView.swift
View File

@ -65,14 +65,6 @@ struct SettingsView: View {
accessibilityHint: String(localized: "Syncs flash color with ring light color") accessibilityHint: String(localized: "Syncs flash color with ring light color")
) )
// Front Flash
SettingsToggle(
title: String(localized: "Front Flash"),
subtitle: String(localized: "Hide preview during capture for flash effect"),
isOn: $viewModel.isFrontFlashEnabled
)
.accessibilityHint(String(localized: "Uses screen flash when taking front camera photos"))
// HDR Mode // HDR Mode
hdrModePicker hdrModePicker

6
SelfieCam/Features/Settings/SettingsViewModel.swift
View File

@ -178,12 +178,6 @@ final class SettingsViewModel: RingLightConfigurable {
} }
} }
/// Whether front flash is enabled (hides preview during capture)
var isFrontFlashEnabled: Bool {
get { cloudSync.data.isFrontFlashEnabled }
set { updateSettings { $0.isFrontFlashEnabled = newValue } }
}
/// Whether the camera preview is flipped to show a true mirror (PREMIUM) /// Whether the camera preview is flipped to show a true mirror (PREMIUM)
var isMirrorFlipped: Bool { var isMirrorFlipped: Bool {
get { PremiumGate.get(cloudSync.data.isMirrorFlipped, default: false, isPremium: isPremiumUnlocked) } get { PremiumGate.get(cloudSync.data.isMirrorFlipped, default: false, isPremium: isPremiumUnlocked) }

3
SelfieCam/Shared/Protocols/RingLightConfigurable.swift
View File

@ -11,9 +11,6 @@ protocol RingLightConfigurable {
/// The color of the ring light /// The color of the ring light
var lightColor: Color { get } var lightColor: Color { get }
/// Whether front flash is enabled (hides preview during capture)
var isFrontFlashEnabled: Bool { get set }
/// Whether the camera preview is mirrored /// Whether the camera preview is mirrored
var isMirrorFlipped: Bool { get set } var isMirrorFlipped: Bool { get set }