From 77d9cf95844f1acbd162d6622f26c9c4f5665bf0 Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Sun, 4 Jan 2026 15:16:08 -0600 Subject: [PATCH] Remove unused 'Front Flash' setting from UI - Setting was defined but never used in camera logic - Flash Mode and Flash Sync settings handle all flash functionality - Keep property in SyncedSettings for backwards compatibility with saved data - Remove from SettingsView, SettingsViewModel, and RingLightConfigurable protocol --- SelfieCam/Features/Settings/SettingsView.swift | 8 -------- SelfieCam/Features/Settings/SettingsViewModel.swift | 6 ------ SelfieCam/Shared/Protocols/RingLightConfigurable.swift | 3 --- 3 files changed, 17 deletions(-) diff --git a/SelfieCam/Features/Settings/SettingsView.swift b/SelfieCam/Features/Settings/SettingsView.swift index 99ecb91..25d4679 100644 --- a/SelfieCam/Features/Settings/SettingsView.swift +++ b/SelfieCam/Features/Settings/SettingsView.swift @@ -65,14 +65,6 @@ struct SettingsView: View { accessibilityHint: String(localized: "Syncs flash color with ring light color") ) - // Front Flash - SettingsToggle( - title: String(localized: "Front Flash"), - subtitle: String(localized: "Hide preview during capture for flash effect"), - isOn: $viewModel.isFrontFlashEnabled - ) - .accessibilityHint(String(localized: "Uses screen flash when taking front camera photos")) - // HDR Mode hdrModePicker diff --git a/SelfieCam/Features/Settings/SettingsViewModel.swift b/SelfieCam/Features/Settings/SettingsViewModel.swift index 37b4061..b400689 100644 --- a/SelfieCam/Features/Settings/SettingsViewModel.swift +++ b/SelfieCam/Features/Settings/SettingsViewModel.swift @@ -178,12 +178,6 @@ final class SettingsViewModel: RingLightConfigurable { } } - /// Whether front flash is enabled (hides preview during capture) - var isFrontFlashEnabled: Bool { - get { cloudSync.data.isFrontFlashEnabled } - set { updateSettings { $0.isFrontFlashEnabled = newValue } } - } - /// Whether the camera preview is flipped to show a true mirror (PREMIUM) var isMirrorFlipped: Bool { get { PremiumGate.get(cloudSync.data.isMirrorFlipped, default: false, isPremium: isPremiumUnlocked) } diff --git a/SelfieCam/Shared/Protocols/RingLightConfigurable.swift b/SelfieCam/Shared/Protocols/RingLightConfigurable.swift index c54e4ce..ee6be66 100644 --- a/SelfieCam/Shared/Protocols/RingLightConfigurable.swift +++ b/SelfieCam/Shared/Protocols/RingLightConfigurable.swift @@ -11,9 +11,6 @@ protocol RingLightConfigurable { /// The color of the ring light var lightColor: Color { get } - /// Whether front flash is enabled (hides preview during capture) - var isFrontFlashEnabled: Bool { get set } - /// Whether the camera preview is mirrored var isMirrorFlipped: Bool { get set }