mbrucedogs/vds_ios_sample
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed memory leak

Browse Source 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
This commit is contained in:
Matt Bruce 2022-08-15 09:03:35 -05:00
parent 1b4d40f67e
commit 92ccbbeceb
1 changed files with 41 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
VDSSample/ViewControllers/TestViewController.swift
View File

@ -11,13 +11,13 @@ import Combine
import VDS import VDS
struct User { struct User {
var firstName: String var firstName: String
var lastName: String var lastName: String
init(firstName: String, lastName: String) { init(firstName: String, lastName: String) {
self.firstName = firstName self.firstName = firstName
self.lastName = lastName self.lastName = lastName
} }
} }
public protocol Bindable { public protocol Bindable {
@ -34,6 +34,10 @@ extension Bindable {
} }
class TextFieldBindingCell: UIView, Bindable { class TextFieldBindingCell: UIView, Bindable {
deinit {
print("\(Self.self) deinit")
}
//bindable //bindable
var model: User var model: User
var subject: CurrentValueSubject<User, Never>? var subject: CurrentValueSubject<User, Never>?
@ -77,19 +81,21 @@ class TextFieldBindingCell: UIView, Bindable {
//add the logic //add the logic
let firstNameSubject = CurrentValueSubject<String, Never>(model.firstName) let firstNameSubject = CurrentValueSubject<String, Never>(model.firstName)
firstNameTextField.createBinding(with: firstNameSubject, storeIn: &subscriptions) firstNameTextField.createBinding(with: firstNameSubject, storeIn: &subscriptions)
firstNameSubject.assign(to: \.model.firstName, on: self).store(in: &subscriptions) firstNameSubject
firstNameSubject.sink {[weak self] value in .sink {[weak self] value in
self?.send() guard let self = self else { return }
}.store(in: &subscriptions) self.model.firstName = value
self.send()
}.store(in: &subscriptions)
let lastNameSubject = CurrentValueSubject<String, Never>(model.lastName) let lastNameSubject = CurrentValueSubject<String, Never>(model.lastName)
lastNameTextField.createBinding(with: lastNameSubject, storeIn: &subscriptions) lastNameTextField.createBinding(with: lastNameSubject, storeIn: &subscriptions)
lastNameSubject.assign(to: \.model.lastName, on: self).store(in: &subscriptions) lastNameSubject
lastNameSubject.sink {[weak self] value in .sink {[weak self] value in
guard let self = self else { return } guard let self = self else { return }
self.send() self.model.lastName = value
}.store(in: &subscriptions) self.send()
}.store(in: &subscriptions)
} }
} }
@ -111,7 +117,11 @@ class TextFieldBindingCell: UIView, Bindable {
view.backgroundColor = .white view.backgroundColor = .white
let subject = CurrentValueSubject<User, Never>(user) let subject = CurrentValueSubject<User, Never>(user)
subject.assign(to: \.user, on: self).store(in: &subscriptions) subject
.sink{ [weak self] updatedModel in
self?.user = updatedModel
}
.store(in: &subscriptions)
let nameTextField = TextFieldBindingCell(model: user) let nameTextField = TextFieldBindingCell(model: user)
nameTextField.createBinding(with: subject, storeIn: &subscriptions) nameTextField.createBinding(with: subject, storeIn: &subscriptions)
@ -151,7 +161,7 @@ extension UITextField {
} }
public func createBinding(with subject: CurrentValueSubject<String, Never>, public func createBinding(with subject: CurrentValueSubject<String, Never>,
storeIn subscriptions: inout Set<AnyCancellable>) { storeIn subscriptions: inout Set<AnyCancellable>) {
subject.sink { [weak self] (value) in subject.sink { [weak self] (value) in
if value != self?.text { if value != self?.text {