mbrucedogs/vds_ios
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor toggle with setDefaults

Browse Source 
Signed-off-by: Matt Bruce <matt.bruce@verizon.com>
This commit is contained in:
Matt Bruce 2024-08-09 16:45:18 -05:00
parent ac1957d1c3
commit fc7650f7d9
2 changed files with 26 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
VDS/Components/Toggle/Toggle.swift
View File

@ -158,11 +158,6 @@ open class Toggle: Control, Changeable, FormFieldable {
open override func setup() { open override func setup() {
super.setup() super.setup()
onClick = { [weak self] _ in
guard let self else { return }
toggle()
}
isAccessibilityElement = true isAccessibilityElement = true
if #available(iOS 17.0, *) { if #available(iOS 17.0, *) {
accessibilityTraits = .toggleButton accessibilityTraits = .toggleButton
@ -237,6 +232,16 @@ open class Toggle: Control, Changeable, FormFieldable {
label.trailingAnchor.constraint(equalTo: trailingAnchor) label.trailingAnchor.constraint(equalTo: trailingAnchor)
] ]
}
open override func setDefaults() {
super.setDefaults()
onClick = { [weak self] _ in
guard let self else { return }
toggle()
}
bridge_accessibilityValueBlock = { [weak self] in bridge_accessibilityValueBlock = { [weak self] in
guard let self else { return "" } guard let self else { return "" }
if showText { if showText {
@ -245,13 +250,7 @@ open class Toggle: Control, Changeable, FormFieldable {
return isSelected ? "On" : "Off" return isSelected ? "On" : "Off"
} }
} }
}
/// Resets to default settings.
open override func reset() {
super.reset()
shouldUpdateView = false
label.reset()
isEnabled = true isEnabled = true
isOn = false isOn = false
isAnimated = true isAnimated = true
@ -263,8 +262,12 @@ open class Toggle: Control, Changeable, FormFieldable {
textPosition = .left textPosition = .left
inputId = nil inputId = nil
onChange = nil onChange = nil
shouldUpdateView = true }
setNeedsUpdate()
/// Resets to default settings.
open override func reset() {
label.reset()
super.reset()
} }
/// Used to make changes to the View based off a change events or from local properties. /// Used to make changes to the View based off a change events or from local properties.

22
VDS/Components/Toggle/ToggleView.swift
View File

@ -109,11 +109,6 @@ open class ToggleView: Control, Changeable, FormFieldable {
open override func setup() { open override func setup() {
super.setup() super.setup()
onClick = { [weak self] _ in
guard let self else { return }
toggle()
}
isAccessibilityElement = true isAccessibilityElement = true
if #available(iOS 17.0, *) { if #available(iOS 17.0, *) {
accessibilityTraits = .toggleButton accessibilityTraits = .toggleButton
@ -154,20 +149,21 @@ open class ToggleView: Control, Changeable, FormFieldable {
accessibilityLabel = "Toggle" accessibilityLabel = "Toggle"
} }
/// Resets to default settings. open override func setDefaults() {
open override func reset() { super.setDefaults()
super.reset()
shouldUpdateView = false
isOn = false isOn = false
isAnimated = true isAnimated = true
inputId = nil inputId = nil
toggleView.backgroundColor = toggleColorConfiguration.getColor(self) toggleView.backgroundColor = toggleColorConfiguration.getColor(self)
knobView.backgroundColor = knobColorConfiguration.getColor(self) knobView.backgroundColor = knobColorConfiguration.getColor(self)
onChange = nil onChange = nil
shouldUpdateView = true
setNeedsUpdate() onClick = { [weak self] _ in
guard let self else { return }
toggle()
}
} }
/// Used to make changes to the View based off a change events or from local properties. /// Used to make changes to the View based off a change events or from local properties.
open override func updateView() { open override func updateView() {
super.updateView() super.updateView()