From 521ca10fbf2f02ef3772c187432e86edcaa7d25f Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Tue, 2 Jan 2024 08:39:51 -0600 Subject: [PATCH 1/3] ONEAPP-6239 - Loader doesn't cancel 60 second timer on deallocation. Signed-off-by: Matt Bruce --- VDS/Components/Loader/Loader.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/VDS/Components/Loader/Loader.swift b/VDS/Components/Loader/Loader.swift index f1f99cc9..234246b0 100644 --- a/VDS/Components/Loader/Loader.swift +++ b/VDS/Components/Loader/Loader.swift @@ -119,6 +119,10 @@ open class Loader: View { loadingTimer?.invalidate() loadingTimer = nil } + + deinit { + stopAnimating() + } } extension Icon.Name { From 76df83f4eaf822324080497a9b155401ac17b542 Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Tue, 2 Jan 2024 08:40:07 -0600 Subject: [PATCH 2/3] updated notes Signed-off-by: Matt Bruce --- VDS/SupportingFiles/ReleaseNotes.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/VDS/SupportingFiles/ReleaseNotes.txt b/VDS/SupportingFiles/ReleaseNotes.txt index 0a5a3694..1b5ac5f0 100644 --- a/VDS/SupportingFiles/ReleaseNotes.txt +++ b/VDS/SupportingFiles/ReleaseNotes.txt @@ -1,3 +1,7 @@ +1.0.50 +---------------- +- ONEAPP-6239 - Loader doesn't cancel 60 second timer on deallocation. + 1.0.49 ---------------- - ONEAPP-6239 - Loader Voice Over Fixes From 828ecd32c4d5eca346bebfac7155f7a314d11dd3 Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Tue, 2 Jan 2024 09:51:11 -0600 Subject: [PATCH 3/3] updated version Signed-off-by: Matt Bruce --- VDS.xcodeproj/project.pbxproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/VDS.xcodeproj/project.pbxproj b/VDS.xcodeproj/project.pbxproj index 2fa6d2c5..c4a29490 100644 --- a/VDS.xcodeproj/project.pbxproj +++ b/VDS.xcodeproj/project.pbxproj @@ -1233,7 +1233,7 @@ BUILD_LIBRARY_FOR_DISTRIBUTION = YES; CODE_SIGN_IDENTITY = ""; CODE_SIGN_STYLE = Automatic; - CURRENT_PROJECT_VERSION = 49; + CURRENT_PROJECT_VERSION = 50; DEFINES_MODULE = YES; DEVELOPMENT_TEAM = ""; DYLIB_COMPATIBILITY_VERSION = 1; @@ -1270,7 +1270,7 @@ BUILD_LIBRARY_FOR_DISTRIBUTION = YES; CODE_SIGN_IDENTITY = ""; CODE_SIGN_STYLE = Automatic; - CURRENT_PROJECT_VERSION = 49; + CURRENT_PROJECT_VERSION = 50; DEFINES_MODULE = YES; DEVELOPMENT_TEAM = ""; DYLIB_COMPATIBILITY_VERSION = 1;