Commit Graph

1081 Commits

Author SHA1 Message Date
Murugan, Vimal
709277362f updated constraints 2020-01-03 20:20:23 +05:30
Murugan, Vimal
dd49c43946 code cleanup 2020-01-03 20:18:30 +05:30
Khan, Arshad
c4fbf57890 MOBFIRST-19249 : List Item Style Updates
Adding shortDivider and tallDivider style.
Removing header style.
2020-01-03 19:52:10 +05:30
Murugan, Vimal
e5ca7b5c9e bullet list molecule added 2020-01-02 21:33:31 +05:30
Murugan, Vimal
ccc535360c protocol implementation 2019-12-27 13:02:13 +05:30
Murugan, Vimal
1d843ae29a main thread update
access modifier update
2019-12-26 19:33:37 +05:30
Kevin G Christiano
fbc6e83038 Created Protocol to centralize tap detection logic. 2019-12-20 13:27:22 -05:00
Kevin G Christiano
d2162cb9b6 removed override to conform. 2019-12-20 08:43:13 -05:00
Kevin G Christiano
cf41609210 correcting alignment func. 2019-12-19 16:09:41 -05:00
Kevin G Christiano
a04399516d Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Views/Checkbox.swift
2019-12-19 15:32:57 -05:00
Kevin G Christiano
3b59e03695 Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Buttons/CaretButton.swift
#	MVMCoreUI/Molecules/Items/MoleculeTableViewCell.swift
2019-12-19 15:11:48 -05:00
Robinson, Blake
e11f64f0a4 Changed to optionalStringForKey 2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375 Used guard instead of if let because some code after the if let was removed 2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9 Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton. 2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab Removes self where unnecessary 2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57 Changed to MVMCoreUIUtility.getWidth() as per pr comments 2019-12-19 12:23:01 -05:00
Kevin G Christiano
f56b08fa0c Merge branch 'develop' into feature/checkboxView_constraints
# Conflicts:
#	MVMCoreUI/Atoms/Views/CheckboxWithLabelView.swift
2019-12-19 11:21:44 -05:00
Kevin G Christiano
6c9fede0b9 improved reset. 2019-12-19 11:12:59 -05:00
Kevin G Christiano
9e5ccb01a7 removed unused func. 2019-12-19 11:09:18 -05:00
Pan, Xinlei (Ryan)
21da4f960d Merge branch 'feature/container' into 'develop'
Feature/container

See merge request BPHV_MIPS/mvm_core_ui!202
2019-12-19 11:05:58 -05:00
Robinson, Blake
82c76c6084 Removed self where unnecessary 2019-12-19 10:37:57 -05:00
Robinson, Blake
1de7618e5c Changed to MVMCoreUIDelegateObject 2019-12-19 10:36:57 -05:00
Robinson, Blake
6cf4ba0594 Improved swifty-ness of these lines 2019-12-19 10:30:14 -05:00
Robinson, Blake
8f23dd391c Removes disabled logic from Button because it won't be in the actionMap going forward 2019-12-19 10:19:42 -05:00
Pfeil, Scott Robert
dcd0268c5b fix 2019-12-19 10:14:57 -05:00
Pan, Xinlei (Ryan)
2a5219f5b6 Merge branch 'bugfix/progress_bar_double_issue' into 'develop'
progress bar percentage type fix from Float to Double

See merge request BPHV_MIPS/mvm_core_ui!203
2019-12-19 10:14:30 -05:00
Robinson, Blake
2c5e2286b1 Removed line setting title because title won't be part of actionMap in the future 2019-12-19 10:06:54 -05:00
Robinson, Blake
109ef54479 Rewrote ButtonTapBlock in swift 2019-12-19 09:53:09 -05:00
Robinson, Blake
4b855a1a63 Removes unused property heightConstraint 2019-12-19 09:28:41 -05:00
Khan, Arshad
eec15fc65e added comment as per Scott feedback 2019-12-19 19:21:49 +05:30
Robinson, Blake
39c96849c8 Translates MFCustomButton to Button 2019-12-18 17:58:53 -05:00
Kevin G Christiano
37ddf23278 Latest changes to make it better. 2019-12-18 16:12:09 -05:00
Khan, Arshad
aff4b75368 Changing to CGFloat, instead of Double as per feedback provided by Ryan.
Root Cause: Swift was treating it as Double, instead of Float.
2019-12-18 22:28:22 +05:30
Khan, Arshad
09a9a6577d Adding new style sectionFooter for listItem molecule.
There are two places in MVA 3.0, where we need 24 pixel spacing on top, zero spacing on bottom and no separator.
2019-12-18 21:36:50 +05:30
Khan, Arshad
95c528b658 progress bar percentage is been treated as Double for two decimal places(Like 54.17) in iOS JSON object, due to that progress percentage is not shown, where as working on Android.
So, changing Float to Double.
2019-12-18 21:20:58 +05:30
Kevin G Christiano
d8030b178f removed unneeded statement. 2019-12-17 14:07:59 -05:00
Robinson, Blake
f731b56f2e Revert "Make Link subclass from View instead of MFCustomButton"
This reverts commit 439261e4c4.
2019-12-17 10:23:56 -05:00
Pfeil, Scott Robert
cd9e63b992 carousel to container 2019-12-17 09:51:49 -05:00
Pfeil, Scott Robert
03f64b0875 Module Molecule update to Container 2019-12-17 09:38:51 -05:00
Pfeil, Scott Robert
dc8910c61d add height constraint 2019-12-16 13:54:52 -05:00
Pfeil, Scott Robert
092dfd6ad0 List item updates 2019-12-16 13:40:04 -05:00
Pfeil, Scott Robert
f610264327 alignment updates 2019-12-16 11:19:30 -05:00
Pfeil, Scott Robert
7926a8579c Comment fixes 2019-12-16 10:50:18 -05:00
Kevin G Christiano
1fec5464af feedback independence. 2019-12-16 10:02:41 -05:00
Kevin G Christiano
bcddc0b311 Adjusted validation logic. 2019-12-16 08:53:45 -05:00
Pfeil, Scott Robert
7f01bc286c stack item as container 2019-12-13 17:07:10 -05:00
Kevin G Christiano
44ff5e9d3c Further development of Entry Field. 2019-12-13 12:54:43 -05:00
Kevin G Christiano
59008f87d0 Making further improvements from design specs. 2019-12-12 16:47:07 -05:00
Robinson, Blake
439261e4c4 Make Link subclass from View instead of MFCustomButton
The bounds of the Link often extend far beyond the width of the button text, which, if MFCustomButton is used, extend the tappable area far beyond the link.
2019-12-12 15:23:30 -05:00
Robinson, Blake
d3dbfdd997 changes size object to private since it shouldn't be accessed from outside the class 2019-12-12 15:01:54 -05:00
Kevin G Christiano
3dd9decfed Removed height constraint. This class will expect text to function properly. 2019-12-12 14:53:52 -05:00
Pfeil, Scott Robert
be1b867a9a testing container ideas 2019-12-12 14:50:52 -05:00
Kevin G Christiano
8804e21d3c New constant. Updated control to work with Apple's design guidelines with control. Updates made to checkbox and checkboxLabel. 2019-12-12 14:42:32 -05:00
Robinson, Blake
3fc3b6cb0a Removes convenience init since updateView is called by the framework and so does not need to be part of initialization 2019-12-12 10:39:21 -05:00
Pfeil, Scott Robert
e5acf63e6f container testing 2019-12-12 10:03:41 -05:00
Robinson, Blake
3001f1df78 Remove self where it is not necessary for clarity 2019-12-12 10:00:59 -05:00
Robinson, Blake
b8e0fbff75 Removed line spaces 2019-12-12 09:33:03 -05:00
Robinson, Blake
5135835471 Removed UIColor prefix as per code review comments 2019-12-12 09:32:09 -05:00
Robinson, Blake
fb2cade157 Fixed spacing before colon as per code review comment 2019-12-12 09:30:00 -05:00
Kevin G Christiano
3db8cf2c3b Reversed the array to first check views at the front. 2019-12-12 09:27:13 -05:00
Kevin G Christiano
ed18970625 correcting errors. Improving Control. 2019-12-12 09:23:04 -05:00
Kevin G Christiano
335649860b constraint adjustments. 2019-12-10 11:15:09 -05:00
Robinson, Blake
16cc667b02 Expands tappable area of Link 2019-12-09 14:15:55 -05:00
Kevin G Christiano
a7989c589f Increased the tappable space of the Checkbox. 2019-12-09 11:03:31 -05:00
Kevin G Christiano
420a874711 Making container tappabble to increase actionable surface area. 2019-12-05 14:07:53 -05:00
Kevin G Christiano
aaa8e4132e Brought back resizing to checkbox. 2019-12-04 16:25:31 -05:00
Kevin G Christiano
6b34b8840d Adding values back. 2019-12-04 16:05:41 -05:00
Pfeil, Scott Robert
27f2b00956 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into bugfix/label_molecule_fonting 2019-12-04 13:10:18 -05:00
Pfeil, Scott Robert
d95e42330e moving files 2019-12-04 13:09:50 -05:00
Hedden, Kyle Matthew
3f9b707d37 Add overtaking indicator to openPanel callback method. 2019-12-04 12:56:38 -05:00
Robinson, Blake
1d647ec662 Code standard change. Removed legacy-like methods. 2019-12-03 15:21:45 -05:00
Kevin G Christiano
9b53f4bac0 Paired down constraints. Made variables public. Mild formatting. 2019-12-03 09:07:43 -05:00
Kevin G Christiano
b443c4a389 Reducing constraints. 2019-12-02 17:33:06 -05:00
Robinson, Blake
988e30daa9 Creates Link atom to replace MFTextButton 2019-12-02 11:15:50 -05:00
Kevin G Christiano
65586a7568 Adding another location to execute external code. 2019-12-02 11:05:08 -05:00
Kevin G Christiano
5e28b0bdc5 Merge branch 'develop' into feature/swiftified_textField 2019-12-02 10:43:45 -05:00
Kevin G Christiano
2319c4c70f overrdie applied. 2019-12-02 10:43:08 -05:00
Pfeil, Scott Robert
44fd2dffac Merge branch 'bugfix/label_molecule_fonting' into 'develop'
label font bugfix caused by the dissonance between label and styler setting....

See merge request BPHV_MIPS/mvm_core_ui!192
2019-12-02 10:16:42 -05:00
Pfeil, Scott Robert
3e46438fd0 label font bugfix caused by the dissonance between label and styler setting.... 2019-12-02 10:11:04 -05:00
Kevin G Christiano
530397084b Merge branch 'develop' into feature/swiftified_textField 2019-12-02 09:51:09 -05:00
Kevin G Christiano
6a34370083 returned func. 2019-12-02 09:50:30 -05:00
Kevin G Christiano
0f04ebe177 Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
#	MVMCoreUI/OtherHandlers/MVMCoreUIMoleculeMappingObject.m
2019-12-02 09:04:17 -05:00
Kevin G Christiano
4d3e5544fb Merge branch 'feature/swiftified_textField' of gitlab.verizon.com:BPHV_MIPS/mvm_core_ui into feature/swiftified_textField 2019-12-02 08:57:08 -05:00
Kevin G Christiano
fc7ef567e3 Revised Superclass. 2019-12-02 08:56:58 -05:00
Khan, Arshad
dc5174cbe4 key name mismatch fix. 2019-11-28 20:48:07 +05:30
Pan, Xinlei (Ryan)
ad8b48b699 Merge branch 'feature/dropdown_line_item_legacy' into 'develop'
Feature/dropdown line item legacy

See merge request BPHV_MIPS/mvm_core_ui!190
2019-11-27 21:49:46 -05:00
Pfeil, Scott Robert
ee773eed89 key change 2019-11-27 15:02:03 -05:00
Hedden, Kyle Matthew
f5270ae12e remove navigation bar check for manual inset calculation as it impacts presented controllers 2019-11-27 14:03:51 -05:00
Pfeil, Scott Robert
63556707bc temporary dropdown molecule
label reuse font fixes
2019-11-27 13:49:01 -05:00
Khan, Arshad
c999f6f777 opening few properties 2019-11-27 21:43:42 +05:30
Khan, Arshad
f2f9d5d0d7 Adding open to required functions, which need to override in MF component.
Adding mapping for dropDown.
2019-11-27 21:12:41 +05:30
Pfeil, Scott Robert
1ec603e969 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/dropdown_line_item_legacy 2019-11-26 08:54:47 -05:00
Kevin G Christiano
3654b05773 removed unneeded method. mild changes. 2019-11-25 16:35:28 -05:00
Pfeil, Scott Robert
392ab144ac small fixes 2019-11-25 16:01:43 -05:00
Kevin G Christiano
499b938d56 Merge branch 'develop' into feature/swiftified_textField 2019-11-25 12:28:01 -05:00
Kevin G Christiano
cfffbabe58 identity and callback. 2019-11-25 12:27:32 -05:00
Pfeil, Scott Robert
664d3195bb line fix in header 2019-11-25 09:20:05 -05:00
Kevin G Christiano
dc8293b08b more refinement of errors. 2019-11-22 14:33:46 -05:00
Kevin G Christiano
72553935c2 latestst state. 2019-11-22 12:53:40 -05:00
Kevin G Christiano
21166bc5f0 Better functioning selection. 2019-11-22 09:20:35 -05:00