Commit Graph

1512 Commits

Author SHA1 Message Date
Murugan, Vimal
ccc535360c protocol implementation 2019-12-27 13:02:13 +05:30
Murugan, Vimal
1d843ae29a main thread update
access modifier update
2019-12-26 19:33:37 +05:30
panxi
e36d487d32 change model name to containerModel to avoid compiling error 2019-12-20 15:00:42 -05:00
panxi
ca1a6f8c83 merge from develop 2019-12-20 14:59:44 -05:00
Kevin G Christiano
fbc6e83038 Created Protocol to centralize tap detection logic. 2019-12-20 13:27:22 -05:00
Suresh, Kamlesh
7b0e423759 conflict 2019-12-20 12:07:59 -05:00
Suresh, Kamlesh
ba76fedff4 fixes 2019-12-20 10:24:36 -05:00
Kevin G Christiano
d2162cb9b6 removed override to conform. 2019-12-20 08:43:13 -05:00
Kevin G Christiano
cf41609210 correcting alignment func. 2019-12-19 16:09:41 -05:00
Kevin G Christiano
a04399516d Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Views/Checkbox.swift
2019-12-19 15:32:57 -05:00
Pan, Xinlei (Ryan)
767ee787cb Merge branch 'feature/checkboxView_constraints' into 'develop'
Checkbox view constraints

See merge request BPHV_MIPS/mvm_core_ui!194
2019-12-19 15:26:03 -05:00
Kevin G Christiano
3b59e03695 Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Buttons/CaretButton.swift
#	MVMCoreUI/Molecules/Items/MoleculeTableViewCell.swift
2019-12-19 15:11:48 -05:00
panxi
bf27d19ae1 change float to cgfloat for nslayoutconstraint 2019-12-19 14:25:26 -05:00
panxi
d17ab73d34 update encode decode method 2019-12-19 14:02:52 -05:00
Robinson, Blake
e11f64f0a4 Changed to optionalStringForKey 2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375 Used guard instead of if let because some code after the if let was removed 2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9 Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton. 2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab Removes self where unnecessary 2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57 Changed to MVMCoreUIUtility.getWidth() as per pr comments 2019-12-19 12:23:01 -05:00
Kevin G Christiano
f56b08fa0c Merge branch 'develop' into feature/checkboxView_constraints
# Conflicts:
#	MVMCoreUI/Atoms/Views/CheckboxWithLabelView.swift
2019-12-19 11:21:44 -05:00
Kevin G Christiano
6c9fede0b9 improved reset. 2019-12-19 11:12:59 -05:00
Kevin G Christiano
9e5ccb01a7 removed unused func. 2019-12-19 11:09:18 -05:00
Pan, Xinlei (Ryan)
21da4f960d Merge branch 'feature/container' into 'develop'
Feature/container

See merge request BPHV_MIPS/mvm_core_ui!202
2019-12-19 11:05:58 -05:00
Robinson, Blake
82c76c6084 Removed self where unnecessary 2019-12-19 10:37:57 -05:00
Robinson, Blake
1de7618e5c Changed to MVMCoreUIDelegateObject 2019-12-19 10:36:57 -05:00
Robinson, Blake
6cf4ba0594 Improved swifty-ness of these lines 2019-12-19 10:30:14 -05:00
Robinson, Blake
8f23dd391c Removes disabled logic from Button because it won't be in the actionMap going forward 2019-12-19 10:19:42 -05:00
Pfeil, Scott Robert
dcd0268c5b fix 2019-12-19 10:14:57 -05:00
Pan, Xinlei (Ryan)
2a5219f5b6 Merge branch 'bugfix/progress_bar_double_issue' into 'develop'
progress bar percentage type fix from Float to Double

See merge request BPHV_MIPS/mvm_core_ui!203
2019-12-19 10:14:30 -05:00
Pan, Xinlei (Ryan)
1d3d97757c Merge branch 'feature/add_sectionFooter_style_in_listItem' into 'develop'
Adding new style sectionFooter for listItem molecule.

See merge request BPHV_MIPS/mvm_core_ui!204
2019-12-19 10:14:17 -05:00
Robinson, Blake
2c5e2286b1 Removed line setting title because title won't be part of actionMap in the future 2019-12-19 10:06:54 -05:00
Robinson, Blake
109ef54479 Rewrote ButtonTapBlock in swift 2019-12-19 09:53:09 -05:00
Robinson, Blake
4b855a1a63 Removes unused property heightConstraint 2019-12-19 09:28:41 -05:00
Khan, Arshad
eec15fc65e added comment as per Scott feedback 2019-12-19 19:21:49 +05:30
Robinson, Blake
39c96849c8 Translates MFCustomButton to Button 2019-12-18 17:58:53 -05:00
Kevin G Christiano
37ddf23278 Latest changes to make it better. 2019-12-18 16:12:09 -05:00
Pfeil, Scott Robert
14c608c4a5 Commenting 2019-12-18 16:10:15 -05:00
Pfeil, Scott Robert
46e76f0b47 Further name changes 2019-12-18 16:07:00 -05:00
Suresh, Kamlesh
1db2a5b058 fixes 2019-12-18 12:06:13 -05:00
Khan, Arshad
aff4b75368 Changing to CGFloat, instead of Double as per feedback provided by Ryan.
Root Cause: Swift was treating it as Double, instead of Float.
2019-12-18 22:28:22 +05:30
Khan, Arshad
09a9a6577d Adding new style sectionFooter for listItem molecule.
There are two places in MVA 3.0, where we need 24 pixel spacing on top, zero spacing on bottom and no separator.
2019-12-18 21:36:50 +05:30
Khan, Arshad
95c528b658 progress bar percentage is been treated as Double for two decimal places(Like 54.17) in iOS JSON object, due to that progress percentage is not shown, where as working on Android.
So, changing Float to Double.
2019-12-18 21:20:58 +05:30
Pfeil, Scott Robert
ed25385d4b Merge branch 'feature/hero_improvement' into 'develop'
Hero Improvement.

See merge request BPHV_MIPS/mvm_core_ui!201
2019-12-18 10:19:00 -05:00
Pfeil, Scott Robert
e41f3039e4 Name changes and cleanup 2019-12-17 14:12:04 -05:00
Kevin G Christiano
d8030b178f removed unneeded statement. 2019-12-17 14:07:59 -05:00
Robinson, Blake
f731b56f2e Revert "Make Link subclass from View instead of MFCustomButton"
This reverts commit 439261e4c4.
2019-12-17 10:23:56 -05:00
Pfeil, Scott Robert
cd9e63b992 carousel to container 2019-12-17 09:51:49 -05:00
Kevin G Christiano
77e2269062 Provided an alternative means to provide Codable StackView.Alignment string. 2019-12-17 09:46:47 -05:00
Pfeil, Scott Robert
03f64b0875 Module Molecule update to Container 2019-12-17 09:38:51 -05:00
Pfeil, Scott Robert
dc8910c61d add height constraint 2019-12-16 13:54:52 -05:00