Commit Graph

1218 Commits

Author SHA1 Message Date
Kevin G Christiano
cf41609210 correcting alignment func. 2019-12-19 16:09:41 -05:00
Kevin G Christiano
a04399516d Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Views/Checkbox.swift
2019-12-19 15:32:57 -05:00
Pan, Xinlei (Ryan)
767ee787cb Merge branch 'feature/checkboxView_constraints' into 'develop'
Checkbox view constraints

See merge request BPHV_MIPS/mvm_core_ui!194
2019-12-19 15:26:03 -05:00
Kevin G Christiano
3b59e03695 Merge branch 'develop' into feature/swiftified_textField
# Conflicts:
#	MVMCoreUI/Atoms/Buttons/CaretButton.swift
#	MVMCoreUI/Molecules/Items/MoleculeTableViewCell.swift
2019-12-19 15:11:48 -05:00
Robinson, Blake
e11f64f0a4 Changed to optionalStringForKey 2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375 Used guard instead of if let because some code after the if let was removed 2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9 Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton. 2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab Removes self where unnecessary 2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57 Changed to MVMCoreUIUtility.getWidth() as per pr comments 2019-12-19 12:23:01 -05:00
Kevin G Christiano
f56b08fa0c Merge branch 'develop' into feature/checkboxView_constraints
# Conflicts:
#	MVMCoreUI/Atoms/Views/CheckboxWithLabelView.swift
2019-12-19 11:21:44 -05:00
Kevin G Christiano
6c9fede0b9 improved reset. 2019-12-19 11:12:59 -05:00
Kevin G Christiano
9e5ccb01a7 removed unused func. 2019-12-19 11:09:18 -05:00
Pan, Xinlei (Ryan)
21da4f960d Merge branch 'feature/container' into 'develop'
Feature/container

See merge request BPHV_MIPS/mvm_core_ui!202
2019-12-19 11:05:58 -05:00
Pfeil, Scott Robert
dcd0268c5b fix 2019-12-19 10:14:57 -05:00
Pan, Xinlei (Ryan)
2a5219f5b6 Merge branch 'bugfix/progress_bar_double_issue' into 'develop'
progress bar percentage type fix from Float to Double

See merge request BPHV_MIPS/mvm_core_ui!203
2019-12-19 10:14:30 -05:00
Pan, Xinlei (Ryan)
1d3d97757c Merge branch 'feature/add_sectionFooter_style_in_listItem' into 'develop'
Adding new style sectionFooter for listItem molecule.

See merge request BPHV_MIPS/mvm_core_ui!204
2019-12-19 10:14:17 -05:00
Khan, Arshad
eec15fc65e added comment as per Scott feedback 2019-12-19 19:21:49 +05:30
Kevin G Christiano
37ddf23278 Latest changes to make it better. 2019-12-18 16:12:09 -05:00
Khan, Arshad
aff4b75368 Changing to CGFloat, instead of Double as per feedback provided by Ryan.
Root Cause: Swift was treating it as Double, instead of Float.
2019-12-18 22:28:22 +05:30
Khan, Arshad
09a9a6577d Adding new style sectionFooter for listItem molecule.
There are two places in MVA 3.0, where we need 24 pixel spacing on top, zero spacing on bottom and no separator.
2019-12-18 21:36:50 +05:30
Khan, Arshad
95c528b658 progress bar percentage is been treated as Double for two decimal places(Like 54.17) in iOS JSON object, due to that progress percentage is not shown, where as working on Android.
So, changing Float to Double.
2019-12-18 21:20:58 +05:30
Pfeil, Scott Robert
ed25385d4b Merge branch 'feature/hero_improvement' into 'develop'
Hero Improvement.

See merge request BPHV_MIPS/mvm_core_ui!201
2019-12-18 10:19:00 -05:00
Kevin G Christiano
d8030b178f removed unneeded statement. 2019-12-17 14:07:59 -05:00
Robinson, Blake
f731b56f2e Revert "Make Link subclass from View instead of MFCustomButton"
This reverts commit 439261e4c4.
2019-12-17 10:23:56 -05:00
Pfeil, Scott Robert
cd9e63b992 carousel to container 2019-12-17 09:51:49 -05:00
Pfeil, Scott Robert
03f64b0875 Module Molecule update to Container 2019-12-17 09:38:51 -05:00
Pfeil, Scott Robert
dc8910c61d add height constraint 2019-12-16 13:54:52 -05:00
Pfeil, Scott Robert
092dfd6ad0 List item updates 2019-12-16 13:40:04 -05:00
Pfeil, Scott Robert
f610264327 alignment updates 2019-12-16 11:19:30 -05:00
Pfeil, Scott Robert
7926a8579c Comment fixes 2019-12-16 10:50:18 -05:00
Kevin G Christiano
1fec5464af feedback independence. 2019-12-16 10:02:41 -05:00
Kevin G Christiano
bcddc0b311 Adjusted validation logic. 2019-12-16 08:53:45 -05:00
Pfeil, Scott Robert
7f01bc286c stack item as container 2019-12-13 17:07:10 -05:00
Kevin G Christiano
44ff5e9d3c Further development of Entry Field. 2019-12-13 12:54:43 -05:00
Kevin G Christiano
59008f87d0 Making further improvements from design specs. 2019-12-12 16:47:07 -05:00
Robinson, Blake
439261e4c4 Make Link subclass from View instead of MFCustomButton
The bounds of the Link often extend far beyond the width of the button text, which, if MFCustomButton is used, extend the tappable area far beyond the link.
2019-12-12 15:23:30 -05:00
Robinson, Blake
d3dbfdd997 changes size object to private since it shouldn't be accessed from outside the class 2019-12-12 15:01:54 -05:00
Kevin G Christiano
3dd9decfed Removed height constraint. This class will expect text to function properly. 2019-12-12 14:53:52 -05:00
Pfeil, Scott Robert
be1b867a9a testing container ideas 2019-12-12 14:50:52 -05:00
Kevin G Christiano
8804e21d3c New constant. Updated control to work with Apple's design guidelines with control. Updates made to checkbox and checkboxLabel. 2019-12-12 14:42:32 -05:00
Robinson, Blake
3fc3b6cb0a Removes convenience init since updateView is called by the framework and so does not need to be part of initialization 2019-12-12 10:39:21 -05:00
Pfeil, Scott Robert
e5acf63e6f container testing 2019-12-12 10:03:41 -05:00
Robinson, Blake
3001f1df78 Remove self where it is not necessary for clarity 2019-12-12 10:00:59 -05:00
Robinson, Blake
b8e0fbff75 Removed line spaces 2019-12-12 09:33:03 -05:00
Robinson, Blake
5135835471 Removed UIColor prefix as per code review comments 2019-12-12 09:32:09 -05:00
Robinson, Blake
fb2cade157 Fixed spacing before colon as per code review comment 2019-12-12 09:30:00 -05:00
Kevin G Christiano
3db8cf2c3b Reversed the array to first check views at the front. 2019-12-12 09:27:13 -05:00
Kevin G Christiano
ed18970625 correcting errors. Improving Control. 2019-12-12 09:23:04 -05:00
Kevin G Christiano
335649860b constraint adjustments. 2019-12-10 11:15:09 -05:00
Robinson, Blake
16cc667b02 Expands tappable area of Link 2019-12-09 14:15:55 -05:00