Robinson, Blake
e11f64f0a4
Changed to optionalStringForKey
2019-12-19 13:41:27 -05:00
Robinson, Blake
87613fb375
Used guard instead of if let because some code after the if let was removed
2019-12-19 13:38:51 -05:00
Robinson, Blake
8d417068a9
Removed heightConstraint-related logic because the heightConstraint was added to increase the tappable area of Link's predecessor, MFTextButton.
2019-12-19 13:13:57 -05:00
Robinson, Blake
6e233e9bab
Removes self where unnecessary
2019-12-19 12:23:18 -05:00
Robinson, Blake
7c17889b57
Changed to MVMCoreUIUtility.getWidth() as per pr comments
2019-12-19 12:23:01 -05:00
Kevin G Christiano
f56b08fa0c
Merge branch 'develop' into feature/checkboxView_constraints
...
# Conflicts:
# MVMCoreUI/Atoms/Views/CheckboxWithLabelView.swift
2019-12-19 11:21:44 -05:00
Kevin G Christiano
6c9fede0b9
improved reset.
2019-12-19 11:12:59 -05:00
Kevin G Christiano
9e5ccb01a7
removed unused func.
2019-12-19 11:09:18 -05:00
Pan, Xinlei (Ryan)
21da4f960d
Merge branch 'feature/container' into 'develop'
...
Feature/container
See merge request BPHV_MIPS/mvm_core_ui!202
2019-12-19 11:05:58 -05:00
Pfeil, Scott Robert
dcd0268c5b
fix
2019-12-19 10:14:57 -05:00
Pan, Xinlei (Ryan)
2a5219f5b6
Merge branch 'bugfix/progress_bar_double_issue' into 'develop'
...
progress bar percentage type fix from Float to Double
See merge request BPHV_MIPS/mvm_core_ui!203
2019-12-19 10:14:30 -05:00
Khan, Arshad
eec15fc65e
added comment as per Scott feedback
2019-12-19 19:21:49 +05:30
Kevin G Christiano
37ddf23278
Latest changes to make it better.
2019-12-18 16:12:09 -05:00
Khan, Arshad
aff4b75368
Changing to CGFloat, instead of Double as per feedback provided by Ryan.
...
Root Cause: Swift was treating it as Double, instead of Float.
2019-12-18 22:28:22 +05:30
Khan, Arshad
09a9a6577d
Adding new style sectionFooter for listItem molecule.
...
There are two places in MVA 3.0, where we need 24 pixel spacing on top, zero spacing on bottom and no separator.
2019-12-18 21:36:50 +05:30
Khan, Arshad
95c528b658
progress bar percentage is been treated as Double for two decimal places(Like 54.17) in iOS JSON object, due to that progress percentage is not shown, where as working on Android.
...
So, changing Float to Double.
2019-12-18 21:20:58 +05:30
Kevin G Christiano
d8030b178f
removed unneeded statement.
2019-12-17 14:07:59 -05:00
Robinson, Blake
f731b56f2e
Revert "Make Link subclass from View instead of MFCustomButton"
...
This reverts commit 439261e4c4 .
2019-12-17 10:23:56 -05:00
Pfeil, Scott Robert
cd9e63b992
carousel to container
2019-12-17 09:51:49 -05:00
Pfeil, Scott Robert
03f64b0875
Module Molecule update to Container
2019-12-17 09:38:51 -05:00
Pfeil, Scott Robert
dc8910c61d
add height constraint
2019-12-16 13:54:52 -05:00
Pfeil, Scott Robert
092dfd6ad0
List item updates
2019-12-16 13:40:04 -05:00
Pfeil, Scott Robert
f610264327
alignment updates
2019-12-16 11:19:30 -05:00
Pfeil, Scott Robert
7926a8579c
Comment fixes
2019-12-16 10:50:18 -05:00
Kevin G Christiano
1fec5464af
feedback independence.
2019-12-16 10:02:41 -05:00
Kevin G Christiano
bcddc0b311
Adjusted validation logic.
2019-12-16 08:53:45 -05:00
Pfeil, Scott Robert
7f01bc286c
stack item as container
2019-12-13 17:07:10 -05:00
Kevin G Christiano
44ff5e9d3c
Further development of Entry Field.
2019-12-13 12:54:43 -05:00
Kevin G Christiano
59008f87d0
Making further improvements from design specs.
2019-12-12 16:47:07 -05:00
Robinson, Blake
439261e4c4
Make Link subclass from View instead of MFCustomButton
...
The bounds of the Link often extend far beyond the width of the button text, which, if MFCustomButton is used, extend the tappable area far beyond the link.
2019-12-12 15:23:30 -05:00
Robinson, Blake
d3dbfdd997
changes size object to private since it shouldn't be accessed from outside the class
2019-12-12 15:01:54 -05:00
Kevin G Christiano
3dd9decfed
Removed height constraint. This class will expect text to function properly.
2019-12-12 14:53:52 -05:00
Pfeil, Scott Robert
be1b867a9a
testing container ideas
2019-12-12 14:50:52 -05:00
Kevin G Christiano
8804e21d3c
New constant. Updated control to work with Apple's design guidelines with control. Updates made to checkbox and checkboxLabel.
2019-12-12 14:42:32 -05:00
Robinson, Blake
3fc3b6cb0a
Removes convenience init since updateView is called by the framework and so does not need to be part of initialization
2019-12-12 10:39:21 -05:00
Pfeil, Scott Robert
e5acf63e6f
container testing
2019-12-12 10:03:41 -05:00
Robinson, Blake
3001f1df78
Remove self where it is not necessary for clarity
2019-12-12 10:00:59 -05:00
Robinson, Blake
b8e0fbff75
Removed line spaces
2019-12-12 09:33:03 -05:00
Robinson, Blake
5135835471
Removed UIColor prefix as per code review comments
2019-12-12 09:32:09 -05:00
Robinson, Blake
fb2cade157
Fixed spacing before colon as per code review comment
2019-12-12 09:30:00 -05:00
Kevin G Christiano
3db8cf2c3b
Reversed the array to first check views at the front.
2019-12-12 09:27:13 -05:00
Kevin G Christiano
ed18970625
correcting errors. Improving Control.
2019-12-12 09:23:04 -05:00
Kevin G Christiano
335649860b
constraint adjustments.
2019-12-10 11:15:09 -05:00
Robinson, Blake
16cc667b02
Expands tappable area of Link
2019-12-09 14:15:55 -05:00
Kevin G Christiano
a7989c589f
Increased the tappable space of the Checkbox.
2019-12-09 11:03:31 -05:00
Kevin G Christiano
420a874711
Making container tappabble to increase actionable surface area.
2019-12-05 14:07:53 -05:00
Kevin G Christiano
aaa8e4132e
Brought back resizing to checkbox.
2019-12-04 16:25:31 -05:00
Kevin G Christiano
6b34b8840d
Adding values back.
2019-12-04 16:05:41 -05:00
Pfeil, Scott Robert
27f2b00956
Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into bugfix/label_molecule_fonting
2019-12-04 13:10:18 -05:00
Pfeil, Scott Robert
d95e42330e
moving files
2019-12-04 13:09:50 -05:00
Hedden, Kyle Matthew
3f9b707d37
Add overtaking indicator to openPanel callback method.
2019-12-04 12:56:38 -05:00
Robinson, Blake
1d647ec662
Code standard change. Removed legacy-like methods.
2019-12-03 15:21:45 -05:00
Kevin G Christiano
9b53f4bac0
Paired down constraints. Made variables public. Mild formatting.
2019-12-03 09:07:43 -05:00
Kevin G Christiano
b443c4a389
Reducing constraints.
2019-12-02 17:33:06 -05:00
Robinson, Blake
988e30daa9
Creates Link atom to replace MFTextButton
2019-12-02 11:15:50 -05:00
Kevin G Christiano
65586a7568
Adding another location to execute external code.
2019-12-02 11:05:08 -05:00
Kevin G Christiano
5e28b0bdc5
Merge branch 'develop' into feature/swiftified_textField
2019-12-02 10:43:45 -05:00
Kevin G Christiano
2319c4c70f
overrdie applied.
2019-12-02 10:43:08 -05:00
Pfeil, Scott Robert
44fd2dffac
Merge branch 'bugfix/label_molecule_fonting' into 'develop'
...
label font bugfix caused by the dissonance between label and styler setting....
See merge request BPHV_MIPS/mvm_core_ui!192
2019-12-02 10:16:42 -05:00
Pfeil, Scott Robert
3e46438fd0
label font bugfix caused by the dissonance between label and styler setting....
2019-12-02 10:11:04 -05:00
Kevin G Christiano
530397084b
Merge branch 'develop' into feature/swiftified_textField
2019-12-02 09:51:09 -05:00
Kevin G Christiano
6a34370083
returned func.
2019-12-02 09:50:30 -05:00
Kevin G Christiano
0f04ebe177
Merge branch 'develop' into feature/swiftified_textField
...
# Conflicts:
# MVMCoreUI.xcodeproj/project.pbxproj
# MVMCoreUI/OtherHandlers/MVMCoreUIMoleculeMappingObject.m
2019-12-02 09:04:17 -05:00
Kevin G Christiano
4d3e5544fb
Merge branch 'feature/swiftified_textField' of gitlab.verizon.com:BPHV_MIPS/mvm_core_ui into feature/swiftified_textField
2019-12-02 08:57:08 -05:00
Kevin G Christiano
fc7ef567e3
Revised Superclass.
2019-12-02 08:56:58 -05:00
Khan, Arshad
dc5174cbe4
key name mismatch fix.
2019-11-28 20:48:07 +05:30
Pan, Xinlei (Ryan)
ad8b48b699
Merge branch 'feature/dropdown_line_item_legacy' into 'develop'
...
Feature/dropdown line item legacy
See merge request BPHV_MIPS/mvm_core_ui!190
2019-11-27 21:49:46 -05:00
Pfeil, Scott Robert
ee773eed89
key change
2019-11-27 15:02:03 -05:00
Hedden, Kyle Matthew
f5270ae12e
remove navigation bar check for manual inset calculation as it impacts presented controllers
2019-11-27 14:03:51 -05:00
Pfeil, Scott Robert
63556707bc
temporary dropdown molecule
...
label reuse font fixes
2019-11-27 13:49:01 -05:00
Khan, Arshad
c999f6f777
opening few properties
2019-11-27 21:43:42 +05:30
Khan, Arshad
f2f9d5d0d7
Adding open to required functions, which need to override in MF component.
...
Adding mapping for dropDown.
2019-11-27 21:12:41 +05:30
Pfeil, Scott Robert
1ec603e969
Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/dropdown_line_item_legacy
2019-11-26 08:54:47 -05:00
Kevin G Christiano
3654b05773
removed unneeded method. mild changes.
2019-11-25 16:35:28 -05:00
Pfeil, Scott Robert
392ab144ac
small fixes
2019-11-25 16:01:43 -05:00
Kevin G Christiano
499b938d56
Merge branch 'develop' into feature/swiftified_textField
2019-11-25 12:28:01 -05:00
Kevin G Christiano
cfffbabe58
identity and callback.
2019-11-25 12:27:32 -05:00
Pfeil, Scott Robert
664d3195bb
line fix in header
2019-11-25 09:20:05 -05:00
Kevin G Christiano
dc8293b08b
more refinement of errors.
2019-11-22 14:33:46 -05:00
Kevin G Christiano
72553935c2
latestst state.
2019-11-22 12:53:40 -05:00
Kevin G Christiano
21166bc5f0
Better functioning selection.
2019-11-22 09:20:35 -05:00
Kevin G Christiano
64bda3cb1d
wip.
2019-11-21 16:40:34 -05:00
Kevin G Christiano
8b5fe4a1f4
more changes.
2019-11-21 15:21:32 -05:00
Kevin G Christiano
f19d45b865
Merge branch 'develop' into feature/swiftified_textField
...
# Conflicts:
# MVMCoreUI.xcodeproj/project.pbxproj
# MVMCoreUI/Atoms/Views/CaretView.swift
# MVMCoreUI/Molecules/Items/TableViewCell.swift
2019-11-21 11:55:21 -05:00
Kevin G Christiano
88442fe59c
latest.
2019-11-21 11:47:12 -05:00
Pfeil, Scott Robert
095b1d7a86
Merge branch 'feature/modernize' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize
2019-11-20 13:29:41 -05:00
Pfeil, Scott Robert
e32b9cfdda
PR comments
2019-11-20 13:29:16 -05:00
Pfeil, Scott Robert
947af9b3c7
why?
2019-11-20 11:08:30 -05:00
Pfeil, Scott Robert
654be26b2c
remove test file
2019-11-20 11:06:47 -05:00
Pfeil, Scott Robert
279dbd9b08
Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/modernize
2019-11-20 10:59:35 -05:00
Pfeil, Scott Robert
c96f5050a8
Line to swift
2019-11-20 10:20:24 -05:00
Kevin G Christiano
26c73070d9
latestest and greatest.
2019-11-20 09:12:31 -05:00
Hedden, Kyle Matthew
a714100b73
Merge branch 'release/7_1_0' into 'develop'
...
Release/7 1 0
See merge request BPHV_MIPS/mvm_core_ui!179
2019-11-19 17:02:45 -05:00
panxi
a409b331c5
revert
2019-11-19 12:56:07 -05:00
panxi
3851ad036a
change to equal
2019-11-19 12:53:48 -05:00
panxi
3cb075499e
make checkbox expandable
2019-11-19 10:39:30 -05:00
Kevin G Christiano
c38e3c0712
DigitEntry in decent place.
2019-11-19 09:57:43 -05:00
Pfeil, Scott Robert
d29e8ea3bd
small changes
2019-11-19 09:18:15 -05:00
Kevin G Christiano
b9850bed81
Merge branch 'feature/swiftified_textField' of gitlab.verizon.com:BPHV_MIPS/mvm_core_ui into feature/swiftified_textField
2019-11-18 17:04:26 -05:00
Kevin G Christiano
df34e1574c
latest, updating.
2019-11-18 17:04:16 -05:00