Commit Graph

2005 Commits

Author SHA1 Message Date
Hedden, Kyle Matthew
14ccfe61be Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-24 15:53:38 -05:00
Pfeil, Scott Robert
2a847602a2 Merge branch 'bugfix/PRODDEF-19592' into 'develop'
Updated textView to have label text for accessibility behavior

### Summary
Updated textView to have label text for accessibility behavior

### JIRA Ticket
https://onejira.verizon.com/browse/PRODDEF-19592

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1029
2024-01-24 16:46:04 +00:00
Pfeil, Scott Robert
54519d9820 Merge branch 'feature/dynamicAccessibilityTraits' into 'develop'
Added accessibilityTraits dynamically for buttons, List components

### Summary
Driven all the buttons and list components traits dynamically. As per the WCAG Accessibility guidelines,

Button role - is used to trigger an action e,g confirm information, submit data, continue multi step task.  (Button page #45) 

Link role - Links should be used only for actions that take the user to other locations and, should not be used for button-like functionality.(Text Link page# 46).

Google drive link : ([https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!\[Links__2\_\](/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2\_.png](https://drive.google.com/drive/folders/1l2Is486J2UxaVulHE8N5xOTFecFtRCvW)!%5BLinks__2_%5D(/uploads/002f8ac31c0bb7f02f4d030b8995cb9b/Links__2_.png))

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-421918

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>
Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/996
2024-01-24 16:33:47 +00:00
Keerthy
d1ee6e7f3a Addressed code review comments 2024-01-24 16:18:35 +05:30
Keerthy
459d3e4a33 Merge branch 'develop' into bugfix/PRODDEF-19592 2024-01-24 16:00:45 +05:30
Keerthy
eb5d359322 Addressed review comments
Added accessibilityHint to AccessibilityModelProtocol
2024-01-22 23:29:47 +05:30
Hedden, Kyle Matthew
03d1848c50 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2024-01-17 11:27:46 -05:00
Hedden, Kyle Matthew
950f63e87b Merge branch 'feature/ONEAPP-6340' into 'develop'
ONEAPP-6435

### Summary
Open the progress bar molecule model for extension.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-6435

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1040
2024-01-12 15:20:05 +00:00
Hedden, Kyle Matthew
8a62065ade open encoder 2024-01-11 18:17:06 -05:00
Keerthy
3d7e1ac646 Merge branch 'develop' into feature/dynamicAccessibilityTraits 2024-01-09 12:39:45 +05:30
vimal
1541c9bb4a Merge branch 'feature/molecule_replacement_behavior' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_header_fix 2024-01-08 09:32:17 +05:30
vimal
46a3af5e6b review comment updated 2024-01-08 09:30:09 +05:30
Hedden, Kyle Matthew
929cb33b5f set the intiial tint state for ImageButton 2024-01-04 14:19:28 -05:00
vimal
03ea6c528c minor cleanup 2024-01-04 11:07:34 +05:30
vimal
db7e59191a fix for button model
review comment updated
2024-01-03 23:25:48 +05:30
vimal
b6623b34c6 Merge branch 'feature/molecule_replacement_behavior' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_header_fix 2024-01-03 15:26:37 +05:30
vimal
047d9b7014 enhancement on the header update based on the molecules 2024-01-03 15:23:29 +05:30
Hedden, Kyle Matthew
c2c4e0f1f4 indexing safety 2024-01-02 17:25:43 -05:00
Hedden, Kyle Matthew
ca10c0b849 indexing safety 2024-01-02 17:24:42 -05:00
vimal
c91d389ea5 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior
# Conflicts:
#	MVMCoreUI.xcodeproj/project.pbxproj
2023-12-22 18:32:55 +05:30
Hedden, Kyle Matthew
8306f901bd Open up progress bar atom for subclassing. 2023-12-21 22:19:45 -05:00
Rajendran, Nandhini
ad48df2242 story: ONEAPP-4156 LoggingHandler Swift migration 2023-12-21 16:28:22 +00:00
Hedden, Kyle Matthew
4f586ced89 Animate GIFs. 2023-12-20 19:16:22 -05:00
Hedden, Kyle Matthew
2857b1cd55 Stop closure efficiency. 2023-12-18 17:22:40 -05:00
Hedden, Kyle Matthew
df32a51395 Fix first time carousel replacement. 2023-12-18 17:19:52 -05:00
Hedden, Kyle Matthew
cac849fadc text field Spanish localization for optional 2023-12-11 10:48:37 -05:00
vimal
0ecfef39cd review comment updated. setting the height from model if not exist then hard coded value 2023-12-11 13:46:41 +05:30
Hedden, Kyle Matthew
ac88b5d2b1 Merge remote-tracking branch 'origin/develop' into feature/molecule_replacement_behavior 2023-12-05 14:39:29 -05:00
Hedden, Kyle Matthew
9ec376ffa9 Merge branch 'release/11_1_4' into 'develop'
release/11_1_4 hotfix merge

Co-authored-by: Pfeil, Scott Robert <scott.pfeil3@verizonwireless.com>
Co-authored-by: Sumanth Nadigadda <sumanth.nadigadda@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1032
2023-12-05 14:42:29 +00:00
Rajendran, Nandhini
172173eb1b Revert "Merge branch 'feature/ONEAPP-5868' into 'develop'"
This reverts merge request !1010
2023-12-04 11:53:41 +00:00
Hedden, Kyle Matthew
8b64b2b52a Ensure index > 0 for those tricky ones. 2023-12-01 14:32:33 -05:00
Hedden, Kyle Matthew
21f24b2c9b remove extra paranthesis 2023-12-01 14:16:00 -05:00
Hedden, Kyle Matthew
6e5980af64 Index check before switching tabs. 2023-12-01 14:12:04 -05:00
Sumanth Nadigadda
8de78987f8 Setting accessibility label if available before text for eyebrow, headline, body labels in EyebrowHeadlineBodyLink molecule's accessibility label 2023-12-01 14:32:44 +05:30
Keerthy
d65df06934 Updated textView to have label text for accessibility behavior 2023-11-22 18:07:13 +05:30
Hedden, Kyle Matthew
4687d7d344 self cleanups 2023-11-15 17:30:18 -05:00
Hedden, Kyle Matthew
61916e7c38 Move hightlightTab to @MainActor to prevent block crash. 2023-11-15 17:14:51 -05:00
Pfeil, Scott Robert
c1cb411491 Merge branch 'feature/searchResultAnnouncement' into 'develop'
Updated accessibilityText in ListItemModel for searchResults announcement

### Summary
Updated accessibilityText in ListItemModel for searchResults announcement.

Dependent PR's : 
https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/978
https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2172

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1022
2023-11-02 20:35:41 +00:00
Keerthy
8e4ad2c41e Updated accessibilityText in ListItemModel for searchResults announcement 2023-11-03 00:11:16 +05:30
vimal
50caab7936 Merge branch 'develop' of https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui into feature/molecule_replacement_behavior 2023-11-02 20:42:40 +05:30
Keerthy
d5f5072560 Merge branch 'develop' into feature/accessibilityHandler 2023-11-02 11:37:50 +05:30
Bruce, Matt R
c202a93acf Merge branch 'bugfix/CXTDT-446531' into 'develop'
Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, checkBoxLabel

### Summary
1. Textfield : VO should reads as label, textField.
2. Picker : VO should read as label, current selection , has popup/ picker item.
3. CheckBox Label : Both checkbox and label should have single focus, VO should read as checkbox role, status and label.

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-446531

This PR is having dependency with https://gitlab.verizon.com/BPHV_MIPS/mobilefirst_ios/-/merge_requests/2263. Unable to add dependency in this PR.

Co-authored-by: Keerthy <keerthy.marakanti@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1020
2023-11-01 21:11:27 +00:00
Bruce, Matt R
747db3290e Merge branch 'bugfix/accessibilityFocusFixForListLVImgAllCell' into 'develop'
Updated linkShowing logic for accessibility

### Summary
In VDS Link component, we have default text assigned to Link(ButtonBase) as "No Text". Because of that default text, `eyebrowHeadlineBodyLink.link.titleLabel?.text?.count ?? 0 > 0` condition is getting true even though we don't have link in the model/UI.

Updated condition based on model text.

Co-authored-by: Krishna Kishore Bandaru <krishna.kishore.bandaru@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1018
2023-11-01 20:57:50 +00:00
Keerthy
5920bf3e50 Order change 2023-11-02 00:52:13 +05:30
Keerthy
84314aa5ed Merge branch 'develop' into bugfix/CXTDT-446531 2023-11-02 00:01:58 +05:30
Keerthy
9fe6a4dfc1 Updated accessibility behavior for TextEntryField, BaseItemPickerEntryField, CheckboxLabel 2023-11-01 23:59:34 +05:30
Krishna Kishore Bandaru
975882d47c addressed code review comments 2023-11-01 18:11:22 +05:30
Krishna Kishore Bandaru
34dcc80f67 Updated linkShowing logic for accessibility 2023-11-01 14:09:55 +05:30
Keerthy
96fa0bf314 Removed accessibilityElements to resolve focus stuck issue 2023-11-01 13:47:23 +05:30
Keerthy
fe40639a19 Merge branch 'develop' into bugfix/focusStuckIssue 2023-11-01 13:46:09 +05:30