implemented review feedback

This commit is contained in:
Khan, Arshad 2020-10-20 00:21:53 +05:30
parent 3e215b1851
commit bfa77d7032
8 changed files with 27 additions and 40 deletions

View File

@ -15,8 +15,7 @@ import Foundation
public let headlineBody = HeadlineBody(frame: .zero) public let headlineBody = HeadlineBody(frame: .zero)
public let buttons = TwoButtonView(frame: .zero) public let buttons = TwoButtonView(frame: .zero)
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [headlineBody, buttons], spacing: Padding.Eighteen) return Stack<StackModel>.createStack(with: [headlineBody, buttons], spacing: Padding.Eighteen)
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -17,8 +17,7 @@ import Foundation
public let headlineBody = HeadlineBody() public let headlineBody = HeadlineBody()
public let buttons = TwoButtonView() public let buttons = TwoButtonView()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [headlineBody, buttons], spacing: PaddingDefaultVerticalSpacing3) return Stack<StackModel>.createStack(with: [headlineBody, buttons], spacing: PaddingDefaultVerticalSpacing3)
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -14,8 +14,7 @@ import Foundation
public let headlineBody = HeadlineBody() public let headlineBody = HeadlineBody()
public let caretLink = CaretLink() public let caretLink = CaretLink()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [headlineBody, caretLink]) return Stack<StackModel>.createStack(with: [headlineBody, caretLink])
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -15,8 +15,7 @@ import Foundation
public let headlineBody = HeadlineBody() public let headlineBody = HeadlineBody()
public let link = Link() public let link = Link()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [headlineBody, link]) return Stack<StackModel>.createStack(with: [headlineBody, link])
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -22,29 +22,24 @@ import Foundation
public let verticalLine1 = Line() public let verticalLine1 = Line()
public let verticalLine2 = Line() public let verticalLine2 = Line()
public lazy var verticalStack1: Stack<StackModel> = { public lazy var verticalStack1: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [body, subBody], spacing: 0) return Stack<StackModel>.createStack(with: [body, subBody], spacing: 0)
return stack
}() }()
public lazy var verticalStack2: Stack<StackModel> = { public lazy var verticalStack2: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [body2, subBody2], spacing: 0) return Stack<StackModel>.createStack(with: [body2, subBody2], spacing: 0)
return stack
}() }()
public lazy var verticalStack3: Stack<StackModel> = { public lazy var verticalStack3: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [body3, subBody3], spacing: 0) return Stack<StackModel>.createStack(with: [body3, subBody3], spacing: 0)
return stack
}() }()
public lazy var horizontalStack: Stack<StackModel> = { public lazy var horizontalStack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [(view: verticalStack1, model: StackItemModel(percent: 29, verticalAlignment: .top)), return Stack<StackModel>.createStack(with: [(view: verticalStack1, model: StackItemModel(percent: 29, verticalAlignment: .top)),
(view: verticalLine1, model: StackItemModel(verticalAlignment: .top)), (view: verticalLine1, model: StackItemModel(verticalAlignment: .top)),
(view: verticalStack2, model: StackItemModel(horizontalAlignment: .leading, verticalAlignment: .top)), (view: verticalStack2, model: StackItemModel(horizontalAlignment: .leading, verticalAlignment: .top)),
(view: verticalLine2, model: StackItemModel(verticalAlignment: .top)), (view: verticalLine2, model: StackItemModel(verticalAlignment: .top)),
(view: verticalStack3, model: StackItemModel(percent: 32, verticalAlignment: .top))], (view: verticalStack3, model: StackItemModel(percent: 32, verticalAlignment: .top))],
axis: .horizontal) axis: .horizontal)
return stack
}() }()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [headline, horizontalStack], spacing: 8) return Stack<StackModel>.createStack(with: [headline, horizontalStack], spacing: 8)
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -17,10 +17,9 @@ import Foundation
public let headlineBody = HeadlineBody() public let headlineBody = HeadlineBody()
public let button = PillButton() public let button = PillButton()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [(view: headlineBody, model: StackItemModel(horizontalAlignment: .fill)), return Stack<StackModel>.createStack(with: [(view: headlineBody, model: StackItemModel(horizontalAlignment: .fill)),
(view: button, model: StackItemModel(spacing: spacingBetwenHeadlineBodyAndButton, horizontalAlignment: .leading))], (view: button, model: StackItemModel(spacing: spacingBetwenHeadlineBodyAndButton, horizontalAlignment: .leading))],
axis: .vertical) axis: .vertical)
return stack
}() }()
//------------------------------------------------------ //------------------------------------------------------

View File

@ -16,10 +16,9 @@ import Foundation
public let subHeadline = Label(fontStyle: .RegularTitleLarge) public let subHeadline = Label(fontStyle: .RegularTitleLarge)
public let body = Label(fontStyle: .RegularBodySmall) public let body = Label(fontStyle: .RegularBodySmall)
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [(view: headline, model: StackItemModel()), return Stack<StackModel>.createStack(with: [(view: headline, model: StackItemModel()),
(view: subHeadline, model: StackItemModel(spacing: 16)), (view: subHeadline, model: StackItemModel(spacing: 16)),
(view: body, model: StackItemModel(spacing: 8))]) (view: body, model: StackItemModel(spacing: 8))])
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------

View File

@ -17,17 +17,15 @@ import Foundation
public let subHeadline = Label(fontStyle: .RegularTitleLarge) public let subHeadline = Label(fontStyle: .RegularTitleLarge)
public let body = Label(fontStyle: .RegularBodySmall) public let body = Label(fontStyle: .RegularBodySmall)
public lazy var verticalStack: Stack<StackModel> = { public lazy var verticalStack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [(view: headline, model: StackItemModel()), return Stack<StackModel>.createStack(with: [(view: headline, model: StackItemModel()),
(view: subHeadline, model: StackItemModel()), (view: subHeadline, model: StackItemModel()),
(view: body, model: StackItemModel(horizontalAlignment: .fill))], (view: body, model: StackItemModel(horizontalAlignment: .fill))],
axis: .vertical, spacing: 0) axis: .vertical, spacing: 0)
return stack
}() }()
public lazy var stack: Stack<StackModel> = { public lazy var stack: Stack<StackModel> = {
let stack = Stack<StackModel>.createStack(with: [(view: planLabel, model: StackItemModel(horizontalAlignment: .fill, verticalAlignment: .leading)), return Stack<StackModel>.createStack(with: [(view: planLabel, model: StackItemModel(horizontalAlignment: .fill, verticalAlignment: .leading)),
(view: verticalStack, model: StackItemModel(horizontalAlignment: .fill, verticalAlignment: .leading))], (view: verticalStack, model: StackItemModel(horizontalAlignment: .fill, verticalAlignment: .leading))],
axis: .horizontal) axis: .horizontal)
return stack
}() }()
//------------------------------------------------------- //-------------------------------------------------------