From abc854e152222889403ed365ae0a5044890bb637 Mon Sep 17 00:00:00 2001
From: "Pfeil, Scott Robert" <scott.pfeil3@verizonwireless.com>
Date: Thu, 23 Jan 2020 11:01:36 -0500
Subject: [PATCH] List template change to molecules not required (for now)

---
 MVMCoreUI/Templates/ListPageTemplateModel.swift | 10 +++-------
 MVMCoreUI/Templates/MoleculeListTemplate.swift  | 13 +++++++++++++
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/MVMCoreUI/Templates/ListPageTemplateModel.swift b/MVMCoreUI/Templates/ListPageTemplateModel.swift
index d639d6f1..fe9c12c5 100644
--- a/MVMCoreUI/Templates/ListPageTemplateModel.swift
+++ b/MVMCoreUI/Templates/ListPageTemplateModel.swift
@@ -17,7 +17,7 @@ import Foundation
     public var isAtomicTabs: Bool?
 
     public var header: MoleculeModelProtocol?
-    public var molecules: [ListItemModelProtocol]
+    public var molecules: [ListItemModelProtocol]?
     public var footer: MoleculeModelProtocol?
     public var line: LineModel?
 
@@ -42,11 +42,7 @@ import Foundation
         let typeContainer = try decoder.container(keyedBy: CodingKeys.self)
         pageType = try typeContainer.decode(String.self, forKey: .pageType)
         screenHeading = try typeContainer.decodeIfPresent(String.self, forKey: .screenHeading)
-        
-        guard let molecules = try typeContainer.decodeMolecules(codingKey: .molecules) as? [ListItemModelProtocol] else {
-            throw JSONError.pathNotFound
-        }
-        self.molecules = molecules
+        molecules = try typeContainer.decodeMoleculesIfPresent(codingKey: .molecules) as? [ListItemModelProtocol]
         isAtomicTabs = try typeContainer.decodeIfPresent(Bool.self, forKey: .isAtomicTabs)
         header = try typeContainer.decodeMoleculeIfPresent(codingKey: .header)
         footer = try typeContainer.decodeMoleculeIfPresent(codingKey: .footer)
@@ -57,7 +53,7 @@ import Foundation
         var container = encoder.container(keyedBy: CodingKeys.self)
         try container.encode(pageType, forKey: .pageType)
         try container.encodeIfPresent(screenHeading, forKey: .screenHeading)
-        try container.encodeModels(molecules, forKey: .molecules)
+        try container.encodeModelsIfPresent(molecules, forKey: .molecules)
         try container.encodeIfPresent(isAtomicTabs, forKey: .isAtomicTabs)
         try container.encodeModelIfPresent(header, forKey: .header)
         try container.encodeModelIfPresent(footer, forKey: .footer)
diff --git a/MVMCoreUI/Templates/MoleculeListTemplate.swift b/MVMCoreUI/Templates/MoleculeListTemplate.swift
index 61e1121c..26310021 100644
--- a/MVMCoreUI/Templates/MoleculeListTemplate.swift
+++ b/MVMCoreUI/Templates/MoleculeListTemplate.swift
@@ -53,6 +53,19 @@ open class MoleculeListTemplate: ThreeLayerTableViewController, TemplateProtocol
         return molecule
     }
     
+    open override func shouldFinishProcessingLoad(_ loadObject: MVMCoreLoadObject, error: AutoreleasingUnsafeMutablePointer<MVMCoreErrorObject>) -> Bool {
+        let shouldFinish = super.shouldFinishProcessingLoad(loadObject, error: error)
+        // This template requires atleast one of the three layers.
+        if templateModel?.header == nil,
+            templateModel?.molecules?.count ?? 0 == 0,
+            templateModel?.footer == nil,
+            let errorObject = MVMCoreErrorObject(title: nil, message: MVMCoreGetterUtility.hardcodedString(withKey: HardcodedErrorUnableToProcess), messageToLog: "List template requires atleast one of the following: header, footer, molecules", code: CoreUIErrorCode.ErrorCodeListMolecule.rawValue, domain: ErrorDomainNative, location: String(describing: self)) {
+            error.pointee = errorObject
+            return false
+        }
+        return shouldFinish
+    }
+    
     open override func newDataBuildScreen() {
         super.newDataBuildScreen()
         setup()