From a4ede5281034db760bdedf7c766a6d5fbdc8d090 Mon Sep 17 00:00:00 2001 From: Kevin G Christiano Date: Tue, 14 Apr 2020 09:54:27 -0400 Subject: [PATCH] improved error presentation --- MVMCoreUI/Atomic/Atoms/TextFields/EntryField.swift | 10 +++++----- MVMCoreUI/Atomic/Atoms/TextFields/TextEntryField.swift | 9 --------- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/MVMCoreUI/Atomic/Atoms/TextFields/EntryField.swift b/MVMCoreUI/Atomic/Atoms/TextFields/EntryField.swift index 23225a57..5e874936 100644 --- a/MVMCoreUI/Atomic/Atoms/TextFields/EntryField.swift +++ b/MVMCoreUI/Atomic/Atoms/TextFields/EntryField.swift @@ -211,11 +211,11 @@ import UIKit entryFieldContainer.refreshUI() } - /// Method to override. - /// Intended to add the interactive content (i.e. textField) to the entryFieldContainer. - @objc open func setupFieldContainerContent(_ container: UIView) { - // To be overridden by subclass. - } + /** + Method to override. + Intended to add the interactive content (i.e. textField) to the entryFieldContainer. + */ + @objc open func setupFieldContainerContent(_ container: UIView) { } @objc open override func updateView(_ size: CGFloat) { super.updateView(size) diff --git a/MVMCoreUI/Atomic/Atoms/TextFields/TextEntryField.swift b/MVMCoreUI/Atomic/Atoms/TextFields/TextEntryField.swift index b267cd32..e9ba7d27 100644 --- a/MVMCoreUI/Atomic/Atoms/TextFields/TextEntryField.swift +++ b/MVMCoreUI/Atomic/Atoms/TextFields/TextEntryField.swift @@ -233,15 +233,6 @@ import UIKit entryFieldContainer.addGestureRecognizer(tap) accessibilityElements = [titleLabel, textField, feedbackLabel] - - // TODO: Remove these two lines. - let tapErr = UITapGestureRecognizer(target: self, action: #selector(tapForError)) - titleLabel.addGestureRecognizer(tapErr) - } - - // TODO: Remove this func - @objc func tapForError() { - showError.toggle() } @objc open override func updateView(_ size: CGFloat) {