From af2360c13a1b12f071adcd3d9d76cfed91e494ae Mon Sep 17 00:00:00 2001 From: "Murugan, Vimal" Date: Tue, 8 Nov 2022 18:41:27 +0530 Subject: [PATCH 01/10] fix for CXTDT_344190 --- MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift b/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift index 9e5881a4..ec94149b 100644 --- a/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift +++ b/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift @@ -757,8 +757,10 @@ public typealias ActionBlock = () -> () extension Label { public func reset() { - text = nil + //Weird issue. when cell reuse. text style is not getting reset.Fix for:CXTDT-344190 + //We need to reset the attribute text first and then text. Its working fine attributedText = nil + text = nil hero = nil textAlignment = .left originalAttributedString = nil From 34ef2e5c8196746d19b1039c1d9a40c34fd4af64 Mon Sep 17 00:00:00 2001 From: Keerthy Date: Mon, 21 Nov 2022 19:22:40 +0530 Subject: [PATCH 02/10] Added accessibilityText for ListOneColumnTextWithWhitespaceDividerTall DOPMO-153745 --- ...eColumnTextWithWhitespaceDividerTall.swift | 34 +++++++++++-------- ...mnTextWithWhitespaceDividerTallModel.swift | 7 +++- 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift index 62ee43f5..4a6e7c96 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift @@ -17,6 +17,7 @@ import Foundation public var stack: Stack public let headline = Label(fontStyle: .BoldTitleMedium) public let body = Label(fontStyle: .RegularBodySmall) + public var accessibilityText: String? = nil //-------------------------------------------------- // MARK: - Initializers @@ -41,7 +42,6 @@ import Foundation addMolecule(stack) stack.restack() isAccessibilityElement = true - updateAccessibilityLabel() } //-------------------------------------------------- @@ -53,7 +53,8 @@ import Foundation guard let model = model as? ListOneColumnTextWithWhitespaceDividerTallModel else { return } stack.updateContainedMolecules(with: [model.headline, model.body], delegateObject, additionalData) - updateAccessibilityLabel() + + updateAccessibilityLabel(model: model) } open override class func estimatedHeight(with model: MoleculeModelProtocol, _ delegateObject: MVMCoreUIDelegateObject?) -> CGFloat? { @@ -70,18 +71,23 @@ import Foundation // MARK: - Accessibility //---------------------------------------------------- - func updateAccessibilityLabel() { - - var message = "" - - if let headlineLabel = headline.text, !headlineLabel.isEmpty { - message += headlineLabel + ", " + func updateAccessibilityLabel(model: ListOneColumnTextWithWhitespaceDividerTallModel) { + if let accessibilityText = model.accessibilityText { + accessibilityLabel = accessibilityText + }else { + var message = "" + + if let headlineLabel = headline.text, !headlineLabel.isEmpty { + message += headlineLabel + ", " + } + + if let bodyLabel = body.text, !bodyLabel.isEmpty { + message += bodyLabel + } + + accessibilityLabel = message } - - if let bodyLabel = body.text, !bodyLabel.isEmpty { - message += bodyLabel - } - - accessibilityLabel = message + } + } diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift index c713b0d2..ed233607 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift @@ -17,14 +17,16 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol public static var identifier: String = "list1CTxtDiv2" public var headline: LabelModel public var body: LabelModel? + public var accessibilityText: String? //-------------------------------------------------- // MARK: - Initializer //-------------------------------------------------- - public init(headline: LabelModel, body: LabelModel?) { + public init(headline: LabelModel, body: LabelModel?, accessibilityText: String?) { self.headline = headline self.body = body + self.accessibilityText = accessibilityText super.init() } @@ -45,6 +47,7 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol case moleculeName case headline case body + case accessibilityText } //-------------------------------------------------- @@ -55,6 +58,7 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol let typeContainer = try decoder.container(keyedBy: CodingKeys.self) headline = try typeContainer.decode(LabelModel.self, forKey: .headline) body = try typeContainer.decodeIfPresent(LabelModel.self, forKey: .body) + accessibilityText = try typeContainer.decodeIfPresent(String.self, forKey: .accessibilityText) try super.init(from: decoder) } @@ -64,5 +68,6 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol try container.encode(moleculeName, forKey: .moleculeName) try container.encode(headline, forKey: .headline) try container.encodeIfPresent(body, forKey: .body) + try container.encodeIfPresent(accessibilityText, forKey: .accessibilityText) } } From dce172bb640b51a65236cb1f29012e831e1701d7 Mon Sep 17 00:00:00 2001 From: Krishna Kishore Bandaru Date: Mon, 28 Nov 2022 14:57:53 +0530 Subject: [PATCH 03/10] CXTDT-352289 - disabled clipboard actions --- .../Atoms/FormFields/TextFields/TextEntryField.swift | 1 + .../FormFields/TextFields/TextEntryFieldModel.swift | 7 +++++++ MVMCoreUI/BaseClasses/TextField.swift | 10 +++++++++- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift index 07260ac1..18749c8a 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift @@ -338,6 +338,7 @@ import UIKit placeholder = model.placeholder textField.shouldMaskWhileRecording = model.shouldMaskRecordedView ?? true + textField.enableClipboardActions = model.enableClipboardActions switch model.type { case .password, .secure: diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryFieldModel.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryFieldModel.swift index 7d2eb987..053a5ac5 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryFieldModel.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryFieldModel.swift @@ -37,6 +37,7 @@ public var clearTextOnTap: Bool = false public var displayFormat: String? public var displayMask: String? + public var enableClipboardActions: Bool = true //-------------------------------------------------- // MARK: - Initializers @@ -112,6 +113,7 @@ case clearTextOnTap case displayFormat case displayMask + case enableClipboardActions } //-------------------------------------------------- @@ -143,6 +145,10 @@ if let textAlignment = try typeContainer.decodeIfPresent(NSTextAlignment.self, forKey: .textAlignment) { self.textAlignment = textAlignment } + + if let enableClipboardActions = try typeContainer.decodeIfPresent(Bool.self, forKey: .enableClipboardActions) { + self.enableClipboardActions = enableClipboardActions + } } open override func encode(to encoder: Encoder) throws { @@ -157,5 +163,6 @@ try container.encode(enabledTextColor, forKey: .enabledTextColor) try container.encode(disabledTextColor, forKey: .disabledTextColor) try container.encode(clearTextOnTap, forKey: .clearTextOnTap) + try container.encode(enableClipboardActions, forKey: .enableClipboardActions) } } diff --git a/MVMCoreUI/BaseClasses/TextField.swift b/MVMCoreUI/BaseClasses/TextField.swift index 306b363f..1f5d1b09 100644 --- a/MVMCoreUI/BaseClasses/TextField.swift +++ b/MVMCoreUI/BaseClasses/TextField.swift @@ -23,7 +23,7 @@ public protocol TextInputDidDeleteProtocol: AnyObject { /// Set to true to hide the blinking textField cursor. public var hideBlinkingCaret = false - + public var enableClipboardActions: Bool = true public var shouldMaskWhileRecording: Bool = true //-------------------------------------------------- @@ -74,6 +74,14 @@ public protocol TextInputDidDeleteProtocol: AnyObject { super.deleteBackward() didDeleteDelegate?.textInputDidDelete() } + + open override func buildMenu(with builder: UIMenuBuilder) { + defer { super.buildMenu(with: builder) } + guard !enableClipboardActions else { return } + builder.remove(menu: .lookup) + } + + open override func canPerformAction(_ action: Selector, withSender sender: Any?) -> Bool { enableClipboardActions } } /// MARK:- MVMCoreViewProtocol From 8858018620b2437f3490355dcc5d44e809c3fe29 Mon Sep 17 00:00:00 2001 From: Krishna Kishore Bandaru Date: Fri, 2 Dec 2022 13:31:30 +0530 Subject: [PATCH 04/10] removed unused code --- MVMCoreUI/BaseClasses/TextField.swift | 6 ------ 1 file changed, 6 deletions(-) diff --git a/MVMCoreUI/BaseClasses/TextField.swift b/MVMCoreUI/BaseClasses/TextField.swift index 1f5d1b09..00a81464 100644 --- a/MVMCoreUI/BaseClasses/TextField.swift +++ b/MVMCoreUI/BaseClasses/TextField.swift @@ -75,12 +75,6 @@ public protocol TextInputDidDeleteProtocol: AnyObject { didDeleteDelegate?.textInputDidDelete() } - open override func buildMenu(with builder: UIMenuBuilder) { - defer { super.buildMenu(with: builder) } - guard !enableClipboardActions else { return } - builder.remove(menu: .lookup) - } - open override func canPerformAction(_ action: Selector, withSender sender: Any?) -> Bool { enableClipboardActions } } From 4963c311d44a4407678a06637f9308ffbc583d46 Mon Sep 17 00:00:00 2001 From: Krishna Kishore Bandaru Date: Fri, 2 Dec 2022 13:52:59 +0530 Subject: [PATCH 05/10] access specifier changed --- MVMCoreUI/BaseClasses/TextField.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MVMCoreUI/BaseClasses/TextField.swift b/MVMCoreUI/BaseClasses/TextField.swift index 00a81464..34e301a3 100644 --- a/MVMCoreUI/BaseClasses/TextField.swift +++ b/MVMCoreUI/BaseClasses/TextField.swift @@ -93,7 +93,7 @@ extension TextField: MVMCoreViewProtocol { /// MARK:- MoleculeViewProtocol extension TextField: MoleculeViewProtocol { - open func set(with model: MoleculeModelProtocol, _ delegateObject: MVMCoreUIDelegateObject?, _ additionalData: [AnyHashable: Any]?) { + public func set(with model: MoleculeModelProtocol, _ delegateObject: MVMCoreUIDelegateObject?, _ additionalData: [AnyHashable: Any]?) { if let color = model.backgroundColor?.uiColor { backgroundColor = color From a72f3cc3c1542a2d0fb2d2994b0f32d50d1309f9 Mon Sep 17 00:00:00 2001 From: Nandhini Rajendran Date: Fri, 9 Dec 2022 12:34:06 +0530 Subject: [PATCH 06/10] refactor to add resetAttributeStyle --- .../Atomic/Atoms/Views/Label/Label.swift | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift b/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift index 225d39c1..059c5637 100644 --- a/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift +++ b/MVMCoreUI/Atomic/Atoms/Views/Label/Label.swift @@ -241,18 +241,7 @@ public typealias ActionBlock = () -> () case left } - public func set(with model: MoleculeModelProtocol, _ delegateObject: MVMCoreUIDelegateObject? = nil, _ additionalData: [AnyHashable: Any]? = nil) { - - clauses = [] - text = nil - attributedText = nil - originalAttributedString = nil - shouldMaskWhileRecording = model.shouldMaskRecordedView ?? false - - guard let labelModel = model as? LabelModel else { return } - - text = labelModel.text - + @objc public func resetAttributeStyle() { /* * This is to address a reuse issue with iOS 13 and up. * Even if you set text & attributedText to nil, the moment you set text with a value, @@ -274,6 +263,21 @@ public typealias ActionBlock = () -> () self.attributedText = attributedString } + } + + public func set(with model: MoleculeModelProtocol, _ delegateObject: MVMCoreUIDelegateObject? = nil, _ additionalData: [AnyHashable: Any]? = nil) { + + clauses = [] + text = nil + attributedText = nil + originalAttributedString = nil + shouldMaskWhileRecording = model.shouldMaskRecordedView ?? false + + guard let labelModel = model as? LabelModel else { return } + + text = labelModel.text + + resetAttributeStyle() hero = labelModel.hero Label.setLabel(self, withHTML: labelModel.html) @@ -786,10 +790,8 @@ public typealias ActionBlock = () -> () extension Label { public func reset() { - //Weird issue. when cell reuse. text style is not getting reset.Fix for:CXTDT-344190 - //We need to reset the attribute text first and then text. Its working fine - attributedText = nil text = nil + attributedText = nil hero = nil textAlignment = .left originalAttributedString = nil From e66924dc1f9ce001402c60ea5f57c257d431ccd7 Mon Sep 17 00:00:00 2001 From: Krishna Kishore Bandaru Date: Mon, 12 Dec 2022 13:33:10 +0530 Subject: [PATCH 07/10] added setDefaults func --- .../TextFields/Dropdown Fields/BaseDropdownFieldModel.swift | 5 +++++ .../Atomic/Atoms/FormFields/TextFields/EntryFieldModel.swift | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/Dropdown Fields/BaseDropdownFieldModel.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/Dropdown Fields/BaseDropdownFieldModel.swift index 39701016..6c2131ac 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/Dropdown Fields/BaseDropdownFieldModel.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/Dropdown Fields/BaseDropdownFieldModel.swift @@ -26,6 +26,11 @@ case action } + open override func setDefaults() { + super.setDefaults() + enableClipboardActions = false + } + //-------------------------------------------------- // MARK: - Codec //-------------------------------------------------- diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/EntryFieldModel.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/EntryFieldModel.swift index 4e35ce30..7b3eee03 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/EntryFieldModel.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/EntryFieldModel.swift @@ -83,6 +83,9 @@ import Foundation case shouldMaskRecordedView } + /// Sets the default values. Should be called on init. + open func setDefaults() { } + //-------------------------------------------------- // MARK: - Validation Methods //-------------------------------------------------- @@ -119,6 +122,7 @@ import Foundation baseValue = text self.titleStateLabel = FormLabelModel(text: "") self.feedbackStateLabel = FormLabelModel(text: "") + setDefaults() } //-------------------------------------------------- @@ -157,6 +161,7 @@ import Foundation self.feedbackStateLabel = FormLabelModel(model: LabelModel(text: feedback ?? "", fontStyle: FormLabelModel.defaultFontStyle, textColor: Color(uiColor: .mvmCoolGray6))) + setDefaults() } public func encode(to encoder: Encoder) throws { From 7494d8664a171380f5ae2b9316f24738e43e1770 Mon Sep 17 00:00:00 2001 From: Kyle Matthew Hedden Date: Mon, 12 Dec 2022 13:18:17 -0500 Subject: [PATCH 08/10] add the provided color name to the error string --- MVMCoreUI/CustomPrimitives/Color.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MVMCoreUI/CustomPrimitives/Color.swift b/MVMCoreUI/CustomPrimitives/Color.swift index 42c7a600..b251f778 100644 --- a/MVMCoreUI/CustomPrimitives/Color.swift +++ b/MVMCoreUI/CustomPrimitives/Color.swift @@ -106,7 +106,7 @@ public final class Color: Codable { if colorString.hasPrefix("#") { hex = colorString.replacingOccurrences(of: "#", with: "") } else { - guard let hexString = UIColor.names[colorString]?.hex else { throw ColorError.badName(reason: "Check the spelling of your color.") } + guard let hexString = UIColor.names[colorString]?.hex else { throw ColorError.badName(reason: "Check the spelling of your color: \(colorString)") } hex = hexString.replacingOccurrences(of: "#", with: "") name = colorString } From 9dd400f894b5742003341591a9e049e42a3aa302 Mon Sep 17 00:00:00 2001 From: Keerthy Date: Tue, 20 Dec 2022 19:58:30 +0530 Subject: [PATCH 09/10] Accessibility fix for PRODDEF-1201 Accessibility fix to provide custom accessibilityText for list1CTxtDiv3 --- ...eColumnTextWithWhitespaceDividerTall.swift | 26 +++++++------------ ...mnTextWithWhitespaceDividerTallModel.swift | 5 ---- 2 files changed, 10 insertions(+), 21 deletions(-) diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift index 4a6e7c96..d93cd0f2 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift @@ -17,7 +17,6 @@ import Foundation public var stack: Stack public let headline = Label(fontStyle: .BoldTitleMedium) public let body = Label(fontStyle: .RegularBodySmall) - public var accessibilityText: String? = nil //-------------------------------------------------- // MARK: - Initializers @@ -72,22 +71,17 @@ import Foundation //---------------------------------------------------- func updateAccessibilityLabel(model: ListOneColumnTextWithWhitespaceDividerTallModel) { - if let accessibilityText = model.accessibilityText { - accessibilityLabel = accessibilityText - }else { - var message = "" - - if let headlineLabel = headline.text, !headlineLabel.isEmpty { - message += headlineLabel + ", " - } - - if let bodyLabel = body.text, !bodyLabel.isEmpty { - message += bodyLabel - } - - accessibilityLabel = message + + var message = "" + + if let headlineLabel = model.headline.accessibilityText ?? headline.text, !headlineLabel.isEmpty { + message += headlineLabel + ", " } - } + if let bodyLabel = model.body?.accessibilityText ?? body.text, !bodyLabel.isEmpty { + message += bodyLabel + } + accessibilityLabel = message + } } diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift index ed233607..4527dba0 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift @@ -17,7 +17,6 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol public static var identifier: String = "list1CTxtDiv2" public var headline: LabelModel public var body: LabelModel? - public var accessibilityText: String? //-------------------------------------------------- // MARK: - Initializer @@ -26,7 +25,6 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol public init(headline: LabelModel, body: LabelModel?, accessibilityText: String?) { self.headline = headline self.body = body - self.accessibilityText = accessibilityText super.init() } @@ -47,7 +45,6 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol case moleculeName case headline case body - case accessibilityText } //-------------------------------------------------- @@ -58,7 +55,6 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol let typeContainer = try decoder.container(keyedBy: CodingKeys.self) headline = try typeContainer.decode(LabelModel.self, forKey: .headline) body = try typeContainer.decodeIfPresent(LabelModel.self, forKey: .body) - accessibilityText = try typeContainer.decodeIfPresent(String.self, forKey: .accessibilityText) try super.init(from: decoder) } @@ -68,6 +64,5 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol try container.encode(moleculeName, forKey: .moleculeName) try container.encode(headline, forKey: .headline) try container.encodeIfPresent(body, forKey: .body) - try container.encodeIfPresent(accessibilityText, forKey: .accessibilityText) } } From af97c5d38793287854df8183fef6fb7c56cbfb79 Mon Sep 17 00:00:00 2001 From: Keerthy Date: Fri, 23 Dec 2022 23:33:18 +0530 Subject: [PATCH 10/10] addressed review comments --- .../OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift | 1 + .../ListOneColumnTextWithWhitespaceDividerTallModel.swift | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift index d93cd0f2..772ec5ac 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTall.swift @@ -64,6 +64,7 @@ import Foundation super.reset() headline.setFontStyle(.BoldTitleMedium) body.setFontStyle(.RegularBodySmall) + accessibilityLabel = nil } //---------------------------------------------------- diff --git a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift index 4527dba0..c713b0d2 100644 --- a/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift +++ b/MVMCoreUI/Atomic/Molecules/DesignedComponents/SectionDividers/OneColumn/ListOneColumnTextWithWhitespaceDividerTallModel.swift @@ -22,7 +22,7 @@ public class ListOneColumnTextWithWhitespaceDividerTallModel: ListItemModel, Mol // MARK: - Initializer //-------------------------------------------------- - public init(headline: LabelModel, body: LabelModel?, accessibilityText: String?) { + public init(headline: LabelModel, body: LabelModel?) { self.headline = headline self.body = body super.init()