mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

addressed code review comments

Browse Source
This commit is contained in:
Krishna Kishore Bandaru 2023-11-01 18:11:22 +05:30
parent 7b4dd51a74
commit 975882d47c
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MVMCoreUI/Accessibility/AccessibilityHandler.swift
View File

@ -100,9 +100,10 @@ open class AccessibilityHandler {
/** /**
This method return first focused element from the screen. This method return first focused element from the screen.
If navigationBar is hidden then we are returning nil so that voice over will shift to the first interactive element.
*/ */
open func getFirstFocusedElementOnScreen() -> Any? { open func getFirstFocusedElementOnScreen() -> Any? {
(delegate as? UIViewController)?.navigationController?.navigationBar ((delegate as? PageProtocol)?.pageModel?.navigationBar?.hidden ?? false) ? nil : (delegate as? UIViewController)?.navigationController?.navigationBar
} }
/** /**
@ -245,6 +246,7 @@ extension AccessibilityHandler {
/** /**
To notify AccessibilityHandler about the page visibility changes To notify AccessibilityHandler about the page visibility changes
*/ */
//TODO: Revisit why we need a behavior as a notifier.
open class AccessibilityHandlerBehavior: PageVisibilityBehavior, PageMoleculeTransformationBehavior { open class AccessibilityHandlerBehavior: PageVisibilityBehavior, PageMoleculeTransformationBehavior {
public let accessibilityHandler: AccessibilityHandler? public let accessibilityHandler: AccessibilityHandler?

2
MVMCoreUI/Atomic/Atoms/Selectors/ToggleModel.swift
View File

@ -7,7 +7,7 @@
// //
public class ToggleModel: MoleculeModelProtocol, FormFieldProtocol, Identifiable { public class ToggleModel: MoleculeModelProtocol, FormFieldProtocol {
//-------------------------------------------------- //--------------------------------------------------
// MARK: - Properties // MARK: - Properties
//-------------------------------------------------- //--------------------------------------------------