From 0d6fc3d15dc8a8b72b6e7f97d60840f23416ff14 Mon Sep 17 00:00:00 2001 From: Arun Kumar Chintakrinda Date: Mon, 5 Aug 2024 20:25:24 +0530 Subject: [PATCH 1/4] bugfix PRODDEF-26055 Issue #2, added missing view to getAcessibilityElements func --- MVMCoreUI/Managers/SubNav/SubNavManagerController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift index 7ac663d6..8918c522 100644 --- a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift +++ b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift @@ -345,7 +345,7 @@ open class SubNavManagerController: ViewController, MVMCoreViewManagerProtocol, } @objc public func getAccessibilityElements() -> [Any]? { - [tabs] + [tabs, subNavigationController.view!] } open override func observeForResponseJSONUpdates() { From 100ede48faba98e73a085e8eefce237c7210c595 Mon Sep 17 00:00:00 2001 From: Arun Kumar Chintakrinda Date: Mon, 5 Aug 2024 20:32:09 +0530 Subject: [PATCH 2/4] added condition to check if view is available --- MVMCoreUI/Managers/SubNav/SubNavManagerController.swift | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift index 8918c522..50d5063e 100644 --- a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift +++ b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift @@ -345,7 +345,10 @@ open class SubNavManagerController: ViewController, MVMCoreViewManagerProtocol, } @objc public func getAccessibilityElements() -> [Any]? { - [tabs, subNavigationController.view!] + guard let navigationControllerView = subNavigationController.view else { + return [tabs] + } + return [tabs, navigationControllerView] } open override func observeForResponseJSONUpdates() { From 2ce1b671bdc461bb9b01411edf9d11c18032f9ba Mon Sep 17 00:00:00 2001 From: Arun Kumar Chintakrinda Date: Tue, 6 Aug 2024 17:18:56 +0530 Subject: [PATCH 3/4] added comment --- MVMCoreUI/Managers/SubNav/SubNavManagerController.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift index 50d5063e..6883dd9b 100644 --- a/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift +++ b/MVMCoreUI/Managers/SubNav/SubNavManagerController.swift @@ -345,6 +345,7 @@ open class SubNavManagerController: ViewController, MVMCoreViewManagerProtocol, } @objc public func getAccessibilityElements() -> [Any]? { + //forcing lazy view load to have accessibility elements available in time for the accessibility manager guard let navigationControllerView = subNavigationController.view else { return [tabs] } From d308bfc9571930c3d511778603822a674754128c Mon Sep 17 00:00:00 2001 From: Matt Bruce Date: Thu, 8 Aug 2024 15:31:17 -0500 Subject: [PATCH 4/4] CXTDT-598142 - RadioButton fix QA3||MVA||Prepay||IOS - 22053||Devices||From Add device screen Signed-off-by: Matt Bruce --- MVMCoreUI/Atomic/Atoms/Selectors/RadioButton.swift | 5 ----- 1 file changed, 5 deletions(-) diff --git a/MVMCoreUI/Atomic/Atoms/Selectors/RadioButton.swift b/MVMCoreUI/Atomic/Atoms/Selectors/RadioButton.swift index 7fe3f9a4..0ecd920b 100644 --- a/MVMCoreUI/Atomic/Atoms/Selectors/RadioButton.swift +++ b/MVMCoreUI/Atomic/Atoms/Selectors/RadioButton.swift @@ -144,11 +144,6 @@ import VDS //-------------------------------------------------- // MARK: - MoleculeViewProtocol //-------------------------------------------------- - - open func needsToBeConstrained() -> Bool { true } - - public func horizontalAlignment() -> UIStackView.Alignment { .leading } - public func updateView(_ size: CGFloat) {} }