code review

MVMCoreUI/Atoms/Buttons/PrimaryButton.m

@@ -31,7 +31,6 @@
 
 @property (strong, nonatomic) NSMutableArray <MFTextField *>*textFields;
 @property (nonatomic, readwrite, assign) PrimaryButtonType primaryButtonType;
-@property (nonnull, strong, nonatomic) FormValidator* formValidator;
 
 @end
 
@@ -682,7 +681,6 @@
 
 - (void)setEnabledByValidity {
 
-    
     __block BOOL valid = YES;
     [self.textFields enumerateObjectsUsingBlock:^(id  _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) {
         if (!((MFTextField *)obj).valid) {

MVMCoreUI/Atoms/TextFields/MFTextField.m

@@ -35,6 +35,7 @@
 
 @property (weak, nonatomic) IBOutlet NSLayoutConstraint *textContainerRightPin;
 @property (weak, nonatomic) IBOutlet NSLayoutConstraint *errorLableRightPin;
+@property (nonatomic) BOOL isMolecule;
 
 @end
 
@@ -48,6 +49,13 @@
         self.label.font = [MFStyler fontForTextFieldUnderLabel];
         [MFStyler styleTextField:self.textField];
         [self.dashLine updateView:size];
+        
+        if (self.isMolecule) {
+            [self setVerticalPadding:[MFStyler defaultHorizontalPaddingForApplicationWidth]];
+
+        } else {
+            [self setVerticalPadding:0];
+        }
     }];
 }
 
@@ -109,14 +117,14 @@
 }
 
 - (void)setWithJSON:(NSDictionary *)json delegate:(nullable id<UITextFieldDelegate, MFTextFieldDelegate>)delegate additionalData:(NSDictionary *)additionalData {
-    [FormValidator setupValidationWithMolecule:self delegate: (id<FormValidationProtocol>)delegate];
     
+    self.isMolecule = YES;
+    [FormValidator setupValidationWithMolecule:self delegate:(id<FormValidationProtocol>)delegate];
     [self setWithMap:json bothDelegates:delegate];
     
     FormValidator *formValidator = [FormValidator getFormValidatorForDelegate:(id<FormValidationProtocol>)delegate];
     self.mfTextFieldDelegate = formValidator;
     self.uiTextFieldDelegate = formValidator;    
-    [self setVerticalPadding:[MFStyler defaultHorizontalPaddingForApplicationWidth]];
 }
 
 - (void)setVerticalPadding:(CGFloat) padding {
@@ -134,7 +142,6 @@
     MFTextField *textField = [self mfTextField];
     textField.translatesAutoresizingMaskIntoConstraints = NO;
     [textField setWithJSON:map delegate:delegate additionalData:nil];
-    [textField setVerticalPadding:0];
     return textField;
 }
 
@@ -319,7 +326,10 @@
 }
 
 - (void)setWithMap:(nullable NSDictionary *)map bothDelegates:(nullable id<UITextFieldDelegate, MFTextFieldDelegate>)delegate {
-    if (map.count > 0) {
+    if (map.count == 0) {
+        return;
+    }
+    
     [MVMCoreUICommonViewsUtility addDismissToolbar:self.textField delegate:delegate];
     [self setBothTextFieldDelegates:delegate];
     
@@ -367,7 +377,6 @@
         [self setDefaultValidationBlock];
     }
 }
-}
 
 - (void)setValidationBlock:(BOOL (^)(NSString * _Nullable))validationBlock {
     _validationBlock = validationBlock;