mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

code review

Browse Source
This commit is contained in:
Suresh, Kamlesh 2019-02-14 14:58:44 -05:00
parent f5b580ba50
commit 8a73be75e1
3 changed files with 13 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
MVMCoreUI/BaseControllers/MFViewController.m
View File

@ -326,13 +326,14 @@
- (BOOL)isOverridingRightButton { - (BOOL)isOverridingRightButton {
return [self.loadObject.pageJSON dict:@"supportLink"]; if ([self.loadObject.pageJSON dict:@"supportLink"]) {
} [[MVMCoreActionHandler sharedActionHandler] handleActionWithDictionary:[self.loadObject.pageJSON dict:@"supportLink"]
additionalData:nil
- (void)rightPanelButtonPressed { delegate:self];
[[MVMCoreActionHandler sharedActionHandler] handleActionWithDictionary:[self.loadObject.pageJSON dict:@"supportLink"] return YES;
additionalData:nil } else {
delegate:self]; return NO;
}
} }
- (void)setSupportShouldBeAccessible:(BOOL)supportShouldBeAccessible { - (void)setSupportShouldBeAccessible:(BOOL)supportShouldBeAccessible {

2
MVMCoreUI/Containers/SplitViewController/MVMCoreUIDetailViewProtocol.h
View File

@ -24,8 +24,6 @@ NS_ASSUME_NONNULL_BEGIN
// Called when the back button is pressed. Overwrite for special functionality. // Called when the back button is pressed. Overwrite for special functionality.
- (void)backButtonPressed; - (void)backButtonPressed;
- (void)leftPanelButtonPressed;
- (void)rightPanelButtonPressed;
- (BOOL)isOverridingRightButton; - (BOOL)isOverridingRightButton;
- (BOOL)isOverridingLeftButton; - (BOOL)isOverridingLeftButton;

18
MVMCoreUI/Containers/SplitViewController/MVMCoreUISplitViewController.m
View File

@ -146,13 +146,9 @@ CGFloat const PanelAnimationDuration = 0.2;
// If Viewcontroller confirms to protocol and implements the the method leftPanelButtonPressed // If Viewcontroller confirms to protocol and implements the the method leftPanelButtonPressed
if ([viewController conformsToProtocol:@protocol(MVMCoreUIDetailViewProtocol)] if ([viewController conformsToProtocol:@protocol(MVMCoreUIDetailViewProtocol)]
&& [viewController respondsToSelector:@selector(leftPanelButtonPressed)] && [viewController respondsToSelector:@selector(isOverridingLeftButton)]
&& [viewController respondsToSelector:@selector(isOverridingLeftButton)]) { && [((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) leftPanelButtonPressed]) {
return;
if ([((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) isOverridingLeftButton]) {
[((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) leftPanelButtonPressed];
return;
}
} }
if (self.mainViewLeading.constant < .1) { if (self.mainViewLeading.constant < .1) {
@ -188,12 +184,8 @@ CGFloat const PanelAnimationDuration = 0.2;
// If Viewcontroller confirms to protocol and implements the the method rightPanelButtonPressed // If Viewcontroller confirms to protocol and implements the the method rightPanelButtonPressed
if ([viewController conformsToProtocol:@protocol(MVMCoreUIDetailViewProtocol)] if ([viewController conformsToProtocol:@protocol(MVMCoreUIDetailViewProtocol)]
&& [viewController respondsToSelector:@selector(isOverridingRightButton)] && [viewController respondsToSelector:@selector(isOverridingRightButton)]
&& [viewController respondsToSelector:@selector(rightPanelButtonPressed)]) { && [((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) isOverridingRightButton]) {
return;
if ([((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) isOverridingRightButton]) {
[((UIViewController <MVMCoreUIDetailViewProtocol> *)viewController) rightPanelButtonPressed];
return;
}
} }
if (self.mainViewTrailing.constant < .1) { if (self.mainViewTrailing.constant < .1) {