mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

updated based on review comments

Browse Source
This commit is contained in:
Damodaram 2020-09-16 20:28:55 +05:30
parent 483a50dd98
commit 88a6421a7e
3 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
MVMCoreUI/Atomic/Atoms/FormFields/TextFields/BaseDropdownEntryField.swift
View File

@ -94,13 +94,8 @@ import UIKit
} }
private func performDropdownAction() { private func performDropdownAction() {
if let actionModel = baseDropdownEntryFieldModel?.action, var actionMap = actionModel.toJSON() { if let actionModel = baseDropdownEntryFieldModel?.action, let actionMap = actionModel.toJSON() {
if var analyticsData = actionMap[KeyAnalyticsData] as? JSONDictionary { MVMCoreActionHandler.shared()?.handleAction(with: actionMap, additionalData: baseDropdownEntryFieldModel?.toJSON(), delegateObject: delegateObject)
let taggedValue = (analyticsData[KeyAdobeTrackerLinkName] as? String ?? "") + (text ?? "")
analyticsData[KeyAdobeTrackerLinkName] = taggedValue
actionMap[KeyAnalyticsData] = analyticsData
}
MVMCoreActionHandler.shared()?.handleAction(with: actionMap, additionalData: nil, delegateObject: delegateObject)
} }
} }
} }

2
MVMCoreUI/Utility/MVMCoreUIConstants.h
View File

@ -42,8 +42,6 @@ extern NSString * const KeyIsOpaque;
extern NSString * const KeyFieldKey; extern NSString * const KeyFieldKey;
extern NSString * const KeyRequired; extern NSString * const KeyRequired;
extern NSString * const KeyAnalyticsData;
extern NSString * const KeyAdobeTrackerLinkName;
#pragma mark - Values #pragma mark - Values

2
MVMCoreUI/Utility/MVMCoreUIConstants.m
View File

@ -40,8 +40,6 @@ NSString * const KeyTextColor = @"textColor";
NSString * const KeyIsHidden = @"isHidden"; NSString * const KeyIsHidden = @"isHidden";
NSString * const KeyIsOpaque = @"isOpaque"; NSString * const KeyIsOpaque = @"isOpaque";
NSString * const KeyAnalyticsData = @"analyticsData";
NSString * const KeyAdobeTrackerLinkName = @"vzwi.mvmapp.LinkName";
#pragma mark - Values #pragma mark - Values