mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Scott feedback implemented

Browse Source
This commit is contained in:
Damodaram 2020-06-18 08:26:12 +05:30
parent 4db0d495bc
commit 82fbf6dc8e
5 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MVMCoreUI/Atomic/Molecules/Items/CarouselItemModel.swift
View File

@ -10,7 +10,7 @@ import Foundation
@objcMembers public class CarouselItemModel: MoleculeCollectionItemModel, CarouselItemModelProtocol { @objcMembers public class CarouselItemModel: MoleculeCollectionItemModel, CarouselItemModelProtocol {
public var analyticsData: [String : String]? public var analyticsData: JSONValueDictionary?
//-------------------------------------------------- //--------------------------------------------------
// MARK: - Properties // MARK: - Properties
@ -41,7 +41,7 @@ import Foundation
let typeContainer = try decoder.container(keyedBy: CodingKeys.self) let typeContainer = try decoder.container(keyedBy: CodingKeys.self)
peakingUI = try typeContainer.decodeIfPresent(Bool.self, forKey: .peakingUI) peakingUI = try typeContainer.decodeIfPresent(Bool.self, forKey: .peakingUI)
peakingArrowColor = try typeContainer.decodeIfPresent(Color.self, forKey: .peakingArrowColor) peakingArrowColor = try typeContainer.decodeIfPresent(Color.self, forKey: .peakingArrowColor)
analyticsData = try typeContainer.decodeIfPresent([String:String].self, forKey: .analyticsData) analyticsData = try typeContainer.decodeIfPresent(JSONValueDictionary.self, forKey: .analyticsData)
try super.init(from: decoder) try super.init(from: decoder)
} }

7
MVMCoreUI/Atomic/Organisms/Carousel.swift
View File

@ -302,11 +302,8 @@ open class Carousel: View {
} }
func trackSwipeActionAnalyticsforIndex(_ index : Int){ func trackSwipeActionAnalyticsforIndex(_ index : Int){
guard let itemModel = molecules?[index], guard let itemModel = molecules?[index],
var analyticsData = itemModel.analyticsData, let viewControllerObject = delegateObject?.moleculeDelegate as? MVMCoreViewControllerProtocol else { return }
let viewcontrollerObject = delegateObject?.moleculeDelegate as? MVMCoreViewControllerProtocol else { return } MVMCoreUILoggingHandler.shared()?.defaultLogAction(forController: viewControllerObject, actionInformation: itemModel.toJSON(), additionalData: nil)
analyticsData[KeyAdobeTrackerPageType] = viewcontrollerObject.loadObject??.pageType
analyticsData["ClassName"] = String(describing: type(of: viewcontrollerObject))
MVMCoreUILoggingHandler.shared()?.defaultLogAction(forController: viewcontrollerObject, actionInformation: itemModel.toJSON(), additionalData: nil)
} }
} }

7
MVMCoreUI/Atomic/Protocols/ModelProtocols/CarouselItemModelProtocol.swift
View File

@ -10,11 +10,12 @@ import Foundation
public protocol CarouselItemModelProtocol: ContainerModelProtocol { public protocol CarouselItemModelProtocol: ContainerModelProtocol {
var analyticsData: [String:String]? { get } var analyticsData: JSONValueDictionary? { get set }
} }
public extension CarouselItemModelProtocol { public extension CarouselItemModelProtocol {
var analyticsData: [String:String]? { var analyticsData: JSONValueDictionary? {
get { return nil} get { return nil }
set{ analyticsData = newValue }
} }
} }

4
MVMCoreUI/Utility/MVMCoreUIConstants.h
View File

@ -82,7 +82,3 @@ typedef NS_ENUM(NSInteger, CoreUIErrorCode) {
#pragma mark - Apple Design Guidelines #pragma mark - Apple Design Guidelines
extern CGFloat const MinimumTappableArea; extern CGFloat const MinimumTappableArea;
#pragma mark - Adobe Action Tracking
extern NSString * const KeyAdobeTrackerPageType;

4
MVMCoreUI/Utility/MVMCoreUIConstants.m
View File

@ -74,7 +74,3 @@ NSString * const KeyHandScroll = @"hand_scroll";
#pragma mark - Apple Design Guidelines #pragma mark - Apple Design Guidelines
CGFloat const MinimumTappableArea = 44.0f; CGFloat const MinimumTappableArea = 44.0f;
#pragma mark - Adobe Action Tracking
NSString * const KeyAdobeTrackerPageType = @"vzwi.mvmapp.PageType";