mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'hotfix/checkbox-showError' into 'release/20_1_0'

Browse Source 
CXTDT-599891 - taking out showError for now

### Summary
Checkboxes have never had an error state, so until we figure out the default state, we need to turn it off. 

### JIRA Ticket
https://onejira.verizon.com/browse/CXTDT-599891

Co-authored-by: Matt Bruce <matt.bruce@verizon.com>

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core_ui/-/merge_requests/1169
This commit is contained in:
Hedden, Kyle Matthew 2024-08-09 22:52:31 +00:00
commit 696b6b99d0
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
MVMCoreUI/Atomic/Atoms/Selectors/Checkbox.swift
View File

@ -143,7 +143,8 @@ import VDS
MVMCoreDispatchUtility.performBlock(onMainThread: { [weak self] in MVMCoreDispatchUtility.performBlock(onMainThread: { [weak self] in
guard let self = self else { return } guard let self = self else { return }
let isValid = viewModel.isValid ?? true let isValid = viewModel.isValid ?? true
showError = !isValid //TODO: Fix issue with default state
//showError = !isValid
isEnabled = viewModel.enabled isEnabled = viewModel.enabled
}) })

3
MVMCoreUI/Atomic/Atoms/Views/CheckboxLabel.swift
View File

@ -75,7 +75,8 @@ import VDS
MVMCoreDispatchUtility.performBlock(onMainThread: { [weak self] in MVMCoreDispatchUtility.performBlock(onMainThread: { [weak self] in
guard let self = self else { return } guard let self = self else { return }
let isValid = viewModel.checkbox.isValid ?? true let isValid = viewModel.checkbox.isValid ?? true
showError = !isValid //TODO: Fix issue with default state
//showError = !isValid
errorText = viewModel.checkbox.errorMessage errorText = viewModel.checkbox.errorMessage
isEnabled = viewModel.checkbox.enabled isEnabled = viewModel.checkbox.enabled
}) })