mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed comment and used ternary operator based on code review

Browse Source
This commit is contained in:
Robinson, Blake 2019-09-05 10:28:50 -04:00
parent a3757adacd
commit 5adce50053
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
MVMCoreUI/TopAlert/MVMCoreUITopAlertMainView.m
View File

@ -173,16 +173,7 @@
if (closeButton && !self.closeButton) { if (closeButton && !self.closeButton) {
self.closeButton = [self addCloseButtonWithAnimationDelegate:animationDelegate]; self.closeButton = [self addCloseButtonWithAnimationDelegate:animationDelegate];
//Based on the way the code is ordered now in lines 68-70, contentColor should [self.closeButton setTintColor:self.contentColor ?:[UIColor whiteColor]];
//still be nil when setupCloseButton is called, making a nil check superflous.
//Since this ordering could change, however, it would be best to handle a situation
//in which the contentColor is black, for example, and the closeButton
//would need to be black as well.
if (self.contentColor == nil) {
[self.closeButton setTintColor:[UIColor whiteColor]];
} else {
[self.closeButton setTintColor:self.contentColor];
}
} else if (!closeButton && self.closeButton) { } else if (!closeButton && self.closeButton) {
[self.closeButton removeFromSuperview]; [self.closeButton removeFromSuperview];
self.closeButton = nil; self.closeButton = nil;