From ab1ee241560e90684d53b6e8254662968c94ea9b Mon Sep 17 00:00:00 2001 From: Subhankar Date: Tue, 7 Dec 2021 21:46:38 +0530 Subject: [PATCH 1/3] added spacing to unordered list --- .../VerticalCombinationViews/Lists/UnOrderedListModel.swift | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift index 4013f3aa..db69eaec 100644 --- a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift +++ b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift @@ -36,7 +36,8 @@ import Foundation for molecule in list { models.append(MoleculeStackItemModel(with: StringAndMoleculeModel(string: bulletChar, molecule: molecule, stringColor: bulletColor))) } - super.init(molecules: models, spacing: 0) + /// changing as per confluence, as spacing between each list item is 16 + super.init(molecules: models, spacing: PaddingDefaultVerticalSpacing / 2) } public override func encode(to encoder: Encoder) throws { From 557a532b3faf4a3fa673fa6b252d09afb0ee14c8 Mon Sep 17 00:00:00 2001 From: Subhankar Date: Tue, 7 Dec 2021 22:03:11 +0530 Subject: [PATCH 2/3] change in variable --- .../VerticalCombinationViews/Lists/UnOrderedListModel.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift index db69eaec..19165cd7 100644 --- a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift +++ b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift @@ -37,7 +37,7 @@ import Foundation models.append(MoleculeStackItemModel(with: StringAndMoleculeModel(string: bulletChar, molecule: molecule, stringColor: bulletColor))) } /// changing as per confluence, as spacing between each list item is 16 - super.init(molecules: models, spacing: PaddingDefaultVerticalSpacing / 2) + super.init(molecules: models, spacing: Four) } public override func encode(to encoder: Encoder) throws { From d9aa6cf6628e3bee5e53e9e4acef8b4790207f17 Mon Sep 17 00:00:00 2001 From: Subhankar Date: Tue, 7 Dec 2021 22:08:35 +0530 Subject: [PATCH 3/3] removed comment --- .../VerticalCombinationViews/Lists/UnOrderedListModel.swift | 1 - 1 file changed, 1 deletion(-) diff --git a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift index 19165cd7..1b11891b 100644 --- a/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift +++ b/MVMCoreUI/Atomic/Molecules/VerticalCombinationViews/Lists/UnOrderedListModel.swift @@ -36,7 +36,6 @@ import Foundation for molecule in list { models.append(MoleculeStackItemModel(with: StringAndMoleculeModel(string: bulletChar, molecule: molecule, stringColor: bulletColor))) } - /// changing as per confluence, as spacing between each list item is 16 super.init(molecules: models, spacing: Four) }