From 522f7a4be299fa745c72a996dbca583eb345fddb Mon Sep 17 00:00:00 2001 From: panxi Date: Mon, 29 Apr 2019 17:17:21 -0400 Subject: [PATCH] add index to tab for accessibility --- MVMCoreUI/Containers/TabBarController/TopTabbar.m | 1 + MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings | 1 + .../SupportingFiles/Strings/es-MX.lproj/Localizable.strings | 1 + MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings | 1 + 4 files changed, 4 insertions(+) diff --git a/MVMCoreUI/Containers/TabBarController/TopTabbar.m b/MVMCoreUI/Containers/TabBarController/TopTabbar.m index 9b4e632c..6828f4a7 100644 --- a/MVMCoreUI/Containers/TabBarController/TopTabbar.m +++ b/MVMCoreUI/Containers/TabBarController/TopTabbar.m @@ -199,6 +199,7 @@ static NSString * const COLLECTION_CELL_ID = @"cell"; NSString *accLabel = [title stringByAppendingString:[MVMCoreUIUtility hardcodedStringWithKey:@"AccTab"]]; cell.contentView.accessibilityLabel = accLabel; + cell.contentView.accessibilityValue = [NSString stringWithFormat:[MVMCoreUIUtility hardcodedStringWithKey:@"AccTabIndex"],indexPath.row + 1, [self.datasource numberOfTopTabbarItems:self]]; [cell.contentView setAccessibilityHint:[MVMCoreUIUtility hardcodedStringWithKey:@"AccTabHint"]]; if (indexPath.row == self.selectedIndex) { diff --git a/MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings b/MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings index 472bb9b6..c622ccc4 100644 --- a/MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings +++ b/MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings @@ -11,6 +11,7 @@ // Tab "AccTab" = ", tab"; "AccTabHint" = "Double tap to select."; +"AccTabIndex" = "%ld of %ld"; // top alert "toptabbar_tab_selected" = ", tab, Selected"; "AccTopAlertClosed" = "Top alert notification is closed."; diff --git a/MVMCoreUI/SupportingFiles/Strings/es-MX.lproj/Localizable.strings b/MVMCoreUI/SupportingFiles/Strings/es-MX.lproj/Localizable.strings index f640133a..fc314f81 100644 --- a/MVMCoreUI/SupportingFiles/Strings/es-MX.lproj/Localizable.strings +++ b/MVMCoreUI/SupportingFiles/Strings/es-MX.lproj/Localizable.strings @@ -10,6 +10,7 @@ // Tab "AccTab" = ", pestaña"; "AccTabHint" = "Toca dos veces para seleccionar."; +"AccTabIndex" = "%ld de %ld"; // top alert "toptabbar_tab_selected" = ", pestaña, Seleccionado"; "AccTopAlertClosed" = "La notificación de alerta máxima está desactivada."; diff --git a/MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings b/MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings index f640133a..fc314f81 100644 --- a/MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings +++ b/MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings @@ -10,6 +10,7 @@ // Tab "AccTab" = ", pestaña"; "AccTabHint" = "Toca dos veces para seleccionar."; +"AccTabIndex" = "%ld de %ld"; // top alert "toptabbar_tab_selected" = ", pestaña, Seleccionado"; "AccTopAlertClosed" = "La notificación de alerta máxima está desactivada.";