From 473fe1b720a74b3faa200ce8484cc4eb54b48a22 Mon Sep 17 00:00:00 2001 From: "Pfeil, Scott Robert" Date: Wed, 16 Jan 2019 17:25:49 -0500 Subject: [PATCH] warning fix --- MVMCoreUI/Atoms/TextFields/MFTextField.h | 3 +++ MVMCoreUI/Atoms/Views/MFTextView.h | 5 +++++ MVMCoreUI/Containers/TabBarController/TopTabbar.m | 4 +--- MVMCoreUI/TopAlert/MVMCoreUITopAlertExpandableView.m | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/MVMCoreUI/Atoms/TextFields/MFTextField.h b/MVMCoreUI/Atoms/TextFields/MFTextField.h index e3e12a04..1be2f3e3 100644 --- a/MVMCoreUI/Atoms/TextFields/MFTextField.h +++ b/MVMCoreUI/Atoms/TextFields/MFTextField.h @@ -23,6 +23,9 @@ // Called when the entered text becomes invalid based on the validation block - (void)entryIsInvalid:(nullable MFTextField *)textfield; +// Dismisses the keyboard. +- (void)dismissFieldInput:(nullable id)sender; + @end @interface MFTextField : MFView diff --git a/MVMCoreUI/Atoms/Views/MFTextView.h b/MVMCoreUI/Atoms/Views/MFTextView.h index ec1a3b9a..b1c80bdd 100644 --- a/MVMCoreUI/Atoms/Views/MFTextView.h +++ b/MVMCoreUI/Atoms/Views/MFTextView.h @@ -14,6 +14,11 @@ @protocol MFTextViewDelegate +@optional + +// Dismisses the keyboard. +- (void)dismissFieldInput:(nullable id)sender; + @end @interface MFTextView : UIView diff --git a/MVMCoreUI/Containers/TabBarController/TopTabbar.m b/MVMCoreUI/Containers/TabBarController/TopTabbar.m index 81686717..9b4e632c 100644 --- a/MVMCoreUI/Containers/TabBarController/TopTabbar.m +++ b/MVMCoreUI/Containers/TabBarController/TopTabbar.m @@ -300,9 +300,7 @@ static NSString * const COLLECTION_CELL_ID = @"cell"; } } -- (void)setUnderLineFromIndex:(NSIndexPath *)fromIndexPath toIndex:(NSIndexPath *)toIndexPath percentage:(CGFloat)percentage { - BOOL goRight = fromIndexPath.row < toIndexPath.row; - +- (void)setUnderLineFromIndex:(NSIndexPath *)fromIndexPath toIndex:(NSIndexPath *)toIndexPath percentage:(CGFloat)percentage { UICollectionViewCell *fromCell = [self.collectionView cellForItemAtIndexPath:fromIndexPath]; UICollectionViewCell *toCell = [self.collectionView cellForItemAtIndexPath:toIndexPath]; diff --git a/MVMCoreUI/TopAlert/MVMCoreUITopAlertExpandableView.m b/MVMCoreUI/TopAlert/MVMCoreUITopAlertExpandableView.m index 2be7c4f1..55bb6bfd 100644 --- a/MVMCoreUI/TopAlert/MVMCoreUITopAlertExpandableView.m +++ b/MVMCoreUI/TopAlert/MVMCoreUITopAlertExpandableView.m @@ -304,7 +304,7 @@ void(^completion)(void) = ^(void) { //accessibility - added to make only top alert label and close button accessible. Posted notification when top alert is displayed - weakSelf.accessibilityElements = @[_buttonView]; + weakSelf.accessibilityElements = @[weakSelf.buttonView]; weakSelf.shortView.isAccessibilityElement = NO; weakSelf.buttonView.label.accessibilityLabel = [NSString stringWithFormat:@"%@ - %@", [MVMCoreUIUtility hardcodedStringWithKey:@"top_alert_notification"],weakSelf.buttonView.label.accessibilityLabel]; UIAccessibilityPostNotification(UIAccessibilityScreenChangedNotification, weakSelf.buttonView.label);