mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Digital PCT265 story PCT-135: Code reivew. Comments misspellings.

Browse Source
This commit is contained in:
Hedden, Kyle Matthew 2024-05-29 18:00:32 -04:00
parent b3d1bd02b0
commit 4313041ae0
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MVMCoreUI/Atomic/Molecules/HorizontalCombinationViews/TabsModel.swift
View File

@ -132,7 +132,7 @@ open class TabsModel: MoleculeModelProtocol {
&& size == model.size
&& borderLine == model.borderLine
&& minWidth == model.minWidth
//&& selectedIndex == model.selectedIndex // Selected index could have been either reset locally or by server. For now ignore.c
//&& selectedIndex == model.selectedIndex // Selected index could have been either reset locally or by server. For now ignore.
&& tabs.isVisuallyEquivalent(to: model.tabs)
}
}

2
MVMCoreUI/Atomic/Protocols/ModelProtocols/MoleculeComparisonProtocol.swift
View File

@ -13,7 +13,7 @@ public protocol MoleculeModelComparisonProtocol: ModelComparisonProtocol {
/**
Shallow check if there are no visual differences between models.
By default if the models are equal then they are visually equivalent. However, if there are parts of models that can be upddated without a UI update, this could be subset of properties.
By default if the models are equal then they are visually equivalent. However, if there are parts of models that can be updated without a UI update, this could be subset of properties.
**/
func isVisuallyEquivalent(to model: MoleculeModelComparisonProtocol) -> Bool
}

2
MVMCoreUI/Atomic/Templates/MoleculeListTemplate.swift
View File

@ -273,7 +273,7 @@ open class MoleculeListTemplate: ThreeLayerTableViewController, TemplateProtocol
debugLog("Refreshing rows \(indexPaths.map { $0.row })")
if #available(iOS 15.0, *) {
// All rows should have been layed out already on the first newDataBuildScreen reload with the getMoleculeInfoList call. Therefore, we can be safe to assume the top level cell configuration will not be modified and only the child content will be updated allowing us to levearage this more efficient method.
// All rows should have been layed out already on the first newDataBuildScreen reload with the getMoleculeInfoList call. Therefore, we can be safe to assume the top level cell configuration will not be modified and only the child content will be updated allowing us to leverage this more efficient method.
tableView.reconfigureRows(at: indexPaths)
} else {
// A full reload can cause a flicker / animation. Better to avoid with above reconfigure method.

2
MVMCoreUI/BaseControllers/ViewController.swift
View File

@ -225,7 +225,7 @@ import MVMCore
return navigationModel
}
/// Processes any new data. Called after the page is loaded the first time and on response updates for this page, Triggers a render refresh.
/// Processes any new data. Called after the page is loaded the first time and on response updates for this page. Triggers a render refresh.
@MainActor
open func handleNewData(_ pageModel: PageModelProtocol? = nil) {